From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B78221B02822 for ; Fri, 23 Nov 2018 09:15:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2018 09:15:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="110750438" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga001.jf.intel.com with ESMTP; 23 Nov 2018 09:15:27 -0800 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 09:15:26 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.125]) by ORSMSX116.amr.corp.intel.com ([169.254.7.124]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 09:15:26 -0800 From: "Kinney, Michael D" To: "Wei, David" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Sun, Zailiang" , "Qian, Yi" Thread-Topic: [Patch] Vlv2TbltDevicePkg: Add build instructions for Minnowboard Max. Thread-Index: AQHUgvHHFuC4kxzG/k2wXReMXyNsaaVdmKgw Date: Fri, 23 Nov 2018 17:15:25 +0000 Message-ID: References: <20181123055951.18164-1-david.wei@intel.com> In-Reply-To: <20181123055951.18164-1-david.wei@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch] Vlv2TbltDevicePkg: Add build instructions for Minnowboard Max. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 17:15:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi David, These are not the correct instructions that take advantage of the PACKAGES_PATH feature. The directories with the binaries should not be copied into the edk2 repo area. Instead, WORKSPACE is set to the directory above edk2, and the binaries are placed in a directory that is a peer to edk2. Please see Readme.me in the QuarkPlatformPkg for an example of how to set up multiple paths with packages. https://github.com/tianocore/edk2/tree/master/QuarkPlatformPkg It uses edk2 repo and edk2-non-osi repo with a binary in the edk2-non-osi repo. Please try the equivalent configuration for Vlv2 and update the instructions to match. Thanks, Mike > -----Original Message----- > From: Wei, David > Sent: Thursday, November 22, 2018 10:00 PM > To: edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Qian, Yi > ; Kinney, Michael D > ; Wei, David > > Subject: [Patch] Vlv2TbltDevicePkg: Add build > instructions for Minnowboard Max. >=20 > Add build instructions for Minnowboard Max platform on > edk2 master. Change stitching script to follow this new > build instructions. >=20 > Test: Boot to Windows 10. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: David Wei > --- > Vlv2TbltDevicePkg/Documents/BuildInstructions.txt | 128 > ++++++++++++++++++++++ > Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat | 2 > +- > 2 files changed, 129 insertions(+), 1 deletion(-) > create mode 100644 > Vlv2TbltDevicePkg/Documents/BuildInstructions.txt >=20 > diff --git > a/Vlv2TbltDevicePkg/Documents/BuildInstructions.txt > b/Vlv2TbltDevicePkg/Documents/BuildInstructions.txt > new file mode 100644 > index 0000000000..a03c6ce3c4 > --- /dev/null > +++ b/Vlv2TbltDevicePkg/Documents/BuildInstructions.txt > @@ -0,0 +1,128 @@ > +## @file > +# Build Instructions for Minnowboard Max platform on > edk2 master. > +# > +# Copyright (c) 2018, Intel Corporation. All rights > reserved.
> +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and > conditions of the BSD License > +# which accompanies this distribution. The full text of > the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON > AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > +# > +# > +## > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + HOW TO CREATE A FULL SOURCE > TREE > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +1) Create a new folder (directory) on the root of your > local hard drive (development > + machine) for use as your work space (this example > uses "C:\MyWorkspace"). > + Some paths are very long and placing the working > directory too deep in the directory > + structure may cause the path to be longer than > Windows maximum path length. > + > +2) Checkout edk2 from GitHub with the following command. > + i) Run "git clone > https://github.com/tianocore/edk2.git" > + * This step will created a new folder > C:\MyWorkspace\edk2, which holds edk2 source code > downloaded. > + > +5) Download MinnowBoard MAX Binary Object Modules from : > (To be updated) > + > https://firmware.intel.com/sites/default/files/MinnowBoar > d_MAX-0.97-Binary.Objects.zip > + > + The MinnowBoard MAX Binary Object Modules contain > three additional > + folders required for the full source tree. > + > + IA32FamilyCpuPkg > + Vlv2BinaryPkg > + Vlv2MiscBinariesPkg > + > + Copy above 3 packages into "C:\MyWorkspace\edk2". > + > + > +6) Follow the instructions found in the file "OpenSSL- > HOWTO.txt" located in your > + workspace (e.g. > "C:\MyWorkspace\edk2\CryptoPkg\Library\OpensslLib\OpenSSL > -HOWTO.txt") > + to install the Openssl source code. > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + HOW TO BUILD (WINDOWS > ENVIRONMENT) > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +Windows System Configuration: > + Microsoft Windows 10 Enterprise 64-bit* > + > + Note: Below steps could also apply to Microsoft > Windows 8.1 and other version of Windows 10, > + but Intel only verify these steps on Microsoft > Windows 10 Enterprise 64-bit*. > + > +1. Setup Build Environment > + 1) Install C compiler Microsoft Visual Studio 2015 > with Update 3 in the build machine > + > + Note: Visual Studio 2008, 2010, 2012 and 2013 are > also supported, but Intel only verify > + with VS2015. > + > + 2) Obtain and install Python 2.7.10 from: > https://www.python.org/downloads/release/python-2710/ > + Make sure that a file with the extension of ".py" > will be opened by Python.exe. > + > +2. Extract Source Code > + 1) Follow the instructions of "HOW TO CREATE A FULL > SOURCE TREE" (step above) > + to create a full source tree. > + > +3. Install the iasl compiler by downloading iasl-win- > 20160527.zip from the following > + location: "https://acpica.org/downloads/" and place > the unzipped > + content ("iasl.exe") into the directory "C:\ASL" on > your local hard drive > + (create the folder "C:\ASL" if it does not exist). > + > +4. Install the NASM* assembly language compiler: > + Download NASM* 2.12.02 binaries from > + > http://www.nasm.us/pub/nasm/releasebuilds/2.12.02/win64/n > asm-2.12.02-win64.zip and place the > + unzipped content ("nasm.exe") into the directory > "C:\NASM" on your local hard drive > + (create the folder "C:\NASM" if it does not exist). > + > +5. Download a pre-compiled Openssl Windows binary from > + https://wiki.openssl.org/index.php/Binaries. Search > for a Windows binary in the list > + of "Third Party OpenSSL Related Binary > Distributions". Go to the third party site to > + download the latest version. Download and extract to > C:\Openssl, add the path of openssl.exe > + ("C:\openssl") to system environment variable > OPENSSL_PATH. > + > +6a. Build Steps (32-bit) > + 1) To build a 32-bit release version > + Open a command prompt of Microsoft Visual Studio, > such as "Developer Command > + Prompt for VS2015"; > + Type the command: "cd C:\MyWorkspace\edk2"; > + Type the command: "edksetup.bat Rebuild" to setup > build enviroment and tool; (Note: This command may > + report that some enviroment > varialbes need to be set for Python and NASM.) > + Type the command: "cd > C:\MyWorkspace\edk2\Vlv2TbltDevicePkg"; > + Type the command "Build_IFWI.bat /IA32 MNW2 > Release" to build a release version. > + > + 2) To build a 32-bit debug version > + Open a command prompt of Microsoft Visual Studio, > such as "Developer Command > + Prompt for VS2015"; > + Type the command: "cd C:\MyWorkspace\edk2"; > + Type the command: "edksetup.bat Rebuild" to setup > build enviroment and tool; (Note: This command may > + report that some enviroment > varialbes need to be set for Python and NASM.) > + Type the command: "cd > C:\MyWorkspace\edk2\Vlv2TbltDevicePkg"; > + Type command "Build_IFWI.bat /IA32 MNW2 Debug" to > build a debug version. > + > + 3) After the build successfully completes, the 8MB > firmware binary image will > + be located in the following location on your local > hard drive: > + "C:\MyWorkspace\edk2\Vlv2TbltDevicePkg\Stitch\" > + > +6b. Build Steps (64-bit) > + 1) To build a 64-bit release version > + Open a command prompt of Microsoft Visual Studio, > such as "Developer Command > + Prompt for VS2015"; > + Type the command: "cd C:\MyWorkspace\edk2"; > + Type the command: "edksetup.bat Rebuild" to setup > build enviroment and tool; (Note: This command may > + report that some enviroment > varialbes need to be set for Python and NASM.) > + Type the command: "cd > C:\MyWorkspace\edk2\Vlv2TbltDevicePkg"; > + Type the command "Build_IFWI.bat MNW2 Release" to > build a release version. > + > + 2) To build a 64-bit debug version > + Open a command prompt of Microsoft Visual Studio, > such as "Developer Command > + Prompt for VS2015"; > + Type the command: "cd C:\MyWorkspace\edk2"; > + Type the command: "edksetup.bat Rebuild" to setup > build enviroment and tool; (Note: This command may > + report that some enviroment > varialbes need to be set for Python and NASM.) > + Type the command: "cd > C:\MyWorkspace\edk2\Vlv2TbltDevicePkg"; > + Type command "Build_IFWI.bat MNW2 Debug" to build > a debug version. > + > + 3) After the build successfully completes, the 8MB > firmware binary image will > + be located in the following location on your local > hard drive: > + "C:\MyWorkspace\edk2\Vlv2TbltDevicePkg\Stitch\" > \ No newline at end of file > diff --git a/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat > b/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat > index 5f19983c91..5701cf8a49 100644 > --- a/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat > +++ b/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat > @@ -191,7 +191,7 @@ for %%i in (%BIOS_Names%) do ( > echo Generating IFWI... %BIOS_ID%.bin > echo. >=20 > - copy /b/y !IFWI_HEADER_FILE! + > %WORKSPACE%\Vlv2Binaries\Vlv2MiscBinariesPkg\SEC\!SEC_VER > SION!\VLV_SEC_REGION.bin + > %WORKSPACE%\Vlv2Binaries\Vlv2MiscBinariesPkg\SEC\!SEC_VER > SION!\Vacant.bin + !BIOS_Rom! %BIOS_ID%.bin > + copy /b/y !IFWI_HEADER_FILE! + > %WORKSPACE%\Vlv2MiscBinariesPkg\SEC\!SEC_VERSION!\VLV_SEC > _REGION.bin + > %WORKSPACE%\Vlv2MiscBinariesPkg\SEC\!SEC_VERSION!\Vacant. > bin + !BIOS_Rom! %BIOS_ID%.bin > echo. > echo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > ) > -- > 2.14.1.windows.1