From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C9FD21962301 for ; Wed, 9 Jan 2019 16:55:44 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 16:55:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,459,1539673200"; d="scan'208";a="310557355" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga005.fm.intel.com with ESMTP; 09 Jan 2019 16:55:44 -0800 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 9 Jan 2019 16:55:43 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.240]) by ORSMSX161.amr.corp.intel.com ([169.254.4.192]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 16:55:43 -0800 From: "Kinney, Michael D" To: Ashish Singhal , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Gao, Liming" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Thread-Index: AQHUqF4ffrguzufixkC70FWLQ9jDcaWnq9lg Date: Thu, 10 Jan 2019 00:55:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 00:55:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ashish, This V4 version of the patch produces the expected size=20 results for platform and driver builds. There are some very minor issues with some extra carriage returns, but those can be handled by Liming when the patch series is committed. I may be good to have an additional BZ to use these new APIs from all UEFI Driver Model drivers that have failure paths in their entry point or support the unload feature. Those updates can be done later. Thanks, Mike > -----Original Message----- > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > Sent: Wednesday, January 9, 2019 12:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, > Liming ; Fu, Siyuan > ; Wu, Jiaxin ; > Ashish Singhal > Subject: [PATCH v4 0/2] Provide UEFILib functions for > protocol uninstallation >=20 > An issue was seen in IScsiDxe in NetworkPkg where driver > cleanup after > initialization failure was not done right. Bug 1428 was > filed in this regard. > As per discussions with Mike, it was also discussed that > having UEFILib > provide protocol uninstallation abstraction would help > to avoid these > issues in the future. Bug 1429 was found to track this. > These 2 patches > take care of this. >=20 >=20 > Ashish Singhal (2): > MdePkg/UefiLib: Abstract driver model protocol > uninstallation > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall > protocols. >=20 > MdePkg/Include/Library/UefiLib.h | 103 ++++ > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > ++++++++++++++++++++++++++++++- > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > 3 files changed, 1085 insertions(+), 21 deletions(-) >=20 > -- > 2.7.4