From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5072E211B63E0 for ; Thu, 10 Jan 2019 08:53:14 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 08:53:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,462,1539673200"; d="scan'208";a="137157779" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2019 08:53:13 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.240]) by ORSMSX101.amr.corp.intel.com ([169.254.8.140]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 08:53:13 -0800 From: "Kinney, Michael D" To: "Gao, Liming" , Laszlo Ersek , "KarunakarPoosapalli@Dell.com" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Sumanth.Vidyadhara@dell.com" , "Gao, Liming" , "Sriramkumar.Raju@dell.com" Thread-Topic: [edk2] Conditional Compilation support in INF file Thread-Index: AdSn6DwaFQapYNOqQoKF9n2RWq0NjQAZUo0AAAOTrYAAJFxPAAAOWUmAAAYT1QAADrPWIA== Date: Thu, 10 Jan 2019 16:53:12 +0000 Message-ID: References: <1a62f519f4b2466fb97c0dd7a81057e6@BLRX13MDC432.AMER.DELL.COM> <03c8ee0d-dca5-a7ca-b941-f45bd0fd6c38@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AE69B@SHSMSX152.ccr.corp.intel.com> <3cd149b2ee7942dda2ebef04bd0f6977@BLRX13MDC432.AMER.DELL.COM> <63fd7d96-31f9-9a8d-6191-20c851ad54c3@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF0FC@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF0FC@SHSMSX152.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: Conditional Compilation support in INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 16:53:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable There is one additional constraint for adding conditionals to INF files. The UEFI Distribution Packaging Specification defines a=20 format to share package and module content in a standard format and uses an XML schema for the metadata. We need to be able to convert between INF <--> XML and DEC <--> XML. http://www.uefi.org/sites/default/files/resources/Dist_Package_Spec_1_1.pdf If we define extensions to INF or DEC files, we need to make sure these transforms are still supported. If an extension prevents these transforms, then we either need to change the extension to be compatible or work on an update to the UDP spec to support the extension in the XML. Best regards, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Gao, Liming > Sent: Thursday, January 10, 2019 7:48 AM > To: Laszlo Ersek ; > KarunakarPoosapalli@Dell.com; edk2-devel@lists.01.org > Cc: Sumanth.Vidyadhara@dell.com; Gao, Liming > ; Sriramkumar.Raju@dell.com > Subject: Re: [edk2] Conditional Compilation support in > INF file >=20 > I have same question. What flexibility is expected in > INF? I see one request in [Depex] section. So, PCD > support in [Depex] is added. >=20 > Edk2 INF is used to describe the source code behavior. > If the source uses Ppi/Protocol/Guid/Pcd, these > information are always required to be described in INF > file. The compiler can optimize the code and remove the > unused Ppi/Protocol/Guid/Pcd. It doesn't need developer > specify the conditional statement. >=20 > Thanks > Liming > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Thursday, January 10, 2019 8:54 PM > > To: KarunakarPoosapalli@Dell.com; Gao, Liming > ; edk2-devel@lists.01.org > > Cc: Sumanth.Vidyadhara@dell.com; > Sriramkumar.Raju@dell.com > > Subject: Re: [edk2] Conditional Compilation support in > INF file > > > > On 01/10/19 07:03, KarunakarPoosapalli@Dell.com wrote: > > > Hi All, > > > > > > I agree with providing the support like > "FixedAtBuild PCD in INF". And we need to modify or > provide support in BaseTools to support > > this feature. > > > > > > There are more use cases or flexibility to developer > if we support Conditional compilation support in INF. > > > As we're providing support in BaseTools for > FixedAtBuild PCD support in INF, Is there any challenges > or drawbacks in providing > > conditional compilation support in INF? > > > > This is not for me to say authoritatively, but I'm > unaware of any > > specific use case that cannot be solved without this > feature addition, > > and any further complexity to BaseTools should be > strongly justified. > > "More convenient" is too vague for me, and the > BaseTools code is already > > hard to read and debug. > > > > That's just my opinion, again. > > > > Thanks > > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel