From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0F77211B7F9E for ; Wed, 16 Jan 2019 09:46:38 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 09:46:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,486,1539673200"; d="scan'208";a="119015413" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga003.jf.intel.com with ESMTP; 16 Jan 2019 09:46:38 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.240]) by ORSMSX105.amr.corp.intel.com ([169.254.2.219]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 09:46:37 -0800 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [PATCH V3 15/17] QuarkMin: Use merged variable driver for emulated NV mode Thread-Index: AQHUrL1Me/X0F8MiOUmKp8Ba71ruPqWyLTrA Date: Wed, 16 Jan 2019 17:46:37 +0000 Message-ID: References: <1547548179-42552-1-git-send-email-star.zeng@intel.com> <1547548179-42552-16-git-send-email-star.zeng@intel.com> In-Reply-To: <1547548179-42552-16-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH V3 15/17] QuarkMin: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 17:46:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 15, 2019 2:30 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Steele, Kelly > > Subject: [PATCH V3 15/17] QuarkMin: Use merged variable > driver for emulated NV mode >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1323 > Merge EmuVariable and Real variable driver. >=20 > The real variable driver has been updated to support > emulated > variable NV mode and the EmuVariableRuntimeDxe will be > removed > later, so use merged variable driver for emulated NV > mode. >=20 > Cc: Michael D Kinney > Cc: Kelly Steele > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > QuarkPlatformPkg/QuarkMin.dsc | 8 ++++++-- > QuarkPlatformPkg/QuarkMin.fdf | 4 ++-- > 2 files changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/QuarkPlatformPkg/QuarkMin.dsc > b/QuarkPlatformPkg/QuarkMin.dsc > index d7a25686a30b..bf3a9a8bfd0e 100644 > --- a/QuarkPlatformPkg/QuarkMin.dsc > +++ b/QuarkPlatformPkg/QuarkMin.dsc > @@ -2,7 +2,7 @@ > # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB > flash devices. > # > # This package provides Clanton Peak CRB platform > specific modules. > -# Copyright (c) 2013 - 2018 Intel Corporation. > +# Copyright (c) 2013 - 2019 Intel Corporation. > # > # This program and the accompanying materials > # are licensed and made available under the terms and > conditions of the BSD License > @@ -342,6 +342,10 @@ [PcdsFixedAtBuild] > !endif >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x000 > 02000 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariab > leSize|0x1000 > + # > + # Make VariableRuntimeDxe work at emulated non- > volatile variable mode. > + # > + > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnabl > e|TRUE > ## RTC Update Timeout Value, need to increase timeout > since also > # waiting for RTC to be busy. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTim > eout|500000 > @@ -553,7 +557,7 @@ [Components.IA32] > MdeModulePkg/Universal/Metronome/Metronome.inf >=20 > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.in > f > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > - > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariabl > eRuntimeDxe.inf > + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRunti > meDxe.inf >=20 > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeD > xe.inf >=20 > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/Monoto > nicCounterRuntimeDxe.inf >=20 > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem > RuntimeDxe.inf > diff --git a/QuarkPlatformPkg/QuarkMin.fdf > b/QuarkPlatformPkg/QuarkMin.fdf > index b793fbd9a340..6e5545c16d3b 100644 > --- a/QuarkPlatformPkg/QuarkMin.fdf > +++ b/QuarkPlatformPkg/QuarkMin.fdf > @@ -2,7 +2,7 @@ > # FDF file of Clanton Peak CRB platform with 32-bit DXE > # > # This package provides QuarkNcSocId platform specific > modules. > -# Copyright (c) 2013 - 2017 Intel Corporation. > +# Copyright (c) 2013 - 2019 Intel Corporation. > # > # This program and the accompanying materials > # are licensed and made available under the terms and > conditions of the BSD License > @@ -388,7 +388,7 @@ [FV.FVMAIN] > INF MdeModulePkg/Universal/Metronome/Metronome.inf > INF > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.in > f > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > -INF > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariabl > eRuntimeDxe.inf > +INF > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRunti > meDxe.inf > INF > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeD > xe.inf > INF > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/Monoto > nicCounterRuntimeDxe.inf > INF > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem > RuntimeDxe.inf > -- > 2.7.0.windows.1