From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5521D211B8182 for ; Wed, 16 Jan 2019 11:00:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 11:00:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,487,1539673200"; d="scan'208";a="312375515" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga005.fm.intel.com with ESMTP; 16 Jan 2019 11:00:05 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.240]) by ORSMSX109.amr.corp.intel.com ([169.254.11.204]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 11:00:04 -0800 From: "Kinney, Michael D" To: Ard Biesheuvel , "Gao, Liming" , "Qian, Yi" , "Kinney, Michael D" CC: "Wu, Hao A" , "edk2-devel@lists.01.org" , Laszlo Ersek , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution Thread-Index: AQHUrA0Ew6NThbEBh0qgWP6s1dS7x6WyikwAgAAqBgD//47J4A== Date: Wed, 16 Jan 2019 19:00:04 +0000 Message-ID: References: <20190114132758.24054-1-ard.biesheuvel@linaro.org> <20190114132758.24054-5-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B3306@SHSMSX152.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 19:00:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Wednesday, January 16, 2019 9:45 AM > To: Gao, Liming ; Qian, Yi > > Cc: Wu, Hao A ; edk2- > devel@lists.01.org; Kinney, Michael D > ; Laszlo Ersek > ; Zeng, Star > Subject: Re: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: > add MmServicesTableLib resolution >=20 > (add Yi as well) >=20 > On Wed, 16 Jan 2019 at 16:14, Gao, Liming > wrote: > > > > Zailiang: > > Could you help review this change? > > > > > -----Original Message----- > > > From: Ard Biesheuvel > [mailto:ard.biesheuvel@linaro.org] > > > Sent: Monday, January 14, 2019 9:28 PM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel ; > Laszlo Ersek ; Leif Lindholm > ; Kinney, > > > Michael D ; Gao, Liming > ; Wang, Jian J > ; Wu, Hao A > > > ; Jagadeesh Ujja > ; Achin Gupta > ; Thomas Panakamattam > > > Abraham ; Sami Mujawar > ; Zeng, Star > > > Subject: [PATCH v2 04/17] Vlv2TbltDevicePkg: add > MmServicesTableLib resolution > > > > > > The SMM based FTW and variable drivers are going to > depend on > > > MmServicesTableLib after a subsequent patch, so add > a resolution > > > for it to various Vlv2TbltDevicePkg .dsc files. > > > > > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > > Signed-off-by: Ard Biesheuvel > > > > --- > > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > > 3 files changed, 3 insertions(+) > > > > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > index d43611550285..eb7c205a10a6 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > @@ -406,6 +406,7 @@ [LibraryClasses.X64.DXE_CORE] > > > !endif > > > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmS > ervicesTableLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/S > mmServicesTableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatus > CodeLib/SmmReportStatusCodeLib.inf > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLi > b/SmmMemoryAllocationLib.inf > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > index a33816c4d18b..b2f0d73f6d05 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > @@ -406,6 +406,7 @@ [LibraryClasses.IA32.DXE_CORE] > > > !endif > > > > > > [LibraryClasses.IA32.DXE_SMM_DRIVER] > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmS > ervicesTableLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/S > mmServicesTableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatus > CodeLib/SmmReportStatusCodeLib.inf > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLi > b/SmmMemoryAllocationLib.inf > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > index 1da1442c64c6..aa62c07f177b 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > @@ -408,6 +408,7 @@ [LibraryClasses.X64.DXE_CORE] > > > !endif > > > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmS > ervicesTableLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/S > mmServicesTableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatus > CodeLib/SmmReportStatusCodeLib.inf > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLi > b/SmmMemoryAllocationLib.inf > > > -- > > > 2.20.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel