From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg
Date: Tue, 22 Jan 2019 23:31:34 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8B8740C@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20190122185825.21664-1-michael.a.kubacki@intel.com>
Hi Michael,
1) Is this content intended for a new branch or an
existing branch in the edk2-platforms repo? The
subject line of the commit message can help clarify
this. The required format is:
[PATCH][platforms/branch]: Package/Module: Subject
2) The patch email size is large (2MB). Can you break
it up into a patch series. Perhaps one for the new
package with its DEC/Includes, one or more for the
package libraries, one or more for the package modules,
and one for the package DSC/FDF/platform build files?
Try to target < 500KB per patch.
If a patch series is large, another recommendation
is to also post the patch series to a personal GitHub
account to support review/test by the community.
3) I see .bat files. Are there any plans to support
non windows build environments?
4) If you run BaseTools/Scripts/PatchCheck.py, there
are 2 minor issues to resolve.
Best regards,
Mike
next prev parent reply other threads:[~2019-01-22 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 18:58 [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg Michael Kubacki
2019-01-22 23:31 ` Kinney, Michael D [this message]
2019-01-23 2:23 ` Kubacki, Michael A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8B8740C@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox