From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6EB762119FF36 for ; Tue, 22 Jan 2019 15:31:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 15:31:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,508,1539673200"; d="scan'208";a="111868087" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga008.jf.intel.com with ESMTP; 22 Jan 2019 15:31:34 -0800 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 22 Jan 2019 15:31:34 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.240]) by ORSMSX152.amr.corp.intel.com ([169.254.8.53]) with mapi id 14.03.0415.000; Tue, 22 Jan 2019 15:31:34 -0800 From: "Kinney, Michael D" To: "Kubacki, Michael A" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Wu, Hao A" , "Gao, Liming" , "Yao, Jiewen" Thread-Topic: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg Thread-Index: AQHUsoSM5Qx+ii03CUq3P9XkZHwlbaW769QA Date: Tue, 22 Jan 2019 23:31:34 +0000 Message-ID: References: <20190122185825.21664-1-michael.a.kubacki@intel.com> In-Reply-To: <20190122185825.21664-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 23:31:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, 1) Is this content intended for a new branch or an=20 existing branch in the edk2-platforms repo? The subject line of the commit message can help clarify this. The required format is: [PATCH][platforms/branch]: Package/Module: Subject 2) The patch email size is large (2MB). Can you break=20 it up into a patch series. Perhaps one for the new package with its DEC/Includes, one or more for the package libraries, one or more for the package modules, and one for the package DSC/FDF/platform build files? Try to target < 500KB per patch. If a patch series is large, another recommendation is to also post the patch series to a personal GitHub account to support review/test by the community. 3) I see .bat files. Are there any plans to support non windows build environments? 4) If you run BaseTools/Scripts/PatchCheck.py, there are 2 minor issues to resolve. Best regards, Mike