From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B4345211D616E for ; Mon, 18 Mar 2019 11:17:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 11:17:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,494,1544515200"; d="scan'208";a="126472216" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga008.jf.intel.com with ESMTP; 18 Mar 2019 11:17:26 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Mar 2019 11:17:26 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.233]) by ORSMSX160.amr.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 11:17:25 -0700 From: "Kinney, Michael D" To: Laszlo Ersek , "Kinney, Michael D" CC: "Justen, Jordan L" , "edk2-devel@lists.01.org" , Julien Grall , "Anthony Perard" Thread-Topic: [edk2] PATCH] Change EDK II to BSD+Patent License Thread-Index: AdTZwcNzZrV0RAT0RT2g/5KRKEfA3wAzWQkAAMnk8AA= Date: Mon, 18 Mar 2019 18:17:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: PATCH] Change EDK II to BSD+Patent License X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 18:17:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Thanks for the feedback. I will entered a few BZs based on this feedback and will provide a V2 version of the content. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, March 14, 2019 3:56 AM > To: Kinney, Michael D > Cc: Justen, Jordan L ; edk2- > devel@lists.01.org; Julien Grall > ; Anthony Perard > > Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent > License >=20 > Hi Mike, >=20 > On 03/13/19 18:54, Kinney, Michael D wrote: > > Hello, > > > > BZ: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1373 > > > > This change is based on the following emails: > > https://lists.01.org/pipermail/edk2-devel/2019- > February/036260.html > > https://lists.01.org/pipermail/edk2-devel/2018- > October/030385.html > > > > RFCs with detailed process for the license change: > > https://lists.01.org/pipermail/edk2-devel/2019- > March/037669.html > > https://lists.01.org/pipermail/edk2-devel/2019- > March/037500.html > > > > I have posted the patch series for review on the > following branch > > using edk2-stable201903 as the base for the patch > series. > > > > > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten > tLicense > > > > The commits in patch series can be viewed here: > > > > > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa > tentLicense > > > > The patch series has one patch per package along with > a few patches > > to update the license information in the root of the > edk2 repository > > as described in the RFC V2. > > > > Due to the size of the patch series, I prefer to not > send the > > patch emails. Instead, please perform code reviews > using content > > from the branch. > > > > All EDK II package maintainers and package reviewers > should provide > > review feedback for their packages. The critical > part of the review > > is: > > 1) Any changes that cause build breaks or logic > changes. These code > > changes are intended to only modify license > contents in comment > > blocks. > > 2) Any file that has been changed to BSD+Patent, but > should remain > > with the current license. > > 3) Any file that that has not changed to BSD+Patent, > but should be > > changed to BSD+Patent. > > > > Feedback and Reviewed-by emails should identify the > patch the feedback > > applies using the patch summary listed below. The > goal is to complete > > all reviews to support the commit of these patches on > April 9, 2019. >=20 > [...] >=20 >=20 > > 837a3425bf OvmfPkg: Replace BSD License with > BSD+Patent License >=20 > (1) For the commit message, I have the following > suggestions: >=20 > (1.1) please remove the "Cc:" tags, because you aren't > actually posting > the patches to the mailing list, so the people > listed in Cc have > no chance to receive the patch by email ("carbon- > copied") >=20 > (1.2) please remove the "Branch for review" reference > as well -- while I > certainly prefer such branch references ot remain > valid forever, > in practice their longevity is quite dubious in > comparison to e.g. > mailing list archive links. >=20 > (2) Regarding the patch body: >=20 > (2.1) I reviewed each of the 348 hunks in the patch > file. They are > correct, with one exception: >=20 > (2.1.1) "create-release.py" doesn't only contain a > copyright block > (which is correctly patches), but it also > *generates* a > copyright block. (Search it manually for > "http://opensource.org/licenses/bsd- > license.php".) In my > opinion, we should simply retire this python > script, *before* > the conversion is started -- I don't remember > using it in recent > years, plus now we have the stable tags, for > open source > community-oriented releases. >=20 > (2.2) 30 files under OvmfPkg remain without "SPDX- > License-Identifier: > BSD-2-Clause-Patent" after the patch is applied. > These can be > categorized as follows: >=20 > (2.2.1) Files without any copyright notices (very small > files, > README-like files, generated files): >=20 > OvmfPkg/Csm/Csm16/ReadMe.txt > OvmfPkg/Include/IndustryStandard/Xen/README > OvmfPkg/README >=20 >=20 > OvmfPkg/Library/XenHypercallLib/Ia32/hypercall.nasm >=20 > OvmfPkg/Library/XenHypercallLib/X64/hypercall.nasm > OvmfPkg/XenBusDxe/Helpers.c >=20 > OvmfPkg/QemuVideoDxe/VbeShim.h >=20 > It's fine to leave these untouched. >=20 > (2.2.2) Files that seem to be covered by the MIT > license. >=20 > OvmfPkg/Include/IndustryStandard/Xen/arch- > arm/xen.h > OvmfPkg/Include/IndustryStandard/Xen/arch- > x86/xen-x86_32.h > OvmfPkg/Include/IndustryStandard/Xen/arch- > x86/xen-x86_64.h > OvmfPkg/Include/IndustryStandard/Xen/arch- > x86/xen.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/event_channel.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/grant_table.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/console.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/ring.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h >=20 > OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h > OvmfPkg/Include/IndustryStandard/Xen/memory.h > OvmfPkg/Include/IndustryStandard/Xen/xen- > compat.h > OvmfPkg/Include/IndustryStandard/Xen/xen.h > OvmfPkg/XenBusDxe/XenBus.c > OvmfPkg/XenBusDxe/XenStore.c > OvmfPkg/XenBusDxe/XenStore.h >=20 > It's OK to leave these untouched, for now. > Later, we should > probably replace their license blocks with > "SPDX-License-Identifier: MIT" (as > appropriate). It might make > sense to file a TianoCore BZ about them > immediately, with a > BZ-dependency on BZ#1373. >=20 > (2.2.3) The following file is untouched, but it should > be updated. It > requires special (not scripted) treatment. >=20 > OvmfPkg/License.txt >=20 > (2.2.4) The following files seem to be under 2-BSDL, > but without a link > to license.php> -- which is > why I believe the script must have missed them. > They should be > converted manually. >=20 > OvmfPkg/XenBusDxe/GrantTable.c > OvmfPkg/XenPvBlkDxe/BlockFront.c >=20 > Important: when you update the series, please do not > force-push your > current "Bug_1373_BsdPatentLicense" branch! Instead, > please push > "Bug_1373_BsdPatentLicense_v2". >=20 > [...] >=20 >=20 > > 908d82c3fd ArmVirtPkg: Replace BSD License with > BSD+Patent License >=20 > (3) The same commit message observations apply as under > (1). >=20 > With those commit message updates, the ArmVirtPkg patch > (currently > commit 908d82c3fd in your branch) will be eligible for > my R-b. The > conversions done by the patch appear correct, no links > to > > remain, and after the > patch, no file remains without "SPDX-License- > Identifier: > BSD-2-Clause-Patent". >=20 >=20 > I haven't done any build testing, partly because the > patches look safe, > and partly because any future updates (to OvmfPkg, > MdePkg, MdeModulePkg > etc) would invalidate such testing anyway. We should do > build testing > once all of the patches in the series have been > approved. (More > precisely, a DSC can be test-built if its own package, > and all the > packages it depends upon, have been reviewed.) >=20 > Thank you! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel