PATCH] Change EDK II to BSD+Patent License

PATCH] Change EDK II to BSD+Patent License

[Kinney, Michael D]

Hello,

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373

This change is based on the following emails:
  https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
  https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html

RFCs with detailed process for the license change:
  https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
  https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html

I have posted the patch series for review on the following branch using
edk2-stable201903 as the base for the patch series.  

  https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense

The commits in patch series can be viewed here:

  https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense

The patch series has one patch per package along with a few patches
to update the license information in the root of the edk2 repository
as described in the RFC V2.

Due to the size of the patch series, I prefer to not send the
patch emails.  Instead, please perform code reviews using content
from the branch.

All EDK II package maintainers and package reviewers should provide
review feedback for their packages.  The critical part of the review
is:
1) Any changes that cause build breaks or logic changes.  These code
   changes are intended to only modify license contents in comment
   blocks.
2) Any file that has been changed to BSD+Patent, but should remain
   with the current license.
3) Any file that that has not changed to BSD+Patent, but should be
   changed to BSD+Patent. 

Feedback and Reviewed-by emails should identify the patch the feedback
applies using the patch summary listed below.  The goal is to complete
all reviews to support the commit of these patches on April 9, 2019.
 
84141eacac edk2: Remove Contributions.txt and update Readme.md
93b121ee79 StdLibPrivateInternalFiles: Replace BSD License with BSD+Patent License
91a1d41ccb StdLib: Replace BSD License with BSD+Patent License
a71c378242 AppPkg: Replace BSD License with BSD+Patent License
4eb2592e65 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent License
7b719f9c0a Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent License
1472567223 UefiCpuPkg: Replace BSD License with BSD+Patent License
3001241ef7 StandaloneMmPkg: Replace BSD License with BSD+Patent License
e5dddf6e52 SourceLevelDebugPkg: Replace BSD License with BSD+Patent License
e83800c47a SignedCapsulePkg: Replace BSD License with BSD+Patent License
3a58ac55fd ShellPkg: Replace BSD License with BSD+Patent License
b16c29f4d9 ShellBinPkg: Replace BSD License with BSD+Patent License
bf4838b342 SecurityPkg: Replace BSD License with BSD+Patent License
2da66fa9f1 QuarkSocPkg: Replace BSD License with BSD+Patent License
f52f862821 QuarkPlatformPkg: Replace BSD License with BSD+Patent License
571f6e2af1 PcAtChipsetPkg: Replace BSD License with BSD+Patent License
837a3425bf OvmfPkg: Replace BSD License with BSD+Patent License
d548789dff OptionRomPkg: Replace BSD License with BSD+Patent License
88cbe4e446 Omap35xxPkg: Replace BSD License with BSD+Patent License
452a4e54da Nt32Pkg: Replace BSD License with BSD+Patent License
41704de255 NetworkPkg: Replace BSD License with BSD+Patent License
07716613d3 MdePkg: Replace BSD License with BSD+Patent License
bfd7b0e6aa MdeModulePkg: Replace BSD License with BSD+Patent License
9d991b5dff IntelSiliconPkg: Replace BSD License with BSD+Patent License
6c2833f076 IntelFspWrapperPkg: Replace BSD License with BSD+Patent License
c679ff1058 IntelFspPkg: Replace BSD License with BSD+Patent License
8623e16830 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent License
40e4b295f8 IntelFsp2Pkg: Replace BSD License with BSD+Patent License
36ea637247 IntelFrameworkPkg: Replace BSD License with BSD+Patent License
0c6f14fb2f IntelFrameworkModulePkg: Replace BSD License with BSD+Patent License
79ea5a27b9 FmpDevicePkg: Replace BSD License with BSD+Patent License
a8e09bbdac FatPkg: Replace BSD License with BSD+Patent License
81322a8327 EmulatorPkg: Replace BSD License with BSD+Patent License
88e68e0fbc EmbeddedPkg: Replace BSD License with BSD+Patent License
c3176994e5 EdkCompatibilityPkg: Replace BSD License with BSD+Patent License
06bca42822 DynamicTablesPkg: Replace BSD License with BSD+Patent License
5bdb990eb2 CryptoPkg: Replace BSD License with BSD+Patent License
40472d5724 CorebootPayloadPkg: Replace BSD License with BSD+Patent License
a87f66c6a6 CorebootModulePkg: Replace BSD License with BSD+Patent License
18a480540a BeagleBoardPkg: Replace BSD License with BSD+Patent License
908d82c3fd ArmVirtPkg: Replace BSD License with BSD+Patent License
4eb0a6b673 ArmPlatformPkg: Replace BSD License with BSD+Patent License
a376999cfd ArmPkg: Replace BSD License with BSD+Patent License
20b76852bb BaseTools: Replace BSD License with BSD+Patent License
15cfa51d6f edk2: Replace BSD License with BSD+Patent License
75c4e96f35 edk2: Change License.txt from 2-Clause BSD to BSD+Patent
1daf0f13e1 edk2: Add License-History.txt

Best regards,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, March 12, 2019 11:01 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org
> Subject: Re: [edk2] [RFC v2] Change EDK II to
> BSD+Patent License
> 
> On 03/10/19 01:15, Kinney, Michael D wrote:
> > Hello,
> >
> > Changes for V2
> > ===============
> > * Replace 2-Clause BSD License in file headers with
> SPDX-License-Identifier
> >   statement.  This reduces the size of the file
> headers and the size
> >   of the patches for this change.  Based on the
> following post:
> >
> >   https://01.org/blogs/jc415/2018/open-source-hacks-
> one-question-interviews-open-source-experts-how-use-
> spdx-headers
> 
> This looks real nice.
> 
> Thanks
> Laszlo
> 
> >
> > * Update License.txt in root of edk2 before changing
> file headers.
> > * Fix minor typos
> > ===============
> >
> > This RFC follows up on the proposal from Mark Doran
> to change the
> > EDK II Project to a BSD+Patent License.
> >
> > 	https://lists.01.org/pipermail/edk2-devel/2019-
> February/036260.html
> >
> > The review period for this license change is 30 days.
> If there is no
> > unresolved feedback on April 9, 2019, then commits of
> the license change
> > patches will begin on April 9, 2019.
> >
> >   ** Please provide feedback on the proposal by
> Monday April 8, 2019. **
> >
> > Feedback can be sent to edk2-devel@lists.01.org, the
> EDK II community
> > manager or any of the EDK II stewards.
> >
> >   * Stephano Cetola <stephano.cetola@intel.com>
> Community Manager
> >   * Leif Lindholm   <leif.lindholm@linaro.org>
> Steward
> >   * Andrew Fish     <afish@apple.com>
> Steward
> >   * Laszlo Ersek    <lersek@redhat.com>
> Steward
> >   * Michael Kinney  <michael.d.kinney@intel.com>
> Steward
> >
> > The goal is to convert all of the files in the edk2
> repository that are
> > currently covered by the 2-Clause BSD License and the
> TianoCore
> > Contribution Agreement to a BSD+Patent License.
> >
> > I will be following up with pointers to public GitHub
> branches that
> > contain the set of changes to the edk2 repository for
> review.
> >
> > The proposal is to perform this change to edk2/master
> in the steps listed
> > below. The license change will not be applied to any
> of the other existing
> > branches in the edk2 repository.
> >
> > 1) Add a License-History.txt file to the root of the
> edk2 repository that
> >    contains the 2-Clause BSD License and the
> TianoCore Contribution
> >    Agreement along with the details on the change to
> the BSD+Patent License.
> >
> > 2) Change License.txt in the root of the edk2
> repository from a 2-Clause
> >    BSD License to the BSD+Patent License. The
> following is the link to the
> >    BSD+Patent License and the new License.txt file
> contents.
> >
> >    https://opensource.org/licenses/BSDplusPatent
> >
> >
> =======================================================
> ===============
> >    Redistribution and use in source and binary forms,
> with or without
> >    modification, are permitted provided that the
> following conditions are met:
> >
> >    1. Redistributions of source code must retain the
> above copyright notice,
> >       this list of conditions and the following
> disclaimer.
> >
> >    2. Redistributions in binary form must reproduce
> the above copyright notice,
> >       this list of conditions and the following
> disclaimer in the documentation
> >       and/or other materials provided with the
> distribution.
> >
> >    Subject to the terms and conditions of this
> license, each copyright holder
> >    and contributor hereby grants to those receiving
> rights under this license
> >    a perpetual, worldwide, non-exclusive, no-charge,
> royalty-free, irrevocable
> >    (except for failure to satisfy the conditions of
> this license) patent
> >    license to make, have made, use, offer to sell,
> sell, import, and otherwise
> >    transfer this software, where such license applies
> only to those patent
> >    claims, already acquired or hereafter acquired,
> licensable by such copyright
> >    holder or contributor that are necessarily
> infringed by:
> >
> >    (a) their Contribution(s) (the licensed copyrights
> of copyright holders and
> >        non-copyrightable additions of contributors,
> in source or binary form)
> >        alone; or
> >
> >    (b) combination of their Contribution(s) with the
> work of authorship to
> >        which such Contribution(s) was added by such
> copyright holder or
> >        contributor, if, at the time the Contribution
> is added, such addition
> >        causes such combination to be necessarily
> infringed. The patent license
> >        shall not apply to any other combinations
> which include the
> >        Contribution.
> >
> >    Except as expressly stated above, no rights or
> licenses from any copyright
> >    holder or contributor is granted under this
> license, whether expressly, by
> >    implication, estoppel or otherwise.
> >
> >    DISCLAIMER
> >
> >    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS
> AND CONTRIBUTORS "AS IS"
> >    AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
> BUT NOT LIMITED TO, THE
> >    IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> FOR A PARTICULAR PURPOSE
> >    ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> HOLDERS OR CONTRIBUTORS BE
> >    LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL, EXEMPLARY, OR
> >    CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
> TO, PROCUREMENT OF
> >    SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
> OR PROFITS; OR BUSINESS
> >    INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
> LIABILITY, WHETHER IN
> >    CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
> NEGLIGENCE OR OTHERWISE)
> >    ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE
> >    POSSIBILITY OF SUCH DAMAGE.
> >
> =======================================================
> ===============
> >
> > 3) Change all files currently covered by a 2-Clause
> BSD License and the
> >    TianoCore Contribution Agreement to a BSD+Patent
> License using the
> >    following SPDX-License-Identifier statement:
> >
> >        SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >    The use of SPDX-License-Identifier statement is
> based on the following:
> >
> >         https://01.org/blogs/jc415/2018/open-source-
> hacks-one-question-interviews-open-source-experts-how-
> use-spdx-headers
> >
> > 4) Update Readme.md in the root of the edk2
> repository to state that content
> >    is covered by a BSD+Patent License.  Also state
> that the BSD+Patent License
> >    is the preferred license for the EDK II project.
> >
> > 5) Remove the Contributions.txt file from the root of
> the edk2 repository
> >    that contains the TianoCore Contribution
> Agreement.
> >
> > 6) Update all documentation to state that content
> submitted under the
> >    BSD+Patent License no longer requires the
> Tianocore Contribution
> >    Agreement which means the following line is not
> required in commit
> >    messages for changes to files that are covered by
> a BSD+Patent License.
> >
> >        Contributed-under: TianoCore Contribution
> Agreement 1.1
> >
> > 7) Create Wiki page(s) that provide the details of
> the BSD+Patent License
> >    change and provides the status of the license
> change for each TianoCore
> >    repository and package.
> >
> > Once the conversion of the edk2 repository is
> complete, work will begin
> > on the other repositories in the TianoCore project.
> >
> > Best regards,
> >
> > Mike
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

Hi Mike,

On 03/13/19 18:54, Kinney, Michael D wrote:
> Hello,
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
>
> This change is based on the following emails:
>   https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
>   https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
>
> RFCs with detailed process for the license change:
>   https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
>   https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
>
> I have posted the patch series for review on the following branch
> using edk2-stable201903 as the base for the patch series.
>
>   https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense
>
> The commits in patch series can be viewed here:
>
>   https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense
>
> The patch series has one patch per package along with a few patches
> to update the license information in the root of the edk2 repository
> as described in the RFC V2.
>
> Due to the size of the patch series, I prefer to not send the
> patch emails.  Instead, please perform code reviews using content
> from the branch.
>
> All EDK II package maintainers and package reviewers should provide
> review feedback for their packages.  The critical part of the review
> is:
> 1) Any changes that cause build breaks or logic changes.  These code
>    changes are intended to only modify license contents in comment
>    blocks.
> 2) Any file that has been changed to BSD+Patent, but should remain
>    with the current license.
> 3) Any file that that has not changed to BSD+Patent, but should be
>    changed to BSD+Patent.
>
> Feedback and Reviewed-by emails should identify the patch the feedback
> applies using the patch summary listed below.  The goal is to complete
> all reviews to support the commit of these patches on April 9, 2019.

[...]


> 837a3425bf OvmfPkg: Replace BSD License with BSD+Patent License

(1) For the commit message, I have the following suggestions:

(1.1) please remove the "Cc:" tags, because you aren't actually posting
      the patches to the mailing list, so the people listed in Cc have
      no chance to receive the patch by email ("carbon-copied")

(1.2) please remove the "Branch for review" reference as well -- while I
      certainly prefer such branch references ot remain valid forever,
      in practice their longevity is quite dubious in comparison to e.g.
      mailing list archive links.

(2) Regarding the patch body:

(2.1) I reviewed each of the 348 hunks in the patch file. They are
      correct, with one exception:

(2.1.1) "create-release.py" doesn't only contain a copyright block
        (which is correctly patches), but it also *generates* a
        copyright block. (Search it manually for
        "http://opensource.org/licenses/bsd-license.php".) In my
        opinion, we should simply retire this python script, *before*
        the conversion is started -- I don't remember using it in recent
        years, plus now we have the stable tags, for open source
        community-oriented releases.

(2.2) 30 files under OvmfPkg remain without "SPDX-License-Identifier:
      BSD-2-Clause-Patent" after the patch is applied. These can be
      categorized as follows:

(2.2.1) Files without any copyright notices (very small files,
        README-like files, generated files):

          OvmfPkg/Csm/Csm16/ReadMe.txt
          OvmfPkg/Include/IndustryStandard/Xen/README
          OvmfPkg/README

          OvmfPkg/Library/XenHypercallLib/Ia32/hypercall.nasm
          OvmfPkg/Library/XenHypercallLib/X64/hypercall.nasm
          OvmfPkg/XenBusDxe/Helpers.c

          OvmfPkg/QemuVideoDxe/VbeShim.h

        It's fine to leave these untouched.

(2.2.2) Files that seem to be covered by the MIT license.

          OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
          OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h
          OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
          OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h
          OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
          OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
          OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
          OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
          OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
          OvmfPkg/Include/IndustryStandard/Xen/io/console.h
          OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
          OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
          OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
          OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
          OvmfPkg/Include/IndustryStandard/Xen/memory.h
          OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h
          OvmfPkg/Include/IndustryStandard/Xen/xen.h
          OvmfPkg/XenBusDxe/XenBus.c
          OvmfPkg/XenBusDxe/XenStore.c
          OvmfPkg/XenBusDxe/XenStore.h

        It's OK to leave these untouched, for now. Later, we should
        probably replace their license blocks with
        "SPDX-License-Identifier: MIT" (as appropriate). It might make
        sense to file a TianoCore BZ about them immediately, with a
        BZ-dependency on BZ#1373.

(2.2.3) The following file is untouched, but it should be updated. It
        requires special (not scripted) treatment.

          OvmfPkg/License.txt

(2.2.4) The following files seem to be under 2-BSDL, but without a link
        to <http://opensource.org/licenses/bsd-license.php> -- which is
        why I believe the script must have missed them. They should be
        converted manually.

          OvmfPkg/XenBusDxe/GrantTable.c
          OvmfPkg/XenPvBlkDxe/BlockFront.c

Important: when you update the series, please do not force-push your
current "Bug_1373_BsdPatentLicense" branch! Instead, please push
"Bug_1373_BsdPatentLicense_v2".

[...]


> 908d82c3fd ArmVirtPkg: Replace BSD License with BSD+Patent License

(3) The same commit message observations apply as under (1).

With those commit message updates, the ArmVirtPkg patch (currently
commit 908d82c3fd in your branch) will be eligible for my R-b. The
conversions done by the patch appear correct, no links to
<http://opensource.org/licenses/bsd-license.php> remain, and after the
patch, no file remains without "SPDX-License-Identifier:
BSD-2-Clause-Patent".


I haven't done any build testing, partly because the patches look safe,
and partly because any future updates (to OvmfPkg, MdePkg, MdeModulePkg
etc) would invalidate such testing anyway. We should do build testing
once all of the patches in the series have been approved. (More
precisely, a DSC can be test-built if its own package, and all the
packages it depends upon, have been reviewed.)

Thank you!
Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Julien Grall]

(+ Lars)

On 3/14/19 10:55 AM, Laszlo Ersek wrote:
> On 03/13/19 18:54, Kinney, Michael D wrote:
> (2.2.2) Files that seem to be covered by the MIT license.
> 
>            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
>            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h
>            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
>            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h
>            OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
>            OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
>            OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
>            OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/console.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
>            OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
>            OvmfPkg/Include/IndustryStandard/Xen/memory.h
>            OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h
>            OvmfPkg/Include/IndustryStandard/Xen/xen.h
>            OvmfPkg/XenBusDxe/XenBus.c
>            OvmfPkg/XenBusDxe/XenStore.c
>            OvmfPkg/XenBusDxe/XenStore.h
> 
>          It's OK to leave these untouched, for now. Later, we should
>          probably replace their license blocks with
>          "SPDX-License-Identifier: MIT" (as appropriate). It might make
>          sense to file a TianoCore BZ about them immediately, with a
>          BZ-dependency on BZ#1373.

I have added Lars Kurth to confirm the license.

> 
> (2.2.3) The following file is untouched, but it should be updated. It
>          requires special (not scripted) treatment.
> 
>            OvmfPkg/License.txt
> 
> (2.2.4) The following files seem to be under 2-BSDL, but without a link
>          to <http://opensource.org/licenses/bsd-license.php> -- which is
>          why I believe the script must have missed them. They should be
>          converted manually.
> 
>            OvmfPkg/XenBusDxe/GrantTable.c
>            OvmfPkg/XenPvBlkDxe/BlockFront.c

That's correct, they are licensed under 2-clause BSD.

Cheers,

-- 
Julien Grall

Re: PATCH] Change EDK II to BSD+Patent License

[Julien Grall]

Hi Lars,

On 14/03/2019 20:04, Lars Kurth wrote:
> 
> 
> On 14/03/2019, 12:07, "Julien Grall" <julien.grall@arm.com> wrote:
> 
>      (+ Lars)
>      
>      On 3/14/19 10:55 AM, Laszlo Ersek wrote:
>      > On 03/13/19 18:54, Kinney, Michael D wrote:
>      > (2.2.2) Files that seem to be covered by the MIT license.
>      >
>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
> ...
>      >            OvmfPkg/XenBusDxe/XenStore.h
>      >
>      >          It's OK to leave these untouched, for now. Later, we should
>      >          probably replace their license blocks with
>      >          "SPDX-License-Identifier: MIT" (as appropriate). It might make
>      >          sense to file a TianoCore BZ about them immediately, with a
>      >          BZ-dependency on BZ#1373.
>      
>      I have added Lars Kurth to confirm the license.
> 
> Can you give me some context? It's not clear to me what you expect me to do.

EDK2 is converting the full copyright in each file to SDPX identifier. While the 
copyright looks like an MIT license, it has never been confirmed. Andrew Cooper 
suggested you might be able to confirm.

Cheers,

-- 
Julien Grall

Re: PATCH] Change EDK II to BSD+Patent License

[Julien Grall]

Hi Lars,

On 15/03/2019 17:04, Lars Kurth wrote:
> 
> 
> On 15/03/2019, 02:35, "Julien Grall" <julien.grall@arm.com> wrote:
> 
>      Hi Lars,
>      
>      On 14/03/2019 20:04, Lars Kurth wrote:
>      >
>      >
>      > On 14/03/2019, 12:07, "Julien Grall" <julien.grall@arm.com> wrote:
>      >
>      >      (+ Lars)
>      >
>      >      On 3/14/19 10:55 AM, Laszlo Ersek wrote:
>      >      > On 03/13/19 18:54, Kinney, Michael D wrote:
>      >      > (2.2.2) Files that seem to be covered by the MIT license.
>      >      >
>      >      >            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
>      > ...
>      >      >            OvmfPkg/XenBusDxe/XenStore.h
>      >      >
>      >      >          It's OK to leave these untouched, for now. Later, we should
>      >      >          probably replace their license blocks with
>      >      >          "SPDX-License-Identifier: MIT" (as appropriate). It might make
>      >      >          sense to file a TianoCore BZ about them immediately, with a
>      >      >          BZ-dependency on BZ#1373.
>      >
>      >      I have added Lars Kurth to confirm the license.
>      >
>      > Can you give me some context? It's not clear to me what you expect me to do.
>      
>      EDK2 is converting the full copyright in each file to SDPX identifier. While the
>      copyright looks like an MIT license, it has never been confirmed. Andrew Cooper
>      suggested you might be able to confirm.
>      
> Is there a web-link to the files/repos such that I don’t have to clone the repo
> Lars

Here an example of files from Xen public headers:

https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=xen/include/public;h=0618b0134d2b9babcba71a3f0f86be5a84468b50;hb=HEAD

Cheers,

-- 
Julien Grall

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 03/15/19 18:48, Lars Kurth wrote:
> 
> 
> On 15/03/2019, 10:18, "Julien Grall" <julien.grall@arm.com> wrote:
> 
>     >      
>     >      EDK2 is converting the full copyright in each file to SDPX identifier. While the
>     >      copyright looks like an MIT license, it has never been confirmed. Andrew Cooper
>     >      suggested you might be able to confirm.
>     >      
>     > Is there a web-link to the files/repos such that I don’t have to clone the repo
>     > Lars
>     
>     Here an example of files from Xen public headers:
>     
>     https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=xen/include/public;h=0618b0134d2b9babcba71a3f0f86be5a84468b50;hb=HEAD
>     
> OK, this makes this easy then. Because in all likelihood, the files were copied from xen/include/public and then the COPYING file https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/COPYING applies, which states that everything in this directory is MIT, unless stated otherwise in the file. 
> 
> So as long as someone confirms that the files in OvmfPkg/Include came from xen/include/public, this is a clear case of a MIT license
> If they are files from other directories in Xen, check the COPYING file in the original directory (or if there is none in the parent directory) and check the COPYING file
> 
> I am not so clear about where the files in XenBusDxe came from, but the same principle applies. 
> 
> If someone groups these files by "original directory in Xen" to File ... I am happy to do a final sanity check and sign it off and/or deal with any unclear cases

Replacing MIT license blocks with SPDX identifiers is something we
should do later -- I think it's out of scope for Mike's current patch
series, it's just something I noticed and pointed out for the future,
while I was verifying the "license block -> SPDX ID" replacements for
2-BSDL (i.e., *not* MIT).

Mike mentioned that he was going to file a number of TianoCore BZs as a
result of the discussion in this thread. Mike, can you please file one
for the MIT->SPDX "refactoring" (under OvmfPkg) as well? If not, I can
file it myself later, I just wouldn't like us to end up with duplicates.

Once we have that separate BZ, we can discuss it in isolation.

Thanks
Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Kinney, Michael D]

Hi Laszlo,

I have entered the following BZ for SPDX identifiers for 
MIT licensed content in OvmfPkg. 

https://bugzilla.tianocore.org/show_bug.cgi?id=1654

Best regards,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, March 20, 2019 5:10 AM
> To: Lars Kurth <lars.kurth@citrix.com>; Julien Grall
> <julien.grall@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Anthony Perard
> <anthony.perard@citrix.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Stefan Berger
> <stefanb@linux.ibm.com>
> Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> License
> 
> On 03/15/19 18:48, Lars Kurth wrote:
> >
> >
> > On 15/03/2019, 10:18, "Julien Grall"
> <julien.grall@arm.com> wrote:
> >
> >     >
> >     >      EDK2 is converting the full copyright in
> each file to SDPX identifier. While the
> >     >      copyright looks like an MIT license, it has
> never been confirmed. Andrew Cooper
> >     >      suggested you might be able to confirm.
> >     >
> >     > Is there a web-link to the files/repos such that
> I don’t have to clone the repo
> >     > Lars
> >
> >     Here an example of files from Xen public headers:
> >
> >
> https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=xen/in
> clude/public;h=0618b0134d2b9babcba71a3f0f86be5a84468b50;h
> b=HEAD
> >
> > OK, this makes this easy then. Because in all
> likelihood, the files were copied from xen/include/public
> and then the COPYING file
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/in
> clude/public/COPYING applies, which states that
> everything in this directory is MIT, unless stated
> otherwise in the file.
> >
> > So as long as someone confirms that the files in
> OvmfPkg/Include came from xen/include/public, this is a
> clear case of a MIT license
> > If they are files from other directories in Xen, check
> the COPYING file in the original directory (or if there
> is none in the parent directory) and check the COPYING
> file
> >
> > I am not so clear about where the files in XenBusDxe
> came from, but the same principle applies.
> >
> > If someone groups these files by "original directory in
> Xen" to File ... I am happy to do a final sanity check
> and sign it off and/or deal with any unclear cases
> 
> Replacing MIT license blocks with SPDX identifiers is
> something we
> should do later -- I think it's out of scope for Mike's
> current patch
> series, it's just something I noticed and pointed out for
> the future,
> while I was verifying the "license block -> SPDX ID"
> replacements for
> 2-BSDL (i.e., *not* MIT).
> 
> Mike mentioned that he was going to file a number of
> TianoCore BZs as a
> result of the discussion in this thread. Mike, can you
> please file one
> for the MIT->SPDX "refactoring" (under OvmfPkg) as well?
> If not, I can
> file it myself later, I just wouldn't like us to end up
> with duplicates.
> 
> Once we have that separate BZ, we can discuss it in
> isolation.
> 
> Thanks
> Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 03/23/19 01:44, Kinney, Michael D wrote:
> Hi Laszlo,
> 
> I have entered the following BZ for SPDX identifiers for 
> MIT licensed content in OvmfPkg. 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1654

Thank you!
Laszlo

>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Wednesday, March 20, 2019 5:10 AM
>> To: Lars Kurth <lars.kurth@citrix.com>; Julien Grall
>> <julien.grall@arm.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Cc: edk2-devel@lists.01.org; Ard Biesheuvel
>> <ard.biesheuvel@linaro.org>; Justen, Jordan L
>> <jordan.l.justen@intel.com>; Anthony Perard
>> <anthony.perard@citrix.com>; Marc-André Lureau
>> <marcandre.lureau@redhat.com>; Stefan Berger
>> <stefanb@linux.ibm.com>
>> Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
>> License
>>
>> On 03/15/19 18:48, Lars Kurth wrote:
>>>
>>>
>>> On 15/03/2019, 10:18, "Julien Grall"
>> <julien.grall@arm.com> wrote:
>>>
>>>     >
>>>     >      EDK2 is converting the full copyright in
>> each file to SDPX identifier. While the
>>>     >      copyright looks like an MIT license, it has
>> never been confirmed. Andrew Cooper
>>>     >      suggested you might be able to confirm.
>>>     >
>>>     > Is there a web-link to the files/repos such that
>> I don’t have to clone the repo
>>>     > Lars
>>>
>>>     Here an example of files from Xen public headers:
>>>
>>>
>> https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=xen/in
>> clude/public;h=0618b0134d2b9babcba71a3f0f86be5a84468b50;h
>> b=HEAD
>>>
>>> OK, this makes this easy then. Because in all
>> likelihood, the files were copied from xen/include/public
>> and then the COPYING file
>> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/in
>> clude/public/COPYING applies, which states that
>> everything in this directory is MIT, unless stated
>> otherwise in the file.
>>>
>>> So as long as someone confirms that the files in
>> OvmfPkg/Include came from xen/include/public, this is a
>> clear case of a MIT license
>>> If they are files from other directories in Xen, check
>> the COPYING file in the original directory (or if there
>> is none in the parent directory) and check the COPYING
>> file
>>>
>>> I am not so clear about where the files in XenBusDxe
>> came from, but the same principle applies.
>>>
>>> If someone groups these files by "original directory in
>> Xen" to File ... I am happy to do a final sanity check
>> and sign it off and/or deal with any unclear cases
>>
>> Replacing MIT license blocks with SPDX identifiers is
>> something we
>> should do later -- I think it's out of scope for Mike's
>> current patch
>> series, it's just something I noticed and pointed out for
>> the future,
>> while I was verifying the "license block -> SPDX ID"
>> replacements for
>> 2-BSDL (i.e., *not* MIT).
>>
>> Mike mentioned that he was going to file a number of
>> TianoCore BZs as a
>> result of the discussion in this thread. Mike, can you
>> please file one
>> for the MIT->SPDX "refactoring" (under OvmfPkg) as well?
>> If not, I can
>> file it myself later, I just wouldn't like us to end up
>> with duplicates.
>>
>> Once we have that separate BZ, we can discuss it in
>> isolation.
>>
>> Thanks
>> Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 03/20/19 14:03, Lars Kurth wrote:
> 
> 
> On 15/03/2019, 17:48, "Lars Kurth" <lars.kurth@citrix.com> wrote:
> 
>     
>     
>     On 15/03/2019, 10:18, "Julien Grall" <julien.grall@arm.com> wrote:
>     
>         >      
>         >      EDK2 is converting the full copyright in each file to SDPX identifier. While the
>         >      copyright looks like an MIT license, it has never been confirmed. Andrew Cooper
>         >      suggested you might be able to confirm.
>         >      
>         > Is there a web-link to the files/repos such that I don’t have to clone the repo
>         > Lars
>         
>         Here an example of files from Xen public headers:
>         
>         https://xenbits.xen.org/gitweb/?p=xen.git;a=tree;f=xen/include/public;h=0618b0134d2b9babcba71a3f0f86be5a84468b50;hb=HEAD
>         
>     OK, this makes this easy then. Because in all likelihood, the files were copied from xen/include/public and then the COPYING file https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/COPYING applies, which states that everything in this directory is MIT, unless stated otherwise in the file. 
>     
>     So as long as someone confirms that the files in OvmfPkg/Include came from xen/include/public, this is a clear case of a MIT license
>     If they are files from other directories in Xen, check the COPYING file in the original directory (or if there is none in the parent directory) and check the COPYING file
>     
>     I am not so clear about where the files in XenBusDxe came from, but the same principle applies. 
>     
>     If someone groups these files by "original directory in Xen" to File ... I am happy to do a final sanity check and sign it off and/or deal with any unclear cases
>     
> Nobody stepped up, sigh.

Sorry, no capacity. I suggested to handle this in a separate TianoCore
BZ, with much more focused context. I asked Mike to file that BZ (he had
offered earlier, if I understood correctly), or else to notify me to
file it.

> I am also VERY confused by this thread. 

Not surprising -- this is a side topic in the thread we're in.

> Is the issue that you don’t trust that the license specified in the files are correct?

No -- the question is whether the license included in the files
mentioned is indeed the MIT license, suitable for a replacement with the
appropriate SPDX license ID.

> 
>     > (2.2.2) Files that seem to be covered by the MIT license.
>     > 
>     >            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
> 
> I can't identify where in the Xen tree this file came from. There is no corresponding xen.h file in the Xen tree at [xen.git] / xen / include / public / arch-arm /
> @Julien, @Anthony: can you clarify

This file was first added to edk2 in b94c3ac93d57 ("Ovmf/Xen: implement
XenHypercallLib for ARM", 2015-02-28).

https://github.com/tianocore/edk2/commit/b94c3ac93d57

And from the Xen project (I think), it was Reviewed-by: Stefano
Stabellini <stefano.stabellini@eu.citrix.com>. (I vaguely recall that
Stefano's emai has changed since.)

> 
>     >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/console.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/memory.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h
>     >            OvmfPkg/Include/IndustryStandard/Xen/xen.h
> 
> These all appear to originate from [xen.git] / xen / include / public
> In the Xen tree these all have explicit MIT licenses, which implies that the license headers are indeed correct.

Thanks -- so can we replace the license blocks with

  SPDX-License-Identifier: MIT

? (See e.g. <https://spdx.org/ids-how>.)

But, again, this should be discussed in that separate BZ then.

> 
>     >            OvmfPkg/XenBusDxe/XenBus.c
>     >            OvmfPkg/XenBusDxe/XenStore.c
>     >            OvmfPkg/XenBusDxe/XenStore.h    
> 
> I do not know where these files come from. The files do not appear to come from a Xen project repo. 

See commit a9090a94bb4a ("OvmfPkg/XenBusDxe: Add XenStore client
implementation", 2014-10-29), by Anthony.

https://github.com/tianocore/edk2/commit/a9090a94bb4a

The commit message states,

> Origin: FreeBSD 10.0
> License: This patch adds several files under the MIT licence.

> So, unless you trust that the license in the headers are correct, the right thing would be to identify the source and check whether the license text has been imported unmodified

We do trust that the license blocks, as they exist, are correct. Where
we need help & support is the mapping/replacement of those verbose
license blocks to/with SPDX-License-Identifier tags.

> Maybe Anthony can do this, if this indeed is needed

Thanks,
Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Julien Grall]

Hi,

On 20/03/2019 18:25, Laszlo Ersek wrote:
> On 03/20/19 14:03, Lars Kurth wrote:
>> On 15/03/2019, 17:48, "Lars Kurth" <lars.kurth@citrix.com> wrote:
>>      On 15/03/2019, 10:18, "Julien Grall" <julien.grall@arm.com> wrote:
>> Is the issue that you don’t trust that the license specified in the files are correct?
> 
> No -- the question is whether the license included in the files
> mentioned is indeed the MIT license, suitable for a replacement with the
> appropriate SPDX license ID.
> 
>>
>>      > (2.2.2) Files that seem to be covered by the MIT license.
>>      >
>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
>>
>> I can't identify where in the Xen tree this file came from. There is no corresponding xen.h file in the Xen tree at [xen.git] / xen / include / public / arch-arm /
>> @Julien, @Anthony: can you clarify
> 
> This file was first added to edk2 in b94c3ac93d57 ("Ovmf/Xen: implement
> XenHypercallLib for ARM", 2015-02-28).

It is a copy of public/arch-arm.h. Somehow all the other projects created the 
file under arch-arm/xen.h.

> 
> https://github.com/tianocore/edk2/commit/b94c3ac93d57
> 
> And from the Xen project (I think), it was Reviewed-by: Stefano
> Stabellini <stefano.stabellini@eu.citrix.com>. (I vaguely recall that
> Stefano's emai has changed since.)

That's correct. He is working for Xilinx now.

> 
>>
>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/console.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/memory.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h
>>      >            OvmfPkg/Include/IndustryStandard/Xen/xen.h
>>
>> These all appear to originate from [xen.git] / xen / include / public
>> In the Xen tree these all have explicit MIT licenses, which implies that the license headers are indeed correct.
> 
> Thanks -- so can we replace the license blocks with
> 
>    SPDX-License-Identifier: MIT
> 
> ? (See e.g. <https://spdx.org/ids-how>.)

I spoke with Lars today, this identifier would be suitable for the headers.

Cheers,

-- 
Julien Grall

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 03/20/19 19:42, Julien Grall wrote:
> Hi,
> 
> On 20/03/2019 18:25, Laszlo Ersek wrote:
>> On 03/20/19 14:03, Lars Kurth wrote:
>>> On 15/03/2019, 17:48, "Lars Kurth" <lars.kurth@citrix.com> wrote:
>>>      On 15/03/2019, 10:18, "Julien Grall" <julien.grall@arm.com> wrote:
>>> Is the issue that you don’t trust that the license specified in the
>>> files are correct?
>>
>> No -- the question is whether the license included in the files
>> mentioned is indeed the MIT license, suitable for a replacement with the
>> appropriate SPDX license ID.
>>
>>>
>>>      > (2.2.2) Files that seem to be covered by the MIT license.
>>>      >
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
>>>
>>> I can't identify where in the Xen tree this file came from. There is
>>> no corresponding xen.h file in the Xen tree at [xen.git] / xen /
>>> include / public / arch-arm /
>>> @Julien, @Anthony: can you clarify
>>
>> This file was first added to edk2 in b94c3ac93d57 ("Ovmf/Xen: implement
>> XenHypercallLib for ARM", 2015-02-28).
> 
> It is a copy of public/arch-arm.h. Somehow all the other projects
> created the file under arch-arm/xen.h.
> 
>>
>> https://github.com/tianocore/edk2/commit/b94c3ac93d57
>>
>> And from the Xen project (I think), it was Reviewed-by: Stefano
>> Stabellini <stefano.stabellini@eu.citrix.com>. (I vaguely recall that
>> Stefano's emai has changed since.)
> 
> That's correct. He is working for Xilinx now.
> 
>>
>>>
>>>      >           
>>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h
>>>      >           
>>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/console.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/memory.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h
>>>      >            OvmfPkg/Include/IndustryStandard/Xen/xen.h
>>>
>>> These all appear to originate from [xen.git] / xen / include / public
>>> In the Xen tree these all have explicit MIT licenses, which implies
>>> that the license headers are indeed correct.
>>
>> Thanks -- so can we replace the license blocks with
>>
>>    SPDX-License-Identifier: MIT
>>
>> ? (See e.g. <https://spdx.org/ids-how>.)
> 
> I spoke with Lars today, this identifier would be suitable for the headers.
> 
> Cheers,
> 

Thanks!
Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 03/21/19 13:04, Lars Kurth wrote:
> 
> 
> On 20/03/2019, 18:25, "Laszlo Ersek" <lersek@redhat.com> wrote:
> 
>     But, again, this should be discussed in that separate BZ then.
>     
>     >     >            OvmfPkg/XenBusDxe/XenBus.c
> 
> This file is licensed under the BSD license, aka https://opensource.org/licenses/bsd-license.php
> 
>     >     >            OvmfPkg/XenBusDxe/XenStore.c
>     >     >            OvmfPkg/XenBusDxe/XenStore.h    
>     >I do not know where these files come from. The files do not appear to come from a Xen project repo. 
>     
>     See commit a9090a94bb4a ("OvmfPkg/XenBusDxe: Add XenStore client
>     implementation", 2014-10-29), by Anthony.
>     
>     https://github.com/tianocore/edk2/commit/a9090a94bb4a
>     
>     The commit message states,
>     
>     >Origin: FreeBSD 10.0
>     >License: This patch adds several files under the MIT licence.
>     
>     >So, unless you trust that the license in the headers are correct, the right thing would be to identify the source and check whether the license text has been imported unmodified
>     
>     We do trust that the license blocks, as they exist, are correct. Where
>     we need help & support is the mapping/replacement of those verbose
>     license blocks to/with SPDX-License-Identifier tags.
> 
> As I now understand what is needed, I had a look at the XenStore.* licenses. They are NOT a standard MIT license
> 
> The sources say:
> "Permission is hereby granted, free of charge, to any person obtaining a copy of this source file (the "Software")"
> The MIT license says
> "Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software")"
> 
> I would argue that replacing "source file" with "software and associated documentation files" is probably OK, but I am not an expert. I am pretty sure this type of issue has come up before when migrating to SPDX. It might be worthwhile reaching out to someone from SPDX.
> 
> Hope this helped

Thank you! We'll revisit this issue (and thread, I assume) later on.

Laszlo

Re: PATCH] Change EDK II to BSD+Patent License

[Kinney, Michael D]

Laszlo,

Thanks for the feedback.  I will entered a few BZs based on this
feedback and will provide a V2 version of the content.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Thursday, March 14, 2019 3:56 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; edk2-
> devel@lists.01.org; Julien Grall
> <julien.grall@arm.com>; Anthony Perard
> <anthony.perard@citrix.com>
> Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> License
> 
> Hi Mike,
> 
> On 03/13/19 18:54, Kinney, Michael D wrote:
> > Hello,
> >
> > BZ:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> March/037669.html
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> March/037500.html
> >
> > I have posted the patch series for review on the
> following branch
> > using edk2-stable201903 as the base for the patch
> series.
> >
> >
> https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> tLicense
> >
> > The commits in patch series can be viewed here:
> >
> >
> https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> tentLicense
> >
> > The patch series has one patch per package along with
> a few patches
> > to update the license information in the root of the
> edk2 repository
> > as described in the RFC V2.
> >
> > Due to the size of the patch series, I prefer to not
> send the
> > patch emails.  Instead, please perform code reviews
> using content
> > from the branch.
> >
> > All EDK II package maintainers and package reviewers
> should provide
> > review feedback for their packages.  The critical
> part of the review
> > is:
> > 1) Any changes that cause build breaks or logic
> changes.  These code
> >    changes are intended to only modify license
> contents in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but
> should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent,
> but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the
> patch the feedback
> > applies using the patch summary listed below.  The
> goal is to complete
> > all reviews to support the commit of these patches on
> April 9, 2019.
> 
> [...]
> 
> 
> > 837a3425bf OvmfPkg: Replace BSD License with
> BSD+Patent License
> 
> (1) For the commit message, I have the following
> suggestions:
> 
> (1.1) please remove the "Cc:" tags, because you aren't
> actually posting
>       the patches to the mailing list, so the people
> listed in Cc have
>       no chance to receive the patch by email ("carbon-
> copied")
> 
> (1.2) please remove the "Branch for review" reference
> as well -- while I
>       certainly prefer such branch references ot remain
> valid forever,
>       in practice their longevity is quite dubious in
> comparison to e.g.
>       mailing list archive links.
> 
> (2) Regarding the patch body:
> 
> (2.1) I reviewed each of the 348 hunks in the patch
> file. They are
>       correct, with one exception:
> 
> (2.1.1) "create-release.py" doesn't only contain a
> copyright block
>         (which is correctly patches), but it also
> *generates* a
>         copyright block. (Search it manually for
>         "http://opensource.org/licenses/bsd-
> license.php".) In my
>         opinion, we should simply retire this python
> script, *before*
>         the conversion is started -- I don't remember
> using it in recent
>         years, plus now we have the stable tags, for
> open source
>         community-oriented releases.
> 
> (2.2) 30 files under OvmfPkg remain without "SPDX-
> License-Identifier:
>       BSD-2-Clause-Patent" after the patch is applied.
> These can be
>       categorized as follows:
> 
> (2.2.1) Files without any copyright notices (very small
> files,
>         README-like files, generated files):
> 
>           OvmfPkg/Csm/Csm16/ReadMe.txt
>           OvmfPkg/Include/IndustryStandard/Xen/README
>           OvmfPkg/README
> 
> 
> OvmfPkg/Library/XenHypercallLib/Ia32/hypercall.nasm
> 
> OvmfPkg/Library/XenHypercallLib/X64/hypercall.nasm
>           OvmfPkg/XenBusDxe/Helpers.c
> 
>           OvmfPkg/QemuVideoDxe/VbeShim.h
> 
>         It's fine to leave these untouched.
> 
> (2.2.2) Files that seem to be covered by the MIT
> license.
> 
>           OvmfPkg/Include/IndustryStandard/Xen/arch-
> arm/xen.h
>           OvmfPkg/Include/IndustryStandard/Xen/arch-
> x86/xen-x86_32.h
>           OvmfPkg/Include/IndustryStandard/Xen/arch-
> x86/xen-x86_64.h
>           OvmfPkg/Include/IndustryStandard/Xen/arch-
> x86/xen.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/event_channel.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/hvm/hvm_op.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/console.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/ring.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/xenbus.h
> 
> OvmfPkg/Include/IndustryStandard/Xen/io/xs_wire.h
>           OvmfPkg/Include/IndustryStandard/Xen/memory.h
>           OvmfPkg/Include/IndustryStandard/Xen/xen-
> compat.h
>           OvmfPkg/Include/IndustryStandard/Xen/xen.h
>           OvmfPkg/XenBusDxe/XenBus.c
>           OvmfPkg/XenBusDxe/XenStore.c
>           OvmfPkg/XenBusDxe/XenStore.h
> 
>         It's OK to leave these untouched, for now.
> Later, we should
>         probably replace their license blocks with
>         "SPDX-License-Identifier: MIT" (as
> appropriate). It might make
>         sense to file a TianoCore BZ about them
> immediately, with a
>         BZ-dependency on BZ#1373.
> 
> (2.2.3) The following file is untouched, but it should
> be updated. It
>         requires special (not scripted) treatment.
> 
>           OvmfPkg/License.txt
> 
> (2.2.4) The following files seem to be under 2-BSDL,
> but without a link
>         to <http://opensource.org/licenses/bsd-
> license.php> -- which is
>         why I believe the script must have missed them.
> They should be
>         converted manually.
> 
>           OvmfPkg/XenBusDxe/GrantTable.c
>           OvmfPkg/XenPvBlkDxe/BlockFront.c
> 
> Important: when you update the series, please do not
> force-push your
> current "Bug_1373_BsdPatentLicense" branch! Instead,
> please push
> "Bug_1373_BsdPatentLicense_v2".
> 
> [...]
> 
> 
> > 908d82c3fd ArmVirtPkg: Replace BSD License with
> BSD+Patent License
> 
> (3) The same commit message observations apply as under
> (1).
> 
> With those commit message updates, the ArmVirtPkg patch
> (currently
> commit 908d82c3fd in your branch) will be eligible for
> my R-b. The
> conversions done by the patch appear correct, no links
> to
> <http://opensource.org/licenses/bsd-license.php>
> remain, and after the
> patch, no file remains without "SPDX-License-
> Identifier:
> BSD-2-Clause-Patent".
> 
> 
> I haven't done any build testing, partly because the
> patches look safe,
> and partly because any future updates (to OvmfPkg,
> MdePkg, MdeModulePkg
> etc) would invalidate such testing anyway. We should do
> build testing
> once all of the patches in the series have been
> approved. (More
> precisely, a DSC can be test-built if its own package,
> and all the
> packages it depends upon, have been reviewed.)
> 
> Thank you!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: PATCH] Change EDK II to BSD+Patent License

[Jordan Justen]

On 2019-03-13 10:54:22, Kinney, Michael D wrote:
>  
> 84141eacac edk2: Remove Contributions.txt and update Readme.md

I guess this removes the requirement for the 'Contributed-under' tag
in commit messages?

But, what about Signed-off-by? Is it desirable to remove that
requirement?

Relatedly, some open source projects have standardized on tying the
Signed-off-by to this text:

https://developercertificate.org/

So, the contributor doesn't have to agree to give the project the
contribution under the Contributed-under terms, but they still
indicate that they believe that the project can use the code under the
project's indicated license.

There is also other information in Contributions.txt that appears to
have been deleted, rather than moved. I guess it is mostly duplicated
on the wiki. That doesn't mean it's not a good idea to duplicate it in
the source tree, or at least provide a web-link. It seems like the
first place devs might look for such information is either the readme,
or Contributions.txt.

Regarding the wiki, I guess it has to be updated after this change is
made. It might be good to add that to the bug so it can't be closed
until that is fixed.

How about updating BaseTools/Scripts/PatchCheck.py?

-Jordan

Re: PATCH] Change EDK II to BSD+Patent License

[Kinney, Michael D]

Hi Jordan,

No proposed changes to the Signed-off-by tags.  If you have 
a proposal, please provide an RFC or bring to the monthly
EDK II community meeting.

This series is focused on the license change, the use of SPDX
identifiers, and removing the Contributed-under tag from
commit messages.

I will update the V2 version of the patch series in to make
sure the content from Contributions.txt that is not part of
the TianoCore Contribution Agreement is added to Readme.md.

The RFC mentioned the need to update documentation.  I will
send that out as a separate Wiki patch series for review.

Best regards,

Mike

> -----Original Message-----
> From: Justen, Jordan L
> Sent: Thursday, March 14, 2019 11:04 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org
> Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> License
> 
> On 2019-03-13 10:54:22, Kinney, Michael D wrote:
> >
> > 84141eacac edk2: Remove Contributions.txt and update
> Readme.md
> 
> I guess this removes the requirement for the
> 'Contributed-under' tag
> in commit messages?
> 
> But, what about Signed-off-by? Is it desirable to
> remove that
> requirement?
> 
> Relatedly, some open source projects have standardized
> on tying the
> Signed-off-by to this text:
> 
> https://developercertificate.org/
> 
> So, the contributor doesn't have to agree to give the
> project the
> contribution under the Contributed-under terms, but
> they still
> indicate that they believe that the project can use the
> code under the
> project's indicated license.
> 
> There is also other information in Contributions.txt
> that appears to
> have been deleted, rather than moved. I guess it is
> mostly duplicated
> on the wiki. That doesn't mean it's not a good idea to
> duplicate it in
> the source tree, or at least provide a web-link. It
> seems like the
> first place devs might look for such information is
> either the readme,
> or Contributions.txt.
> 
> Regarding the wiki, I guess it has to be updated after
> this change is
> made. It might be good to add that to the bug so it
> can't be closed
> until that is fixed.
> 
> How about updating BaseTools/Scripts/PatchCheck.py?
> 
> -Jordan

Re: PATCH] Change EDK II to BSD+Patent License

[Jordan Justen]

On 2019-03-18 11:25:54, Kinney, Michael D wrote:
> Hi Jordan,
> 
> No proposed changes to the Signed-off-by tags.

I think it's good to continue with the Signed-off-by tags. One slight
concerns I have is what Signed-off-by becomes a little vague with your
proposed change.

Previously it meant that the contribution aligned with the Tianocore
Contribution Agreement. Now, I think it *implicitly* means what the
"Developer Certificate of Origin" https://developercertificate.org/
says, but it's not made explicit.

I guess it might be fine to proceed with the implicit meaning for
Signed-off-by, and EDK II wouldn't be the first project to be in that
situation.

> If you have 
> a proposal, please provide an RFC or bring to the monthly
> EDK II community meeting.
> 
> This series is focused on the license change, the use of SPDX
> identifiers, and removing the Contributed-under tag from
> commit messages.

One possible advantage for considering this now is that I'm guessing
the change is being reviewed by various legal departments, and it
might be easier to handle this change at the same time.

One possible disadvantage is that it might make this change more
difficult to finish. :)

-Jordan

Re: PATCH] Change EDK II to BSD+Patent License

[Leif Lindholm]

Hi Mike,

I see where Jordan is coming from here.

It isn't just about losing the comment in Contriutions.txt - there are
bits in the actual TianoCore Contribution Agreement that cover the
same things as https://developercertificate.org/ (that are not
explicitly called out elsewhere in the existing Contributions.txt).

Like Jordan says, we wouldn't be the first project that use
Signed-off-by without specifying exactly what it means, but I think
we're one of the ones that actually care quite a bit.

I could live with us not resolving this at the same time as the
license change, but I would prefer if we did...

Best Regards,

Leif

On Mon, Mar 18, 2019 at 06:25:54PM +0000, Kinney, Michael D wrote:
> Hi Jordan,
> 
> No proposed changes to the Signed-off-by tags.  If you have 
> a proposal, please provide an RFC or bring to the monthly
> EDK II community meeting.
> 
> This series is focused on the license change, the use of SPDX
> identifiers, and removing the Contributed-under tag from
> commit messages.
> 
> I will update the V2 version of the patch series in to make
> sure the content from Contributions.txt that is not part of
> the TianoCore Contribution Agreement is added to Readme.md.
> 
> The RFC mentioned the need to update documentation.  I will
> send that out as a separate Wiki patch series for review.
> 
> Best regards,
> 
> Mike
> 
> > -----Original Message-----
> > From: Justen, Jordan L
> > Sent: Thursday, March 14, 2019 11:04 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > edk2-devel@lists.01.org
> > Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> > License
> > 
> > On 2019-03-13 10:54:22, Kinney, Michael D wrote:
> > >
> > > 84141eacac edk2: Remove Contributions.txt and update
> > Readme.md
> > 
> > I guess this removes the requirement for the
> > 'Contributed-under' tag
> > in commit messages?
> > 
> > But, what about Signed-off-by? Is it desirable to
> > remove that
> > requirement?
> > 
> > Relatedly, some open source projects have standardized
> > on tying the
> > Signed-off-by to this text:
> > 
> > https://developercertificate.org/
> > 
> > So, the contributor doesn't have to agree to give the
> > project the
> > contribution under the Contributed-under terms, but
> > they still
> > indicate that they believe that the project can use the
> > code under the
> > project's indicated license.
> > 
> > There is also other information in Contributions.txt
> > that appears to
> > have been deleted, rather than moved. I guess it is
> > mostly duplicated
> > on the wiki. That doesn't mean it's not a good idea to
> > duplicate it in
> > the source tree, or at least provide a web-link. It
> > seems like the
> > first place devs might look for such information is
> > either the readme,
> > or Contributions.txt.
> > 
> > Regarding the wiki, I guess it has to be updated after
> > this change is
> > made. It might be good to add that to the bug so it
> > can't be closed
> > until that is fixed.
> > 
> > How about updating BaseTools/Scripts/PatchCheck.py?
> > 
> > -Jordan
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: PATCH] Change EDK II to BSD+Patent License

[Kinney, Michael D]

Leif and Jordan,

Would you mind putting together a specific proposal
and perhaps some links to other projects that use
the same approach?

I am happy to update the RFC to V3 to address this 
topic if we can close on it quickly.

Thanks,

Mike


> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, March 19, 2019 10:59 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; edk2-
> devel@lists.01.org
> Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> License
> 
> Hi Mike,
> 
> I see where Jordan is coming from here.
> 
> It isn't just about losing the comment in
> Contriutions.txt - there are
> bits in the actual TianoCore Contribution Agreement that
> cover the
> same things as https://developercertificate.org/ (that
> are not
> explicitly called out elsewhere in the existing
> Contributions.txt).
> 
> Like Jordan says, we wouldn't be the first project that
> use
> Signed-off-by without specifying exactly what it means,
> but I think
> we're one of the ones that actually care quite a bit.
> 
> I could live with us not resolving this at the same time
> as the
> license change, but I would prefer if we did...
> 
> Best Regards,
> 
> Leif
> 
> On Mon, Mar 18, 2019 at 06:25:54PM +0000, Kinney, Michael
> D wrote:
> > Hi Jordan,
> >
> > No proposed changes to the Signed-off-by tags.  If you
> have
> > a proposal, please provide an RFC or bring to the
> monthly
> > EDK II community meeting.
> >
> > This series is focused on the license change, the use
> of SPDX
> > identifiers, and removing the Contributed-under tag
> from
> > commit messages.
> >
> > I will update the V2 version of the patch series in to
> make
> > sure the content from Contributions.txt that is not
> part of
> > the TianoCore Contribution Agreement is added to
> Readme.md.
> >
> > The RFC mentioned the need to update documentation.  I
> will
> > send that out as a separate Wiki patch series for
> review.
> >
> > Best regards,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Justen, Jordan L
> > > Sent: Thursday, March 14, 2019 11:04 AM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > edk2-devel@lists.01.org
> > > Subject: Re: [edk2] PATCH] Change EDK II to
> BSD+Patent
> > > License
> > >
> > > On 2019-03-13 10:54:22, Kinney, Michael D wrote:
> > > >
> > > > 84141eacac edk2: Remove Contributions.txt and
> update
> > > Readme.md
> > >
> > > I guess this removes the requirement for the
> > > 'Contributed-under' tag
> > > in commit messages?
> > >
> > > But, what about Signed-off-by? Is it desirable to
> > > remove that
> > > requirement?
> > >
> > > Relatedly, some open source projects have
> standardized
> > > on tying the
> > > Signed-off-by to this text:
> > >
> > > https://developercertificate.org/
> > >
> > > So, the contributor doesn't have to agree to give the
> > > project the
> > > contribution under the Contributed-under terms, but
> > > they still
> > > indicate that they believe that the project can use
> the
> > > code under the
> > > project's indicated license.
> > >
> > > There is also other information in Contributions.txt
> > > that appears to
> > > have been deleted, rather than moved. I guess it is
> > > mostly duplicated
> > > on the wiki. That doesn't mean it's not a good idea
> to
> > > duplicate it in
> > > the source tree, or at least provide a web-link. It
> > > seems like the
> > > first place devs might look for such information is
> > > either the readme,
> > > or Contributions.txt.
> > >
> > > Regarding the wiki, I guess it has to be updated
> after
> > > this change is
> > > made. It might be good to add that to the bug so it
> > > can't be closed
> > > until that is fixed.
> > >
> > > How about updating BaseTools/Scripts/PatchCheck.py?
> > >
> > > -Jordan
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

Re: PATCH] Change EDK II to BSD+Patent License

[Jordan Justen]

On 2019-03-19 12:09:41, Kinney, Michael D wrote:
> Leif and Jordan,
> 
> Would you mind putting together a specific proposal

I would propose adding the exact text from that site into a
DeveloperCertificate.txt in the root of the tree. Then reference when
documenting how to contribute a patch, near the Signed-off-by part.

Optionally, the https://developercertificate.org/ site could be
referenced to show where the text came from.

> and perhaps some links to other projects that use
> the same approach?

* linux kernel [1] (where DCO started)

* eclipse [2]

-Jordan

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.1-rc1#n431

[2]: https://www.eclipse.org/legal/DCO.php

Re: PATCH] Change EDK II to BSD+Patent License

[Leif Lindholm]

A starting proposal for my end would be:

---
In order to keep track of who did what, all patches contributed need
to include a statement that to the best of the contributor's
knowledge they have the right to contribute it under the specified
license.

The test for this is as specified in the [Developer's Certificate of
Origin (DCO) 1.1](https://developercertificate.org/). The contributor
certifies compliance by adding a line saying

  Signed-off-by: Developer Name <developer@example.org>

where "Developer Name" is the contributor's real name, and the email
address is one the developer is reachable through at the time of
contributing.
---

We could also do what Linux does and include the DCO v1.1 verbatim in
the Readme.md instead of using the link.

Best Regards,

Leif

On Tue, Mar 19, 2019 at 07:09:41PM +0000, Kinney, Michael D wrote:
> Leif and Jordan,
> 
> Would you mind putting together a specific proposal
> and perhaps some links to other projects that use
> the same approach?
> 
> I am happy to update the RFC to V3 to address this 
> topic if we can close on it quickly.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Tuesday, March 19, 2019 10:59 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Justen, Jordan L <jordan.l.justen@intel.com>; edk2-
> > devel@lists.01.org
> > Subject: Re: [edk2] PATCH] Change EDK II to BSD+Patent
> > License
> > 
> > Hi Mike,
> > 
> > I see where Jordan is coming from here.
> > 
> > It isn't just about losing the comment in
> > Contriutions.txt - there are
> > bits in the actual TianoCore Contribution Agreement that
> > cover the
> > same things as https://developercertificate.org/ (that
> > are not
> > explicitly called out elsewhere in the existing
> > Contributions.txt).
> > 
> > Like Jordan says, we wouldn't be the first project that
> > use
> > Signed-off-by without specifying exactly what it means,
> > but I think
> > we're one of the ones that actually care quite a bit.
> > 
> > I could live with us not resolving this at the same time
> > as the
> > license change, but I would prefer if we did...
> > 
> > Best Regards,
> > 
> > Leif
> > 
> > On Mon, Mar 18, 2019 at 06:25:54PM +0000, Kinney, Michael
> > D wrote:
> > > Hi Jordan,
> > >
> > > No proposed changes to the Signed-off-by tags.  If you
> > have
> > > a proposal, please provide an RFC or bring to the
> > monthly
> > > EDK II community meeting.
> > >
> > > This series is focused on the license change, the use
> > of SPDX
> > > identifiers, and removing the Contributed-under tag
> > from
> > > commit messages.
> > >
> > > I will update the V2 version of the patch series in to
> > make
> > > sure the content from Contributions.txt that is not
> > part of
> > > the TianoCore Contribution Agreement is added to
> > Readme.md.
> > >
> > > The RFC mentioned the need to update documentation.  I
> > will
> > > send that out as a separate Wiki patch series for
> > review.
> > >
> > > Best regards,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Justen, Jordan L
> > > > Sent: Thursday, March 14, 2019 11:04 AM
> > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > edk2-devel@lists.01.org
> > > > Subject: Re: [edk2] PATCH] Change EDK II to
> > BSD+Patent
> > > > License
> > > >
> > > > On 2019-03-13 10:54:22, Kinney, Michael D wrote:
> > > > >
> > > > > 84141eacac edk2: Remove Contributions.txt and
> > update
> > > > Readme.md
> > > >
> > > > I guess this removes the requirement for the
> > > > 'Contributed-under' tag
> > > > in commit messages?
> > > >
> > > > But, what about Signed-off-by? Is it desirable to
> > > > remove that
> > > > requirement?
> > > >
> > > > Relatedly, some open source projects have
> > standardized
> > > > on tying the
> > > > Signed-off-by to this text:
> > > >
> > > > https://developercertificate.org/
> > > >
> > > > So, the contributor doesn't have to agree to give the
> > > > project the
> > > > contribution under the Contributed-under terms, but
> > > > they still
> > > > indicate that they believe that the project can use
> > the
> > > > code under the
> > > > project's indicated license.
> > > >
> > > > There is also other information in Contributions.txt
> > > > that appears to
> > > > have been deleted, rather than moved. I guess it is
> > > > mostly duplicated
> > > > on the wiki. That doesn't mean it's not a good idea
> > to
> > > > duplicate it in
> > > > the source tree, or at least provide a web-link. It
> > > > seems like the
> > > > first place devs might look for such information is
> > > > either the readme,
> > > > or Contributions.txt.
> > > >
> > > > Regarding the wiki, I guess it has to be updated
> > after
> > > > this change is
> > > > made. It might be good to add that to the bug so it
> > > > can't be closed
> > > > until that is fixed.
> > > >
> > > > How about updating BaseTools/Scripts/PatchCheck.py?
> > > >
> > > > -Jordan
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel