Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Hi Laszlo,

I do not think content added before April 9, 2019
should use the new license type.  We need to let the
30-day review period complete and make sure all feedback
is resolved.

We will handle files added between the edk2-stable201903
and April 9, 2019 in a final patch series with an easy
way for all maintainers to see what has changed between
those two points.

Thanks,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, March 25, 2019 5:00 AM
> To: Wu, Hao A <hao.a.wu@intel.com>; edk2-
> devel@lists.01.org
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ard
> Biesheuvel <ard.biesheuvel@linaro.org>; Ni, Ray
> <ray.ni@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus
> driver
> 
> Hello Hao,
> 
> (+Mike)
> 
> my apologies that I seem unable to collect my thoughts
> in one go... So
> here's another comment:
> 
> On 03/25/19 06:28, Hao Wu wrote:
> 
> > diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf
> b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> > new file mode 100644
> > index 0000000000..5c462f1a8c
> > --- /dev/null
> > +++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> > @@ -0,0 +1,54 @@
> > +## @file
> > +#  The SioBusDxe driver is used to create child
> devices on the ISA bus and
> > +#  installs the Super I/O protocols on them.
> > +#
> > +#  Copyright (c) 2019, Intel Corporation. All rights
> reserved.<BR>
> > +#
> > +#  This program and the accompanying materials
> > +#  are licensed and made available under the terms
> and conditions of the BSD License
> > +#  which accompanies this distribution.  The full
> text of the license may be found at
> > +#  http://opensource.org/licenses/bsd-license.php
> > +#
> > +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE
> ON AN "AS IS" BASIS,
> > +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,
> EITHER EXPRESS OR IMPLIED.
> > +#
> > +##
> 
> [...]
> 
> This patch adds 7 new instances of the 2-clause BSDL (in
> expanded form)
> to the edk2 tree. In that it conflicts with Mike's work
> for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1373>.
> Can you please
> rework this patch so that the new files say
> 
>   SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> instead?
> 
> Thanks,
> Laszlo