Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg

["Michael D Kinney" <michael.d.kinney@intel.com>]

Ard,

Using edk2 and edk2-non-osi as submodules in the edk2-platforms 
repo does have some advantages.  Each branch in edk2-platforms
can decide which release/tag/sha is required from dependent repos.

This provides a platform focused view of the EDK II project.

If using a release/tag/sha for the dependent repos, the content
is effectively being used as read-only content like we do for
the OpenSSL submodule.

When using the combination of edk2-platforms/master, edk2/master,
and edk2-non-osi/master, if changes are made in submodules, then
there are some additional complexities that the developer needs
to be aware.  But this is a workflow that is required to make
sure a change in edk2/master does not break any platforms in
edk2-platforms/master.  I think easily discovering a build break
is higher priority.

Thanks,

Mike

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, April 24, 2019 6:04 AM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan
> <dandan.bi@intel.com>; edk2-devel-groups-io
> <devel@edk2.groups.io>; Julien Grall
> <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [patch 0/7] Move
> BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg
> 
> On Wed, 24 Apr 2019 at 15:02, Gao, Liming
> <liming.gao@intel.com> wrote:
> >
> > Ard:
> >   I prefer to keep them as the separate repo. One dummy
> Git repo can be introduced to submodule edk2, edk2-
> platform, edk2-non-osi, and others. User can use this git
> repo to get everything.
> >
> 
> That is not really my point.
> 
> A git submodule allows you to store *in* the dependent
> repository
> which exact commit in the core repository you depend on.
> A dummy git
> repo does not work the same way.
> 
> > > -----Original Message-----
> > > From: Ard Biesheuvel
> [mailto:ard.biesheuvel@linaro.org]
> > > Sent: Wednesday, April 24, 2019 8:48 PM
> > > To: Gao, Liming <liming.gao@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan
> <dandan.bi@intel.com>; edk2-devel-groups-io
> <devel@edk2.groups.io>; Julien Grall
> > > <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Andrew Fish
> > > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; Qian, Yi
> > > <yi.qian@intel.com>
> > > Subject: Re: [patch 0/7] Move
> BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg
> > >
> > > On Wed, 24 Apr 2019 at 14:46, Gao, Liming
> <liming.gao@intel.com> wrote:
> > > >
> > > >
> > > > So, we need to consider the combination of edk2
> master + edk2-platform master. When do the incompatible
> change in edk2 master, we
> > > need to update edk2-platform master together.
> > > >
> > >
> > > Yes, it is either that, or we separate them properly,
> by pulling core
> > > EDK2 into edk2-platforms as a git submodule. That
> way, we can update
> > > the upstream commit depended upon instead of assuming
> that we are
> > > always updated in lockstep.