[edk2][edk2-libc/master V2]Request to add new edk2-libc repository

[edk2][edk2-libc/master V2]Request to add new edk2-libc repository

[Michael D Kinney]

Hello,

New in V2
=========
* Add details to Readme.md on how the history for these
  three packages was exported from the edk2 repository
  using git filter-branch.
* Remove redundant content in edk2-libc Readme.md and
  Maintainters.txt and instead point to content in edk2
  repository.
* Mark the sections of Maintainers.txt that need further
  discussion as TBD.
* Update installation and build instructions in the 
  Readme.txt files in AppPkg and StdLib.
* Fix a warning in StdLib when building with VS2015.
========

There were no objections to the following RFC to add
a new edk2-libc repository.

    https://edk2.groups.io/g/devel/message/35211

I have entered the following Feature Request Bugzilla

    https://bugzilla.tianocore.org/show_bug.cgi?id=1734

I have posted a version of the edk2-libc repository for
review at the following location.  It includes all the
history for the three packages from the edk2 repository.

    https://github.com/mdkinney/edk2-libc/tree/master_V2

Please review this branch.  There are 3 additional commits:

* Update the Readme.md and Maintainers.txt that scopes them
  to this new edk2-libc repository.

  https://github.com/mdkinney/edk2-libc/commit/62cfdf929f15edba7f7bcbbdb01e4dc50d2c81a7

* Update Readme.txt in AppPkg and StdLib to describe how to
  install both the edk2-libc repository and the edk2
  repository and set PACKAGES_PATH to support builds.

  https://github.com/mdkinney/edk2-libc/commit/d004f93626b3bb962c24500db6ec7284db074c9a

* Fix a minor issue that removes warnings when building 
  edk2-libc packages with VS2015 toolchains.

  https://github.com/mdkinney/edk2-libc/commit/145d262e94182a6b4631e0b6df5bc5d67e209931

Best regards,

Mike

Re: [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

[Carsey, Jaben]

The 3 new commits look good.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, April 25, 2019 5:56 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Daryl McDaniel (edk2-
> lists@mc2research.org) <edk2-lists@mc2research.org>;
> leif.lindholm@linaro.org; Andrew Fish (afish@apple.com)
> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
> (lersek@redhat.com) <lersek@redhat.com>
> Subject: [edk2][edk2-libc/master V2]Request to add new edk2-libc repository
> Importance: High
> 
> Hello,
> 
> New in V2
> =========
> * Add details to Readme.md on how the history for these
>   three packages was exported from the edk2 repository
>   using git filter-branch.
> * Remove redundant content in edk2-libc Readme.md and
>   Maintainters.txt and instead point to content in edk2
>   repository.
> * Mark the sections of Maintainers.txt that need further
>   discussion as TBD.
> * Update installation and build instructions in the
>   Readme.txt files in AppPkg and StdLib.
> * Fix a warning in StdLib when building with VS2015.
> ========
> 
> There were no objections to the following RFC to add a new edk2-libc
> repository.
> 
>     https://edk2.groups.io/g/devel/message/35211
> 
> I have entered the following Feature Request Bugzilla
> 
>     https://bugzilla.tianocore.org/show_bug.cgi?id=1734
> 
> I have posted a version of the edk2-libc repository for review at the following
> location.  It includes all the history for the three packages from the edk2
> repository.
> 
>     https://github.com/mdkinney/edk2-libc/tree/master_V2
> 
> Please review this branch.  There are 3 additional commits:
> 
> * Update the Readme.md and Maintainers.txt that scopes them
>   to this new edk2-libc repository.
> 
>   https://github.com/mdkinney/edk2-
> libc/commit/62cfdf929f15edba7f7bcbbdb01e4dc50d2c81a7
> 
> * Update Readme.txt in AppPkg and StdLib to describe how to
>   install both the edk2-libc repository and the edk2
>   repository and set PACKAGES_PATH to support builds.
> 
>   https://github.com/mdkinney/edk2-
> libc/commit/d004f93626b3bb962c24500db6ec7284db074c9a
> 
> * Fix a minor issue that removes warnings when building
>   edk2-libc packages with VS2015 toolchains.
> 
>   https://github.com/mdkinney/edk2-
> libc/commit/145d262e94182a6b4631e0b6df5bc5d67e209931
> 
> Best regards,
> 
> Mike

Re: [edk2-devel] [edk2][edk2-libc/master V2]Request to add new edk2-libc repository

[Laszlo Ersek]

On 04/26/19 02:55, Michael D Kinney wrote:
> Hello,
> 
> New in V2
> =========
> * Add details to Readme.md on how the history for these
>   three packages was exported from the edk2 repository
>   using git filter-branch.
> * Remove redundant content in edk2-libc Readme.md and
>   Maintainters.txt and instead point to content in edk2
>   repository.
> * Mark the sections of Maintainers.txt that need further
>   discussion as TBD.
> * Update installation and build instructions in the 
>   Readme.txt files in AppPkg and StdLib.
> * Fix a warning in StdLib when building with VS2015.
> ========
> 
> There were no objections to the following RFC to add
> a new edk2-libc repository.
> 
>     https://edk2.groups.io/g/devel/message/35211
> 
> I have entered the following Feature Request Bugzilla
> 
>     https://bugzilla.tianocore.org/show_bug.cgi?id=1734
> 
> I have posted a version of the edk2-libc repository for
> review at the following location.  It includes all the
> history for the three packages from the edk2 repository.
> 
>     https://github.com/mdkinney/edk2-libc/tree/master_V2
> 
> Please review this branch.  There are 3 additional commits:
> 
> * Update the Readme.md and Maintainers.txt that scopes them
>   to this new edk2-libc repository.
> 
>   https://github.com/mdkinney/edk2-libc/commit/62cfdf929f15edba7f7bcbbdb01e4dc50d2c81a7

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

> * Update Readme.txt in AppPkg and StdLib to describe how to
>   install both the edk2-libc repository and the edk2
>   repository and set PACKAGES_PATH to support builds.
> 
>   https://github.com/mdkinney/edk2-libc/commit/d004f93626b3bb962c24500db6ec7284db074c9a

In both README files here, I've noticed the following:

- typo:

"The EADK is depends on the EDK II source tree and need to be installed
with"

should be

"The EADK depends on the EDK II source tree and needs to be installed with"

- another typo:

"git clone https://github.com/mdkinney/edk2-libc.git"

should be

"git clone https://github.com/tianocore/edk2-libc.git"

With those fixed in both READMEs:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

> 
> * Fix a minor issue that removes warnings when building 
>   edk2-libc packages with VS2015 toolchains.
> 
>   https://github.com/mdkinney/edk2-libc/commit/145d262e94182a6b4631e0b6df5bc5d67e209931

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo

> 
> Best regards,
> 
> Mike
> 
> 
>