From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.d.kinney@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 08 May 2019 10:29:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 10:29:54 -0700 X-ExtLoop1: 1 Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga008.fm.intel.com with ESMTP; 08 May 2019 10:29:54 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 10:29:53 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.24]) by ORSMSX153.amr.corp.intel.com ([169.254.12.186]) with mapi id 14.03.0415.000; Wed, 8 May 2019 10:29:53 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "MinnowWare@outlook.com" , "Carsey, Jaben" , "Bi, Dandan" , Laszlo Ersek , "Ard Biesheuvel" , "Kinney, Michael D" CC: "Ni, Ray" , Leif Lindholm , "Gao, Liming" , "Richardson, Brian" Subject: Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg Thread-Topic: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg Thread-Index: AQHU9OiiYB5P3epmbESPdGQewXJoiaZAZmGAgAA8kICAAO/ygIAH6gWAgBfe3ACAAEEh8A== Date: Wed, 8 May 2019 17:29:53 +0000 Message-ID: References: <20190417064011.7000-1-dandan.bi@intel.com> <72474caf-c936-1ff7-a92c-b0f279d5418e@redhat.com> <3C0D5C461C9E904E8F62152F6274C0BB40BBD0CA@SHSMSX104.ccr.corp.intel.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_E92EE9817A31E24EB0585FDF735412F5B9CA48B0ORSMSX113amrcor_" --_000_E92EE9817A31E24EB0585FDF735412F5B9CA48B0ORSMSX113amrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Killian, The immediate replacement is to use the link to the edk2-stable tag from M= arch that includes the UEFI Shell binary. https://github.com/tianocore/edk2/tree/edk2-stable201903/ShellBinPkg/UefiS= hell/X64 There have been discussions that future edk2-stable tags to provide pre-bu= ilt binaries like the UEFI Shell in the GitHub release page for the edk2-st= able tag. Mike From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Minn= ow Ware Sent: Tuesday, May 7, 2019 11:35 PM To: devel@edk2.groups.io; Carsey, Jaben ; Bi, Dand= an ; Laszlo Ersek ; Ard Biesheuvel = Cc: edk2-devel-groups-io ; Ni, Ray ; Leif Lindholm ; Gao, Liming ; Richardson, Brian Subject: Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg Hi all, does that mean, that SHELL.EFI from a trusted source is currently unavaila= ble for the industry? There are a couple of web sites that refer to "https://github.com/tianocor= e/edk2/raw/master/ShellBinPkg/UefiShell/X64" (https://www.google.com/search?ei=3DSUvPXPneNIeFmwXQvo6gAg&q=3Dhttps%3A%2F= %2Fgithub.com%2Ftianocore%2Fedk2%2Fraw%2Fmaster%2FShellBinPkg%2FUefiShell%2= FX64&oq=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fraw%2Fmaster%2FShel= lBinPkg%2FUefiShell%2FX64&gs_l=3Dpsy-ab.3...3050.3050..3392...0.0..0.102.10= 2.0j1......0....2j1..gws-wiz.9e-I_-IL7Zs) Where get I SHELL.EFI right now? Best regards, Kilian ________________________________ From: devel@edk2.groups.io > on behalf of Carsey, Jaben > Sent: Tuesday, April 23, 2019 4:03:05 AM To: Bi, Dandan; Laszlo Ersek; Ard Biesheuvel Cc: edk2-devel-groups-io; Ni, Ray; Leif Lindholm; Gao, Liming Subject: Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg Assuming Laszlo's comment is addressed. Reviewed-by: Jaben Carsey > > -----Original Message----- > From: Bi, Dandan > Sent: Wednesday, April 17, 2019 6:12 PM > To: Laszlo Ersek >; Ard Bies= heuvel > > > Cc: edk2-devel-groups-io >; Carsey, Jaben > >; Ni, Ray >; Leif Lindholm > >; Gao, Liming= > > Subject: RE: [patch] ShellBinPkg: Remove ShellBinPkg > Importance: High > > Thank you all. > I will update the patch according to Laszlo's comments before commit the > patch. > > > Thanks, > Dandan > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Wednesday, April 17, 2019 6:53 PM > > To: Ard Biesheuvel >; Bi, Dandan > > > > > Cc: edk2-devel-groups-io >; Carsey, Jaben > > >; Ni, Ray >; Leif Lindholm > > >; Gao, Limi= ng > > > Subject: Re: [patch] ShellBinPkg: Remove ShellBinPkg > > > > On 04/17/19 09:16, Ard Biesheuvel wrote: > > > On Tue, 16 Apr 2019 at 23:40, Dandan Bi > wrote: > > >> > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1675 > > >> > > >> Remove ShellBinPkg from edk2. > > >> If developers work on current edk2 master and still want to use > > >> Shell binary after this removal, they can get it from source code > > >> in the Assets part of edk2-stable201903 tag release page. > > >> And from next release (edk2-stable201905 tag), we will publish all > > >> Shell binaries to the according Assets part directly. > > >> edk2 release link: https://github.com/tianocore/edk2/releases > > >> > > >> Cc: Jaben Carsey > > > >> Cc: Ray Ni > > > >> Cc: Leif Lindholm > > > >> Cc: Ard Biesheuvel > > > >> Cc: Liming Gao > > > >> Cc: Laszlo Ersek > > > >> Signed-off-by: Dandan Bi > > > > > > > Acked-by: Ard Biesheuvel > > > > > > > BTW you can use the --no-binary option to git to omit the binary > > > diffs in the patch. Especially when deleting binaries, that saves a > > > lot of hassle dealing with a multimegabyte patch email. > > > > +1 > > > > For the patch, I have a request towards Dandan: regarding the line > > > > +Maintainers for stable Shell binaries generation when need to publish > > +Shell > > binaries with edk2 release: > > > > please: > > > > (1) wrap it with an 80-char margin, > > (2) please insert a blank line just above it. > > > > With those: > > > > Acked-by: Laszlo Ersek > > > > > Thanks > > Laszlo --_000_E92EE9817A31E24EB0585FDF735412F5B9CA48B0ORSMSX113amrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Killian,

 

The immediate replacement is to use the link to the edk2-stabl= e tag from March that includes the UEFI Shell binary.

 

https://github.com/tianocore/ed= k2/tree/edk2-stable201903/ShellBinPkg/UefiShell/X64

 

There have been discussions that future edk2-stable tags to pr= ovide pre-built binaries like the UEFI Shell in the GitHub release page for the edk2-stable tag.

 

Mike

 

From: = devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Minnow Ware
Sent: Tuesday, May 7, 2019 11:35 PM
To: devel@edk2.groups.io; Carsey, Jaben <jaben.carsey@intel.com&= gt;; Bi, Dandan <dandan.bi@intel.com>; Laszlo Ersek <lersek@redhat= .com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Ni, Ray <= ray.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, = Liming <liming.gao@intel.com>; Richardson, Brian <brian.richardson= @intel.com>
Subject: Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

 

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Carsey, Jaben <jaben.carsey@= intel.com>
Sent: Tuesday, April 23, 2019 4:03:05 AM
To: Bi, Dandan; Laszlo Ersek; Ard Biesheuvel
Cc: edk2-devel-groups-io; Ni, Ray; Leif Lindholm; Gao, Liming
Subject: Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

 

Assuming L= aszlo's comment is addressed.
Reviewed-by: Jaben Carsey <ja= ben.carsey@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, April 17, 2019 6:12 PM
> To: Laszlo Ersek <lersek@redh= at.com>; Ard Biesheuvel
> <ard.biesheuvel@linar= o.org>
> Cc: edk2-devel-groups-io <= devel@edk2.groups.io>; Carsey, Jaben
> <jaben.carsey@intel.com<= /a>>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.= org>; Gao, Liming <liming= .gao@intel.com>
> Subject: RE: [patch] ShellBinPkg: Remove ShellBinPkg
> Importance: High
>
> Thank you all.
> I will update the patch according to Laszlo's comments before commit = the
> patch.
>
>
> Thanks,
> Dandan
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:= lersek@redhat.com]
> > Sent: Wednesday, April 17, 2019 6:53 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Bi, Dandan
> > <dandan.bi@intel.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Carsey, Jaben
> > <jaben.carsey@intel= .com>; Ni, Ray <ray.ni@intel.= com>; Leif Lindholm
> > <leif.lindholm@li= naro.org>; Gao, Liming <l= iming.gao@intel.com>
> > Subject: Re: [patch] ShellBinPkg: Remove ShellBinPkg
> >
> > On 04/17/19 09:16, Ard Biesheuvel wrote:
> > > On Tue, 16 Apr 2019 at 23:40, Dandan Bi <dandan.bi@intel.com> wrote:
> > >>
> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1675 > > >>
> > >> Remove ShellBinPkg from edk2.
> > >> If developers work on current edk2 master and still wan= t to use
> > >> Shell binary after this removal, they can get it from s= ource code
> > >> in the Assets part of edk2-stable201903 tag release pag= e.
> > >> And from next release (edk2-stable201905 tag), we will = publish all
> > >> Shell binaries to the according Assets part directly. > > >> edk2 release link: https://github.com/tianocore/edk2/releases
> > >>
> > >> Cc: Jaben Carsey <jaben.carsey@intel.com>
> > >> Cc: Ray Ni <ray.= ni@intel.com>
> > >> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >> Cc: Liming Gao <liming.gao@intel.com>
> > >> Cc: Laszlo Ersek <lersek@redhat.com>
> > >> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > >
> > > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > BTW you can use the --no-binary option to git to omit the b= inary
> > > diffs in the patch. Especially when deleting binaries, that= saves a
> > > lot of hassle dealing with a multimegabyte patch email.
> >
> > +1
> >
> > For the patch, I have a request towards Dandan: regarding the li= ne
> >
> > +Maintainers for stable Shell binaries generation when need = to publish
> > +Shell
> > binaries with edk2 release:
> >
> > please:
> >
> > (1) wrap it with an 80-char margin,
> > (2) please insert a blank line just above it.
> >
> > With those:
> >
> > Acked-by: Laszlo Ersek <= lersek@redhat.com>
> >
> > Thanks
> > Laszlo


--_000_E92EE9817A31E24EB0585FDF735412F5B9CA48B0ORSMSX113amrcor_--