From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg from edk2
Date: Fri, 10 May 2019 19:16:47 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9CA5E3B@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20190510175656.2ekr3slbbpcqo4bi@bivouac.eciton.net>
Leif,
Thanks. I will fix the typo.
I did not change any of the .dec or .dsc files with this series.
I tested builds by using PACKAGES_PATH.
Do you approve the change with the typo fixed or do you want
me to send a V2?
Thanks,
Mike
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Friday, May 10, 2019 10:57 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Subject: Re: [edk2-platforms: Patch 1/8]
> Silicon/TexasInsturments: Import Omap35xxPkg from edk2
>
> Hi Mike,
>
> I'm afraid a typo has snuck in below:
>
> On Thu, May 09, 2019 at 08:34:28PM -0700, Michael D
> Kinney wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1467
> >
> > Import Omap35xxPkg from edk2/master.
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> > ---
> > .../Omap35xxPkg/Flash/Flash.c | 768
> +++++++++
> > .../Omap35xxPkg/Flash/Flash.h | 100
> ++
> > .../Omap35xxPkg/Flash/Flash.inf | 42
> +
> > .../TexasInsturments/Omap35xxPkg/Gpio/Gpio.c | 129
> ++
> > .../Omap35xxPkg/Gpio/Gpio.inf | 39
> +
> > .../Omap35xxPkg/Include/Library/OmapDmaLib.h | 84
> +
> > .../Omap35xxPkg/Include/Library/OmapLib.h | 38
> +
> > .../Omap35xxPkg/Include/Omap3530/Omap3530.h | 34
> +
> > .../Include/Omap3530/Omap3530Dma.h | 124
> ++
> > .../Include/Omap3530/Omap3530Gpio.h | 125
> ++
> > .../Include/Omap3530/Omap3530Gpmc.h | 101
> ++
> > .../Include/Omap3530/Omap3530I2c.h | 56
> +
> > .../Include/Omap3530/Omap3530Interrupt.h | 45
> +
> > .../Include/Omap3530/Omap3530MMCHS.h | 208
> +++
> > .../Omap3530/Omap3530PadConfiguration.h | 297
> ++++
> > .../Include/Omap3530/Omap3530Prcm.h | 159
> ++
> > .../Include/Omap3530/Omap3530Timer.h | 76
> +
> > .../Include/Omap3530/Omap3530Uart.h | 48
> +
> > .../Include/Omap3530/Omap3530Usb.h | 42
> +
> > .../Omap35xxPkg/Include/TPS65950.h | 74
> +
> > .../InterruptDxe/HardwareInterrupt.c | 396
> +++++
> > .../Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 48
> +
> > .../LcdGraphicsOutputBlt.c | 439
> +++++
> > .../LcdGraphicsOutputDxe.c | 394
> +++++
> > .../LcdGraphicsOutputDxe.h | 151
> ++
> > .../LcdGraphicsOutputDxe.inf | 46
> +
> > .../DebugAgentTimerLib/DebugAgentTimerLib.c | 159
> ++
> > .../DebugAgentTimerLib/DebugAgentTimerLib.inf | 42
> +
> > .../Library/GdbSerialLib/GdbSerialLib.c | 96
> ++
> > .../Library/GdbSerialLib/GdbSerialLib.inf | 35
> +
> > .../Omap35xxTimerLib/Omap35xxTimerLib.inf | 40
> +
> > .../Library/Omap35xxTimerLib/TimerLib.c | 151
> ++
> > .../Library/OmapDmaLib/OmapDmaLib.c | 170
> ++
> > .../Library/OmapDmaLib/OmapDmaLib.inf | 43
> +
> > .../Omap35xxPkg/Library/OmapLib/OmapLib.c | 77
> +
> > .../Omap35xxPkg/Library/OmapLib/OmapLib.inf | 31
> +
> > .../RealTimeClockLib/RealTimeClockLib.c | 291
> ++++
> > .../RealTimeClockLib/RealTimeClockLib.inf | 32
> +
> > .../Library/SerialPortLib/SerialPortLib.c | 208
> +++
> > .../Library/SerialPortLib/SerialPortLib.inf | 40
> +
> > .../Omap35xxPkg/MMCHSDxe/MMCHS.c | 1492
> +++++++++++++++++
> > .../Omap35xxPkg/MMCHSDxe/MMCHS.h | 169
> ++
> > .../Omap35xxPkg/MMCHSDxe/MMCHS.inf | 48
> +
> > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.c | 671
> ++++++++
> > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.h | 38
> +
> > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 47
> +
> > .../Omap35xxPkg/Omap35xxPkg.dec | 52
> +
> > .../Omap35xxPkg/Omap35xxPkg.dsc | 183
> ++
> > .../Omap35xxPkg/PciEmulation/PciEmulation.c | 107
> ++
> > .../Omap35xxPkg/PciEmulation/PciEmulation.inf | 41
> +
> > .../Omap35xxPkg/SmbusDxe/Smbus.c | 319
> ++++
> > .../Omap35xxPkg/SmbusDxe/Smbus.inf | 39
> +
> > .../Omap35xxPkg/TPS65950Dxe/TPS65950.c | 110
> ++
> > .../Omap35xxPkg/TPS65950Dxe/TPS65950.inf | 42
> +
> > .../Omap35xxPkg/TimerDxe/Timer.c | 370
> ++++
> > .../Omap35xxPkg/TimerDxe/TimerDxe.inf | 51
> +
> > 56 files changed, 9257 insertions(+)
> > create mode 100644
> Silicon/TexasInsturments/Omap35xxPkg/Flash/Flash.c
>
> TexasInsturments ->
> TexasInstruments
>
> Also, using the sortorder and --stat/--stat-graph-width
> from Laszlo's
> guide when generating patches would be helpful here even
> though the
> code is just moving. It makes the above more clear, and
> puts the .dec
> and .dsc (which have actually changed) first.
>
> Beyond that, I intend to change both this and
> BeagleBoardPkg to use
> full pathnames relative to edk2-platforms root after the
> migration,
> but we don't need to do that for the migration.
>
> Best Regards,
>
> Leif
next prev parent reply other threads:[~2019-05-10 19:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 3:34 [edk2-platforms: Patch 0/8] Add packages from edk2 Michael D Kinney
2019-05-10 3:34 ` [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg " Michael D Kinney
2019-05-10 17:56 ` Leif Lindholm
2019-05-10 19:16 ` Michael D Kinney [this message]
2019-05-10 19:54 ` Leif Lindholm
2019-05-10 3:34 ` [edk2-platforms: Patch 2/8] Platform/BeagleBoard: Import BeagleBoardPkg " Michael D Kinney
2019-05-10 3:34 ` [edk2-platforms: Patch 3/8] Silicon/Intel: Import QuarkSocPkg " Michael D Kinney
2019-05-10 3:34 ` [edk2-platforms: Patch 4/8] Platform/QuarkPlatformPkg: Import QuarkPlatformPkg " Michael D Kinney
2019-05-10 3:34 ` [edk2-platforms: Patch 5/8] Platform/Vlv2DeviceRefCodePkg: Import Vlv2DeviceRefCodePkg " Michael D Kinney
2019-05-13 2:52 ` Sun, Zailiang
2019-05-10 3:34 ` [edk2-platforms: Patch 6/8] Platform/Vlv2TbltDevicePkg: Import Vlv2TbltDevicePkg " Michael D Kinney
2019-05-13 2:52 ` Sun, Zailiang
2019-05-10 3:34 ` [edk2-platforms: Patch 7/8] Drivers/OptionRomPkg: Import OptionRomPkg " Michael D Kinney
2019-05-11 1:52 ` Ni, Ray
2019-05-10 3:34 ` [edk2-platforms: Patch 8/8] edk2-platforms: Update Maintainers.txt/Readme.md for imported packages Michael D Kinney
2019-05-10 18:04 ` [edk2-devel] " Leif Lindholm
2019-05-13 2:52 ` Sun, Zailiang
2019-05-10 5:14 ` [edk2-devel] [edk2-platforms: Patch 0/8] Add packages from edk2 Liming Gao
2019-05-10 6:17 ` Michael D Kinney
2019-05-10 7:32 ` Liming Gao
2019-05-10 18:49 ` Kubacki, Michael A
2019-05-11 2:12 ` Ni, Ray
2019-05-13 21:03 ` Steele, Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9CA5E3B@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox