From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.d.kinney@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 10 May 2019 12:16:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 12:16:48 -0700 X-ExtLoop1: 1 Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 10 May 2019 12:16:48 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 10 May 2019 12:16:47 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.24]) by ORSMSX156.amr.corp.intel.com ([169.254.8.17]) with mapi id 14.03.0415.000; Fri, 10 May 2019 12:16:47 -0700 From: "Michael D Kinney" To: Leif Lindholm , "Kinney, Michael D" CC: "devel@edk2.groups.io" , Ard Biesheuvel Subject: Re: [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg from edk2 Thread-Topic: [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg from edk2 Thread-Index: AQHVB1nFs5FCTQldgEq13nvRMYnXyaZkulbw Date: Fri, 10 May 2019 19:16:47 +0000 Message-ID: References: <20190510033435.24112-1-michael.d.kinney@intel.com> <20190510033435.24112-2-michael.d.kinney@intel.com> <20190510175656.2ekr3slbbpcqo4bi@bivouac.eciton.net> In-Reply-To: <20190510175656.2ekr3slbbpcqo4bi@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Thanks. I will fix the typo. I did not change any of the .dec or .dsc files with this series. I tested builds by using PACKAGES_PATH. Do you approve the change with the typo fixed or do you want=20 me to send a V2? Thanks, Mike > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Friday, May 10, 2019 10:57 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Ard Biesheuvel > > Subject: Re: [edk2-platforms: Patch 1/8] > Silicon/TexasInsturments: Import Omap35xxPkg from edk2 >=20 > Hi Mike, >=20 > I'm afraid a typo has snuck in below: >=20 > On Thu, May 09, 2019 at 08:34:28PM -0700, Michael D > Kinney wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1467 > > > > Import Omap35xxPkg from edk2/master. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Signed-off-by: Michael D Kinney > > > --- > > .../Omap35xxPkg/Flash/Flash.c | 768 > +++++++++ > > .../Omap35xxPkg/Flash/Flash.h | 100 > ++ > > .../Omap35xxPkg/Flash/Flash.inf | 42 > + > > .../TexasInsturments/Omap35xxPkg/Gpio/Gpio.c | 129 > ++ > > .../Omap35xxPkg/Gpio/Gpio.inf | 39 > + > > .../Omap35xxPkg/Include/Library/OmapDmaLib.h | 84 > + > > .../Omap35xxPkg/Include/Library/OmapLib.h | 38 > + > > .../Omap35xxPkg/Include/Omap3530/Omap3530.h | 34 > + > > .../Include/Omap3530/Omap3530Dma.h | 124 > ++ > > .../Include/Omap3530/Omap3530Gpio.h | 125 > ++ > > .../Include/Omap3530/Omap3530Gpmc.h | 101 > ++ > > .../Include/Omap3530/Omap3530I2c.h | 56 > + > > .../Include/Omap3530/Omap3530Interrupt.h | 45 > + > > .../Include/Omap3530/Omap3530MMCHS.h | 208 > +++ > > .../Omap3530/Omap3530PadConfiguration.h | 297 > ++++ > > .../Include/Omap3530/Omap3530Prcm.h | 159 > ++ > > .../Include/Omap3530/Omap3530Timer.h | 76 > + > > .../Include/Omap3530/Omap3530Uart.h | 48 > + > > .../Include/Omap3530/Omap3530Usb.h | 42 > + > > .../Omap35xxPkg/Include/TPS65950.h | 74 > + > > .../InterruptDxe/HardwareInterrupt.c | 396 > +++++ > > .../Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 48 > + > > .../LcdGraphicsOutputBlt.c | 439 > +++++ > > .../LcdGraphicsOutputDxe.c | 394 > +++++ > > .../LcdGraphicsOutputDxe.h | 151 > ++ > > .../LcdGraphicsOutputDxe.inf | 46 > + > > .../DebugAgentTimerLib/DebugAgentTimerLib.c | 159 > ++ > > .../DebugAgentTimerLib/DebugAgentTimerLib.inf | 42 > + > > .../Library/GdbSerialLib/GdbSerialLib.c | 96 > ++ > > .../Library/GdbSerialLib/GdbSerialLib.inf | 35 > + > > .../Omap35xxTimerLib/Omap35xxTimerLib.inf | 40 > + > > .../Library/Omap35xxTimerLib/TimerLib.c | 151 > ++ > > .../Library/OmapDmaLib/OmapDmaLib.c | 170 > ++ > > .../Library/OmapDmaLib/OmapDmaLib.inf | 43 > + > > .../Omap35xxPkg/Library/OmapLib/OmapLib.c | 77 > + > > .../Omap35xxPkg/Library/OmapLib/OmapLib.inf | 31 > + > > .../RealTimeClockLib/RealTimeClockLib.c | 291 > ++++ > > .../RealTimeClockLib/RealTimeClockLib.inf | 32 > + > > .../Library/SerialPortLib/SerialPortLib.c | 208 > +++ > > .../Library/SerialPortLib/SerialPortLib.inf | 40 > + > > .../Omap35xxPkg/MMCHSDxe/MMCHS.c | 1492 > +++++++++++++++++ > > .../Omap35xxPkg/MMCHSDxe/MMCHS.h | 169 > ++ > > .../Omap35xxPkg/MMCHSDxe/MMCHS.inf | 48 > + > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.c | 671 > ++++++++ > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.h | 38 > + > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 47 > + > > .../Omap35xxPkg/Omap35xxPkg.dec | 52 > + > > .../Omap35xxPkg/Omap35xxPkg.dsc | 183 > ++ > > .../Omap35xxPkg/PciEmulation/PciEmulation.c | 107 > ++ > > .../Omap35xxPkg/PciEmulation/PciEmulation.inf | 41 > + > > .../Omap35xxPkg/SmbusDxe/Smbus.c | 319 > ++++ > > .../Omap35xxPkg/SmbusDxe/Smbus.inf | 39 > + > > .../Omap35xxPkg/TPS65950Dxe/TPS65950.c | 110 > ++ > > .../Omap35xxPkg/TPS65950Dxe/TPS65950.inf | 42 > + > > .../Omap35xxPkg/TimerDxe/Timer.c | 370 > ++++ > > .../Omap35xxPkg/TimerDxe/TimerDxe.inf | 51 > + > > 56 files changed, 9257 insertions(+) > > create mode 100644 > Silicon/TexasInsturments/Omap35xxPkg/Flash/Flash.c >=20 > TexasInsturments -> > TexasInstruments >=20 > Also, using the sortorder and --stat/--stat-graph-width > from Laszlo's > guide when generating patches would be helpful here even > though the > code is just moving. It makes the above more clear, and > puts the .dec > and .dsc (which have actually changed) first. >=20 > Beyond that, I intend to change both this and > BeagleBoardPkg to use > full pathnames relative to edk2-platforms root after the > migration, > but we don't need to do that for the migration. >=20 > Best Regards, >=20 > Leif