From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 21 May 2019 08:44:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 08:44:51 -0700 X-ExtLoop1: 1 Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga006.jf.intel.com with ESMTP; 21 May 2019 08:44:51 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.231]) by ORSMSX108.amr.corp.intel.com ([169.254.2.171]) with mapi id 14.03.0415.000; Tue, 21 May 2019 08:44:51 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "Feng, Bob C" , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Topic: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Index: AQHVBvpVHgL7tfpsIEagyCNhwfYnM6ZkaouAgAACYoCAEcfuAP//k5Ww Date: Tue, 21 May 2019 15:44:50 +0000 Message-ID: References: <20190510063336.27928-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44EF2C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44EF2C@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney If we want the 'run' target to work for the EmulatorPkg, we can add a python post build script to support that. Please enter a BZ feature request. There is an example in the following edk2-staging branch that runs QEMU for an OvmfPkg build using a 'run' target. https://github.com/tianocore/edk2-staging/tree/Bug_1525_FmpDevicePkg_Multip= leControllers/OvmfPkg The DSC file contains a POSTBUILD statement. There are two python scripts in this example, but could be consolidated to a single python script for the EmulatorPkg. Run.py finds the output directory where the EmulatorPkg executable for each=20 supported host OS can be found. https://github.com/tianocore/edk2-staging/blob/Bug_1525_FmpDevicePkg_Multip= leControllers/OvmfPkg/OvmfPkgIa32X64.dsc https://github.com/tianocore/edk2-staging/blob/Bug_1525_FmpDevicePkg_Multip= leControllers/OvmfPkg/PostBuild.py https://github.com/tianocore/edk2-staging/blob/Bug_1525_FmpDevicePkg_Multip= leControllers/OvmfPkg/Run.py Best regards, Mike > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, May 21, 2019 8:06 AM > To: Feng, Bob C ; > devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch] BaseTools: Remove './SecMain' from > 'run' target >=20 > Bob: > Because NT32 has been removed, this change should be > OK. Reviewed-by: Liming Gao >=20 > Thanks > Liming > > -----Original Message----- > > From: Feng, Bob C > > Sent: Friday, May 10, 2019 3:34 PM > > To: Gao, Liming ; > devel@edk2.groups.io > > Cc: Kinney, Michael D > > Subject: RE: [Patch] BaseTools: Remove './SecMain' > from 'run' target > > > > I think NT32Pkg need a POSTBUILD scripts to execute > its run command. > > > > > > -----Original Message----- > > From: Gao, Liming > > Sent: Friday, May 10, 2019 3:26 PM > > To: Feng, Bob C ; > devel@edk2.groups.io > > Cc: Kinney, Michael D > > Subject: RE: [Patch] BaseTools: Remove './SecMain' > from 'run' target > > > > Bob: > > Please make sure run command still works on NT32 > platform. > > > > >-----Original Message----- > > >From: Feng, Bob C > > >Sent: Friday, May 10, 2019 2:34 PM > > >To: devel@edk2.groups.io > > >Cc: Feng, Bob C ; Gao, Liming > > >; Kinney, Michael D > > > >Subject: [Patch] BaseTools: Remove './SecMain' from > 'run' target > > > > > >BZ: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1561 > > > > > >When a target of 'run' is passed into build.py, > BaseTools > > >unconditionally attempts to execute the application > called './SecMain' > > >in the build output directory. > > > > > >This behavior applies to the Nt32Pkg which is being > replaced with > > >features in the EmulatorPkg. > > > > > >Signed-off-by: Bob Feng > > >Cc: Liming Gao > > >Cc: Michael D Kinney > > >--- > > > BaseTools/Source/Python/build/build.py | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > >diff --git a/BaseTools/Source/Python/build/build.py > > >b/BaseTools/Source/Python/build/build.py > > >index 7271570d29..04f266abf5 100644 > > >--- a/BaseTools/Source/Python/build/build.py > > >+++ b/BaseTools/Source/Python/build/build.py > > >@@ -1225,14 +1225,10 @@ class Build(): > > > > > > makefile =3D > > > >GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.g > MakeType] > > > > > > # run > > > if Target =3D=3D 'run': > > >- RunDir =3D > os.path.normpath(os.path.join(AutoGenObject.BuildDir, > > >GlobalData.gGlobalDefines['ARCH'])) > > >- Command =3D '.\SecMain' > > >- os.chdir(RunDir) > > >- LaunchCommand(Command, RunDir) > > > return True > > > > > > # build modules > > > if BuildModule: > > > BuildCommand =3D BuildCommand + [Target] > > >-- > > >2.20.1.windows.1