From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.d.kinney@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 22 May 2019 15:30:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 15:30:47 -0700 X-ExtLoop1: 1 Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga003.jf.intel.com with ESMTP; 22 May 2019 15:30:47 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 15:30:47 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.231]) by ORSMSX163.amr.corp.intel.com ([169.254.9.150]) with mapi id 14.03.0415.000; Wed, 22 May 2019 15:30:47 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "Feng, Bob C" , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Topic: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Index: AQHVBvpVHgL7tfpsIEagyCNhwfYnM6ZkaouAgAACYoCAEcfuAP//k5WwgAIFXgA= Date: Wed, 22 May 2019 22:30:47 +0000 Message-ID: References: <20190510063336.27928-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44EF2C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob, I just noticed that there is a 2nd reference to 'SecMain' in build.py that was missed in this patch review. Is there a reason both were not removed? Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, May 21, 2019 8:45 AM > To: Gao, Liming ; Feng, Bob C > ; devel@edk2.groups.io; Kinney, > Michael D > Subject: RE: [Patch] BaseTools: Remove './SecMain' from > 'run' target >=20 > Reviewed-by: Michael D Kinney > >=20 > If we want the 'run' target to work for the > EmulatorPkg, we > can add a python post build script to support that. > Please > enter a BZ feature request. >=20 > There is an example in the following edk2-staging > branch that > runs QEMU for an OvmfPkg build using a 'run' target. >=20 > https://github.com/tianocore/edk2- > staging/tree/Bug_1525_FmpDevicePkg_MultipleControllers/ > OvmfPkg >=20 > The DSC file contains a POSTBUILD statement. There are > two > python scripts in this example, but could be > consolidated to > a single python script for the EmulatorPkg. Run.py > finds the > output directory where the EmulatorPkg executable for > each > supported host OS can be found. >=20 > https://github.com/tianocore/edk2- > staging/blob/Bug_1525_FmpDevicePkg_MultipleControllers/ > OvmfPkg/OvmfPkgIa32X64.dsc >=20 > https://github.com/tianocore/edk2- > staging/blob/Bug_1525_FmpDevicePkg_MultipleControllers/ > OvmfPkg/PostBuild.py >=20 > https://github.com/tianocore/edk2- > staging/blob/Bug_1525_FmpDevicePkg_MultipleControllers/ > OvmfPkg/Run.py >=20 > Best regards, >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Tuesday, May 21, 2019 8:06 AM > > To: Feng, Bob C ; > > devel@edk2.groups.io > > Cc: Kinney, Michael D > > Subject: RE: [Patch] BaseTools: Remove './SecMain' > from > > 'run' target > > > > Bob: > > Because NT32 has been removed, this change should > be > > OK. Reviewed-by: Liming Gao > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Feng, Bob C > > > Sent: Friday, May 10, 2019 3:34 PM > > > To: Gao, Liming ; > > devel@edk2.groups.io > > > Cc: Kinney, Michael D > > > Subject: RE: [Patch] BaseTools: Remove './SecMain' > > from 'run' target > > > > > > I think NT32Pkg need a POSTBUILD scripts to execute > > its run command. > > > > > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Friday, May 10, 2019 3:26 PM > > > To: Feng, Bob C ; > > devel@edk2.groups.io > > > Cc: Kinney, Michael D > > > Subject: RE: [Patch] BaseTools: Remove './SecMain' > > from 'run' target > > > > > > Bob: > > > Please make sure run command still works on NT32 > > platform. > > > > > > >-----Original Message----- > > > >From: Feng, Bob C > > > >Sent: Friday, May 10, 2019 2:34 PM > > > >To: devel@edk2.groups.io > > > >Cc: Feng, Bob C ; Gao, > Liming > > > >; Kinney, Michael D > > > > > >Subject: [Patch] BaseTools: Remove './SecMain' > from > > 'run' target > > > > > > > >BZ: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1561 > > > > > > > >When a target of 'run' is passed into build.py, > > BaseTools > > > >unconditionally attempts to execute the > application > > called './SecMain' > > > >in the build output directory. > > > > > > > >This behavior applies to the Nt32Pkg which is > being > > replaced with > > > >features in the EmulatorPkg. > > > > > > > >Signed-off-by: Bob Feng > > > >Cc: Liming Gao > > > >Cc: Michael D Kinney > > > >--- > > > > BaseTools/Source/Python/build/build.py | 4 ---- > > > > 1 file changed, 4 deletions(-) > > > > > > > >diff --git > a/BaseTools/Source/Python/build/build.py > > > >b/BaseTools/Source/Python/build/build.py > > > >index 7271570d29..04f266abf5 100644 > > > >--- a/BaseTools/Source/Python/build/build.py > > > >+++ b/BaseTools/Source/Python/build/build.py > > > >@@ -1225,14 +1225,10 @@ class Build(): > > > > > > > > makefile =3D > > > > > > >GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.g > > MakeType] > > > > > > > > # run > > > > if Target =3D=3D 'run': > > > >- RunDir =3D > > os.path.normpath(os.path.join(AutoGenObject.BuildDir, > > > >GlobalData.gGlobalDefines['ARCH'])) > > > >- Command =3D '.\SecMain' > > > >- os.chdir(RunDir) > > > >- LaunchCommand(Command, RunDir) > > > > return True > > > > > > > > # build modules > > > > if BuildModule: > > > > BuildCommand =3D BuildCommand + > [Target] > > > >-- > > > >2.20.1.windows.1