From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch 2] BaseTools: Remove './SecMain' from 'run' target
Date: Thu, 23 May 2019 14:40:46 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D1BE4F@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20190523090635.29040-1-bob.c.feng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Thursday, May 23, 2019 2:07 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [Patch 2] BaseTools: Remove
> './SecMain' from 'run' target
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561
>
> This patch is related to commit 9ca1f1
> It's to remove the second .SecMain call from 'run'
> target.
>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> BaseTools/Source/Python/build/build.py | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index a8b4ce7375..80ceb98310 100644
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -1358,14 +1358,10 @@ class Build():
> EdkLogger.error("build",
> COMMAND_FAILURE)
> return True
>
> # run
> if Target == 'run':
> - RunDir =
> os.path.normpath(os.path.join(AutoGenObject.BuildDir,
> GlobalData.gGlobalDefines['ARCH']))
> - Command = '.\SecMain'
> - os.chdir(RunDir)
> - LaunchCommand(Command, RunDir)
> return True
>
> # build library
> if Target == 'libraries':
> pass
> --
> 2.20.1.windows.1
>
>
>
prev parent reply other threads:[~2019-05-23 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:06 [Patch 2] BaseTools: Remove './SecMain' from 'run' target Bob Feng
2019-05-23 14:01 ` Liming Gao
2019-05-23 14:40 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9D1BE4F@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox