Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

["Michael D Kinney" <michael.d.kinney@intel.com>]

Anthony,

I am curious.  I agree that a GUID can be defined in DEC file and
in an include file that is used as a Vendor GUID in a device path.

Is there any reason that the FILE_GUID for the module needs to be
the same GUID value?  Is there any code that looks for an FFS file
with that GUID value as the FFS file name?

If not, then it would be better to not over use that GUID value.
The FILE_GUID of the SerialDxe can be different.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Anthony
> PERARD
> Sent: Wednesday, May 29, 2019 4:37 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Zeng, Star
> <star.zeng@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Julien Grall <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Laszlo Ersek
> <lersek@redhat.com>; Anthony PERARD
> <anthony.perard@citrix.com>
> Subject: [edk2-devel] [PATCH 0/4] Define
> SERIAL_DXE_FILE_GUID only once
> 
> The macro SERIAL_DXE_FILE_GUID is already been defined
> twice and the GUID is
> been used once without defining the macro. This patch
> series define the macro
> in MdeModulePkg where the SerialDxe is, and replace all
> other use by this new
> one.
> 
> Note that I haven't build/test those changes, but I
> have test the first patch
> by applying a similar change to a patch series I'm
> working on.
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-
> http/people/aperard/ovmf.git br.serial-dxe-guid-v1
> 
> Anthony PERARD (4):
>   MdeModulePkg: Add SERIAL_DXE_FILE_GUID
>   ArmVirtPkg/PlatformBootManagerLib: Use
> SERIAL_DXE_FILE_GUID from
>     MdeModulePkg
>   ArmPkg/PlatformBootManagerLib: Use
> SERIAL_DXE_FILE_GUID from
>     MdeModulePkg
>   UefiPayloadPkg/PlatformBootManagerLib: Use
> SERIAL_DXE_FILE_GUID from
>     MdeModulePkg
> 
>  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
>  MdeModulePkg/Include/Guid/SerialDxe.h         | 19
> +++++++++++++++++++
>  .../PlatformBootManagerLib/PlatformBm.c       |  6 +--
> ---
>  .../PlatformBootManagerLib/PlatformBm.c       |  6 +--
> ---
>  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
>  5 files changed, 26 insertions(+), 11 deletions(-)
>  create mode 100644
> MdeModulePkg/Include/Guid/SerialDxe.h
> 
> --
> Anthony PERARD
> 
> 
>