From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Sat, 01 Jun 2019 10:00:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2019 10:00:39 -0700 X-ExtLoop1: 1 Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga003.jf.intel.com with ESMTP; 01 Jun 2019 10:00:38 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 1 Jun 2019 10:00:38 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.231]) by ORSMSX163.amr.corp.intel.com ([169.254.9.150]) with mapi id 14.03.0415.000; Sat, 1 Jun 2019 10:00:38 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "anthony.perard@citrix.com" , "Kinney, Michael D" CC: "Wang, Jian J" , "Ni, Ray" , Ard Biesheuvel , "Zeng, Star" , "Wu, Hao A" , Julien Grall , Leif Lindholm , "Laszlo Ersek" Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once Thread-Topic: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once Thread-Index: AQHVFhLwy3uoyugrF0ybiYaxTjzOA6aHCc6w Date: Sat, 1 Jun 2019 17:00:37 +0000 Message-ID: References: <20190529113723.23186-1-anthony.perard@citrix.com> In-Reply-To: <20190529113723.23186-1-anthony.perard@citrix.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Anthony, I am curious. I agree that a GUID can be defined in DEC file and in an include file that is used as a Vendor GUID in a device path. Is there any reason that the FILE_GUID for the module needs to be the same GUID value? Is there any code that looks for an FFS file with that GUID value as the FFS file name? If not, then it would be better to not over use that GUID value. The FILE_GUID of the SerialDxe can be different. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Anthony > PERARD > Sent: Wednesday, May 29, 2019 4:37 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Ni, Ray > ; Ard Biesheuvel > ; Zeng, Star > ; Wu, Hao A ; > Julien Grall ; Leif Lindholm > ; Laszlo Ersek > ; Anthony PERARD > > Subject: [edk2-devel] [PATCH 0/4] Define > SERIAL_DXE_FILE_GUID only once >=20 > The macro SERIAL_DXE_FILE_GUID is already been defined > twice and the GUID is > been used once without defining the macro. This patch > series define the macro > in MdeModulePkg where the SerialDxe is, and replace all > other use by this new > one. >=20 > Note that I haven't build/test those changes, but I > have test the first patch > by applying a similar change to a patch series I'm > working on. >=20 > Patch series available in this git branch: > https://xenbits.xen.org/git- > http/people/aperard/ovmf.git br.serial-dxe-guid-v1 >=20 > Anthony PERARD (4): > MdeModulePkg: Add SERIAL_DXE_FILE_GUID > ArmVirtPkg/PlatformBootManagerLib: Use > SERIAL_DXE_FILE_GUID from > MdeModulePkg > ArmPkg/PlatformBootManagerLib: Use > SERIAL_DXE_FILE_GUID from > MdeModulePkg > UefiPayloadPkg/PlatformBootManagerLib: Use > SERIAL_DXE_FILE_GUID from > MdeModulePkg >=20 > MdeModulePkg/MdeModulePkg.dec | 3 +++ > MdeModulePkg/Include/Guid/SerialDxe.h | 19 > +++++++++++++++++++ > .../PlatformBootManagerLib/PlatformBm.c | 6 +-- > --- > .../PlatformBootManagerLib/PlatformBm.c | 6 +-- > --- > .../PlatformBootManagerLib/PlatformConsole.c | 3 ++- > 5 files changed, 26 insertions(+), 11 deletions(-) > create mode 100644 > MdeModulePkg/Include/Guid/SerialDxe.h >=20 > -- > Anthony PERARD >=20 >=20 >=20