From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.d.kinney@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 05 Jun 2019 15:37:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 15:36:59 -0700 X-ExtLoop1: 1 Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga005.jf.intel.com with ESMTP; 05 Jun 2019 15:36:59 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.231]) by ORSMSX109.amr.corp.intel.com ([169.254.11.251]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 15:36:59 -0700 From: "Michael D Kinney" To: Felix Polyudov , "devel@edk2.groups.io" , "Xu, Wei6" , "Kinney, Michael D" CC: "Wang, Jian J" , "Wu, Hao A" , "Gao, Liming" , "Zhang, Chao B" Subject: Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Thread-Topic: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Thread-Index: AQHVG7VHMLQQOxUNRE2gtYrjeDKkhqaOEBIA//+U79A= Date: Wed, 5 Jun 2019 22:36:59 +0000 Message-ID: References: <20190605154203.11012-1-wei6.xu@intel.com> <9333E191E0D52B4999CE63A99BA663A00302C9234C@atlms1.us.megatrends.com> In-Reply-To: <9333E191E0D52B4999CE63A99BA663A00302C9234C@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Felix, For (1), this is a limitation of UEFI Capsule On Disk for capsules that must be processed before End of DXE. This solution only work for EFI System Partitions that can be accessed from PEI. Platforms that require the use of a UEFI Driver loaded from a PCI Option ROM to access the EFI System Partition can not use the UEFI=20 Capsule On Disk feature. They must use the UEFI Capsule In Memory feature. For (2), in order to access the capsule file in the UEFI Spec defines location, the FAT PEIM would have to be extended to support reading files from subdirectories. The current FAT PEIM only supports reading files from the root directory. This is sufficient for reading recovery images. In order to minimize the size of complexity of PEI phase modules, this solution uses the FAT PEIM "as is" and uses the features of the UEFI FAT driver to move the Capsule On Disk content into a location that is compatible with the existing FAT PEIM. Thanks, Mike > -----Original Message----- > From: Felix Polyudov [mailto:Felixp@ami.com] > Sent: Wednesday, June 5, 2019 2:53 PM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Wang, Jian J ; Wu, Hao A > ; Kinney, Michael D > ; Gao, Liming > ; Zhang, Chao B > > Subject: RE: [edk2-devel][Patch v2 0/7] Implement > Capsule On Disk. >=20 > 1. It looks like the implementation processes capsule > files in PEI. > According to UEFI specification capsule files are stored > on the active ESP. > Not every UEFI boot device can be accessed in PEI. > For example, RAID connected to the PCI plug in card > cannot be accessed in PEI. >=20 > 2. Solution B) below relocates capsule to "a temp file > which will be stored in root directory". I think it is > cleaner to reuse UEFI capsule-on-disk infrastructure and > keep capsule file in the dedicated \EFI\UpdateCapsule > folder (refer to "Delivery of Capsules via file on Mass > Storage device" section of the UEFI specification). >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Xu, Wei6 > Sent: Wednesday, June 05, 2019 11:42 AM > To: devel@edk2.groups.io > Cc: Jian J Wang; Hao A Wu; Michael D Kinney; Liming Gao; > Chao B Zhang > Subject: [edk2-devel][Patch v2 0/7] Implement Capsule On > Disk. >=20 > V2: > Fix Ecc check failure. >=20 > V1: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1852 >=20 > This patch set implements Capsule On Disk. > Depends on whether platform supports Capsule-In-Ram, > Capsule On Disk feature is composed of 2 solutions: > Solution A): Load capsules out of TCB, rely on > UpdateCapsule() runtime service to deliver Capsule-On- > Disk. > Solution B): Relocate capsules into a temp file which > will be stored in root directory on a platform specific > storage device. > Leverage existing storage stack in PEI to load all > capsule on disk images and create capsule hobs for the > capsules. > This solution has bigger TCB, but can work without > Capsule-In-RAM support. >=20 >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao B Zhang >=20 > xuwei6 (7): > MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi > definition. > MdeModulePkg: Add Capsule On Disk related definition. > MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM. > MdeModulePkg/BdsDxe: Support Capsule On Disk. > MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to > control this feature. > MdeModulePkg/DxeIpl: Support Capsule On Disk. > MdeModulePkg: Add Capsule On Disk APIs into > CapsuleLib. >=20 > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | > 3 +- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | > 20 +- > MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | > 37 +- > MdeModulePkg/Include/Library/CapsuleLib.h | > 94 +- > MdeModulePkg/Include/Ppi/CapsuleOnDisk.h | > 48 + > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.c | > 1983 ++++++++++++++++++++ > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.h | > 63 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | > 56 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | > 21 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | > 121 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | > 67 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | > 3 +- > .../Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c | > 85 +- > MdeModulePkg/MdeModulePkg.dec | > 43 + > MdeModulePkg/MdeModulePkg.dsc | > 4 + > MdeModulePkg/MdeModulePkg.uni | > 32 + > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | > 3 +- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | > 6 +- > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c | > 442 +++++ > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.inf | > 64 + > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.uni | > 15 + > .../CapsuleOnDiskLoadPeiExtra.uni | > 14 + > .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | > 1 + > .../Universal/CapsuleRuntimeDxe/CapsuleService.c | > 10 +- > MdePkg/Include/Ppi/BootInRecoveryMode.h | > 9 +- > MdePkg/MdePkg.dec | > 3 + > 26 files changed, 3205 insertions(+), 42 deletions(-) > create mode 100644 > MdeModulePkg/Include/Ppi/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDis > kLoadPei.c > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDis > kLoadPei.inf > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDis > kLoadPei.uni > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDis > kLoadPeiExtra.uni >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20 >=20 >=20 > Please consider the environment before printing this > email. >=20 > The information contained in this message may be > confidential and proprietary to American Megatrends, > Inc. This communication is intended to be read only by > the individual or entity to whom it is addressed or by > their designee. If the reader of this message is not the > intended recipient, you are on notice that any > distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply > e-mail or by telephone at 770-246-8600, and then delete > or destroy all copies of the transmission.