From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.d.kinney@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 02 Jul 2019 14:11:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 14:11:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,444,1557212400"; d="scan'208";a="315365828" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 02 Jul 2019 14:11:07 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.59]) by ORSMSX106.amr.corp.intel.com ([169.254.1.191]) with mapi id 14.03.0439.000; Tue, 2 Jul 2019 14:11:07 -0700 From: "Michael D Kinney" To: Gary Lin , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Qian, Yi" , "Sun, Zailiang" Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Topic: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Index: AQHVL7iIF4YKXGSvk0uULlqtea8RuKa1mg8AgADJVxCAASkWAIAAAA4QgABHQ+A= Date: Tue, 2 Jul 2019 21:11:06 +0000 Message-ID: References: <20190701025553.18596-1-michael.d.kinney@intel.com> <20190701040230.GA23179@GaryWorkstation> <20190702094812.GA32340@GaryWorkstation> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary, I have posted an update to your patches the removes the setting of WORKSPA= CE and accesses all files relative to WORKSPACE in the Linux shell scripts. It also fixes null pointer bugs in the SmbiosMiscDxe module. https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smb= ios_Fixes With these changes I can boot to the UEFI Shell and to Linux. Please veri= fy from your environments. I see you have added the SDMMC modules, but I do not see that peripheral y= et. That feature looks like it needs some more debug. We may need to back out= those changes for now. I agree there are ASL issues. The ASL code needs to be updated to the=20 latest ASL compiler. Thanks, Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, July 2, 2019 9:50 AM > To: Gary Lin ; devel@edk2.groups.io; > Kinney, Michael D > Cc: Qian, Yi ; Sun, Zailiang > > Subject: RE: [edk2-devel] [edk2-platforms Patch 00/14] > Vlv2TbltDevicePkg: Remove Intel Framework dependencies >=20 > Hi Gary, >=20 > Thanks for the branch. I have the build working and have > reproduced the SMBIOS issue and am debugging that now. >=20 > Mike >=20 > > -----Original Message----- > > From: Gary Lin [mailto:GLin@suse.com] > > Sent: Tuesday, July 2, 2019 2:48 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] > > Vlv2TbltDevicePkg: Remove Intel Framework dependencies > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000, Michael D > Kinney wrote: > > > Hi Gary, > > > > > > I recommend you rebase on top of this series. > > > > > > I have verified Linux boots and I have been working > on > > the GCC and > > > Linux build scripts as well. > > > > > > Please let me know if you see any issues with this > > series applied and > > > I can help get them fixed. > > > > > Hi Mike, > > > > I'm rebasing my patches and they are available in my > > branch: > > > > https://github.com/lcp/edk2-platforms/commits/vlv2- > > fixes-wip > > > > It's based on > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e) > > and edk2-non- > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f). > > > > There are 3 problems I currently encountered, and maybe > you can give > > me some suggestions. > > > > 1. Missing DSDT > > > > When compiling DSDT, iasl failed with this error: > > > > DSDT.iiii 6077: > > Or(ShiftLeft(Derefof(Index(CDCT, > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM) > > Error 6163 - > > ^ Object is created temporarily in another method and > cannot be > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE) > > > > The code is from > > > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB > > DA.ASL > > > > I have to comment out the line or iasl won't generate > the aml file and > > the OS would fail to get DSDT. > > > > My acpica version is 20190509, and I vaguely remember > that the older > > acpica seems to be more tolerant to this error. > > > > 2. Crash at SMBIOS driver > > > > When booting the system, I got the following error: > > > > Loading driver at 0x00078DBA000 > EntryPoint=3D0x00078DBEC3C > > MiscSubclass.efi > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920- > 2D3B36D750DF > > 78FE8D18 ProtectUefiImageCommon - > > 0x78FE8040 > > - 0x0000000078DBA000 - 0x0000000000007B80 > > PlatformInfoHob->BoardId [0xB0] > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01 > 01/01/2019 > > 00:00 > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 32- > bit table > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 64- > bit table > > SmbiosCreateTable: Initialize 32-bit entry point > structure > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table > > SmbiosCreateTable: Initialize 64-bit entry point > structure > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit > table Create Smbios > > Manu callback. > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode) CPU > Apic ID - > > 00000000 !!!! > > RIP - 0000000078DBEC26, CS - 0000000000000038, RFLAGS > > - 0000000000010206 RAX - 0000000000000000, RCX - > 000000007984A5A0, > > RDX - 000000007A46E5FF RBX - 000000007A46E920, RSP - > > 000000007A46E8B0, RBP - > > 0000000078DC0EC0 RSI - 0000000000000012, RDI - > > 0000000000000003 > > R8 - 800000000000000E, R9 - 000000007A46E920, R10 - > > 0000000078FE8398 > > R11 - 0000000000000001, R12 - 0000000078FE8798, R13 - > > 0000000078FE8898 > > R14 - 0000000078FE8818, R15 - 000000007A46EC60 > > DS - 0000000000000030, ES - 0000000000000030, FS - > > 0000000000000030 > > GS - 0000000000000030, SS - 0000000000000030 > > CR0 - 0000000080010013, CR2 - 0000000000000000, CR3 - > > 000000007A201000 > > CR4 - 0000000000000628, CR8 - 0000000000000000 > > DR0 - 0000000000000000, DR1 - 0000000000000000, DR2 - > > 0000000000000000 > > DR3 - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 - > > 0000000000000400 GDTR - 0000000079FFDA98 > 0000000000000047, LDTR - > > 0000000000000000 > > IDTR - 0000000079862018 0000000000000FFF, TR - > > 0000000000000000 > > FXSAVE_STATE - 000000007A46E510 > > !!!! Find image based on IP(0x78DBEC26) > > /home/gary/git/edk2- > > > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl > > > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas > > s. > > dll (ImageBase=3D0000000078DBA000, > > EntryPoint=3D0000000078DBEC3C) !!!! > > > > I disaseembled MiscSubclass.debug and found that the > address is a > > "ud2" > > instruction at > > > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa > > seBoardManufacturer() > > > > After adding a few more debug messages, the system > crashed at another > > function: > > > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios > > ManuCallback() > > > > If I added debug messages to both functions, the system > booted > > successfully. I currently didn't have any clue on this. > > > > 3. The firmware always booted into EFI shell. > > > > I guess something went wrong with BDS. I haven't looked > into this > > issue yet. > > > > Thanks, > > > > Gary Lin > > > > > Thanks, > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Gary Lin [mailto:GLin@suse.com] > > > > Sent: Sunday, June 30, 2019 9:04 PM > > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch > > 00/14] > > > > Vlv2TbltDevicePkg: Remove Intel Framework > > dependencies > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700, Michael > D > > Kinney wrote: > > > > > The following changes remove all dependencies on > > the > > > > IntelFrameworkPkg > > > > > and IntelFrameworkModulePkg from the > > Vlv2TbltDevicePkg > > > > platform > > > > > builds. These changes do depend on updates > > binaries > > > > on the edk2-non-osi repository. > > > > > > > > > Hi Michael, > > > > > > > > I am amending the bash scripts for gcc. The > firmware > > I built is > > > > using the binaries from Development190216 and could > > boot into Linux > > > > successfully with some workarounds for Wpce791, > Bds, > > and > > > > InteFspWrapper. The patches you posted eliminate > > those parts I have > > > > to work around. > > > > > > > > Just want to know if you need any assistance for > the > > gcc build? I > > > > could rebase my work upon your patches and send > them > > later. > > > > > > > > Thanks, > > > > > > > > Gary Lin > > > > > > >=20 > > > > > >