From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: michael.d.kinney@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 10 Jul 2019 10:08:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 10:08:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,475,1557212400"; d="scan'208";a="317423008" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga004.jf.intel.com with ESMTP; 10 Jul 2019 10:08:34 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 10:08:34 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.128]) by ORSMSX161.amr.corp.intel.com ([169.254.4.246]) with mapi id 14.03.0439.000; Wed, 10 Jul 2019 10:08:33 -0700 From: "Michael D Kinney" To: Leif Lindholm , "Wang, Jian J" , "Kinney, Michael D" CC: "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Thread-Topic: [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Thread-Index: AQHVNyt7QbIMXqjtfUygGv1SZoonz6bEFVeg Date: Wed, 10 Jul 2019 17:08:32 +0000 Message-ID: References: <20190710060955.7672-1-jian.j.wang@intel.com> <20190710060955.7672-2-jian.j.wang@intel.com> <20190710142629.aomcdzwvapo34k6c@bivouac.eciton.net> In-Reply-To: <20190710142629.aomcdzwvapo34k6c@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, I think the following command has to be run from the git dir that the edk2 repo was cloned into. =09 $ git submodule update --init So I think the correct instructions would be: $ git clone https://github.com/tianocore/edk2.git $ cd edk2 $ git submodule update --init $ cd .. Mike > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, July 10, 2019 7:27 AM > To: Wang, Jian J > Cc: devel@edk2.groups.io; Kinney, Michael D > ; Gao, Liming > > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > policy and clone commands >=20 > On Wed, Jul 10, 2019 at 02:09:54PM +0800, Jian J Wang > wrote: > > > v2: update wording per Leif's and others' comments >=20 > Please drop the above line - version comments can go > below the --- line, so they don't get included in the > commit message. >=20 > With that: > Reviewed-by: Leif Lindholm >=20 > (although Liming had some further feedback) >=20 > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1910 > > > > A section 'Submodules' is added to clarify the > submodule policy in > > edk2 repo. Git commands are also added to show the > correct way to > > clone submodule repos, in which '--recursive' is > removed because it's > > not needed but recommended in other document. > > > > Related commits: > > Openssl-1.1.1b upgrade: > acfb90911840c38a0beb9bcfe0065668244d2b4d > > berkeley-softfloat-3: > 3cc57695df5a6e8c65fb46b993836c315cabf49d > > > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Jian J Wang > > --- > > Readme.md | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/Readme.md b/Readme.md > > index e564c6c09b..c475468655 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -143,3 +143,31 @@ Signed-off-by: Contributor Name > > > the change. Each line should be less than ~70 > characters. > > * `Signed-off-by` is the contributor's signature > identifying them > > by their real/legal name and their email address. > > + > > +# Submodules > > + > > +As a general policy, submodule chain should be avoided > in EDK II repo > > +as possible as we can. Currently EDK II contains two > submodules > > + > > +- CryptoPkg/Library/OpensslLib/openssl > > +- ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > > + > > +The latter one is actually required by previous one. > It's inevitable > > +in openssl-1.1.1 (since stable201905) for floating > point parameter > > +conversion, but should be dropped once there's no such > need in future > > +release of openssl. > > + > > +To get a full, buildable EDK II repository, use > following two steps > > +of git command > > + > > +``` > > +$ git clone https://github.com/tianocore/edk2.git > > +$ git submodule update --init> > +``` > > + > > +Note: When cloning submodule repos, '--recursive' > option is not > > +recommended. EDK II itself will not use any > code/feature from > > +submodules in above submodules. So using '--recursive' > adds a > > +dependency on being able to reach servers we do not > actually want any > > +code from, as well as needlessly downloading code we > will not use. > > -- > > 2.17.1.windows.2 > >