From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.d.kinney@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Fri, 12 Jul 2019 17:18:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2019 17:18:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,484,1557212400"; d="scan'208";a="168448483" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga007.fm.intel.com with ESMTP; 12 Jul 2019 17:18:20 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 12 Jul 2019 17:18:19 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.128]) by ORSMSX160.amr.corp.intel.com ([169.254.13.251]) with mapi id 14.03.0439.000; Fri, 12 Jul 2019 17:18:19 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Kinney, Michael D" , "Kinney, Michael D" CC: "Sun, Zailiang" , "Qian, Yi" , Gary Lin Subject: Re: [edk2-devel] [edk2-platforms Patch 00/28] Vlv2TbltDevicePkg: Fix Linux build issues Thread-Topic: [edk2-devel] [edk2-platforms Patch 00/28] Vlv2TbltDevicePkg: Fix Linux build issues Thread-Index: AQHVN1Jz14UKTYe5L0uzLkUosA8evKbHsg8w Date: Sat, 13 Jul 2019 00:18:18 +0000 Message-ID: References: <20190710190516.6012-1-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For all patches in this series authored by Gary Lin Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Michael D Kinney > Sent: Wednesday, July 10, 2019 12:05 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > ; Gary Lin > Subject: [edk2-devel] [edk2-platforms Patch 00/28] > Vlv2TbltDevicePkg: Fix Linux build issues >=20 > * Update Readme.md for multiple repos > * Clean up all build scripts and make Linux and Windows > support consistent > * Add IA32 GCC build support and only build capsules for > X64 > * Clean up library mappings, add TlsLib for HTTPS Boot, > and add SD/MMC drivers. > * Re-enable BIOS ID feature using new GenBiosId.py tool > * Remove redundant declarations from DEC file and remove > unused content > * Add missing header files in [Sources] sections of INF > files. > * Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL build > error using newer iasl. > * Vlvt2TbltDevicePkg: Fix NULL pointer access in > SmbiosMiscDxe > * Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from > InstallAcpiTable and > remove unused local variable. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Signed-off-by: Michael D Kinney > > Signed-off-by: Gary Lin >=20 > Gary Lin (18): > Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit > on error > Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root > directory path > Vlv2TbltDevicePkg/bld_vlv.sh: Fix the log name > Vlv2TbltDevicePkg/bld_vlv.sh: Update the gcc version > detection > Vlv2TbltDevicePkg/bld_vlv.sh: Remove ECP completely > Vlv2TbltDevicePkg/bld_vlv.sh: Update the script to fit > edk2-platforms > Vlv2TbltDevicePkg: Add the missing headers to inf files > Vlv2TbltDevicePkg/bld_vlv.sh: Remove BiosId.env > completely > Vlv2TbltDevicePkg/bld_vlv.sh: Correct the path to > PlatformCapsuleGcc.dsc > Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM > Vlv2TbltDevicePkg/GenerateCapsule: Fix the bash scripts > Vlv2TbltDevicePkg/AcpiPlatform: Remove a unused > variable > Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from > InstallAcpiTable > Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation > Vlv2TbltDevicePkg: Import SD/MMC drivers > Vlv2TbltDevicePkg/Build_IFWI.sh: Check the WORKSPACE > env variable > Vlv2TbltDevicePkg: Import TlsLib for HTTPS Boot > Vlv2TbltDevicePkg: Reorganize the libraries >=20 > Michael D Kinney (10): > Vlv2TbltDevicePkg: Update Linux build scripts > Vlvt2TbltDevicePkg: Fix NULL pointer access in > SmbiosMiscDxe > Vlv2DeviceRefCodePkg: Remove redundant > gEfiSpiProtocolGuid > Vlv2TbltDevicePkg: Remove redundant gEfiSpiProtocolGuid > Vlv2TbltDevicePkg: Re-enable BIOS ID feature > Vlv2TbltDevicePkg: Add GCC IA32 build support > Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error > Vlv2TbltDevicePkg: Clean up all build scripts > Vlv2TbltDevicePkg: Only build capsules for X64 > Vlv2TbltDevicePkg: Update Readme.md for multiple repos >=20 > Platform/Intel/Vlv2TbltDevicePkg/.gitignore | 5 - > .../AcpiPlatform/AcpiPlatform.c | 5 +- > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 75 +--- > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 76 ++-- > .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 37 +- > .../GenerateCapsule/GenCapsuleMinnowMax.sh | 24 +- > .../GenCapsuleMinnowMaxRelease.sh | 19 +- > .../Include/Guid/PlatformCpuInfo.h | 16 +- > .../Include/Library/BiosIdLib.h | 86 ---- > - > .../Include/Library/CpuIA32.h | 345 ---- > -------------- > .../Include/PlatformDefinitions.h | 43 --- > .../Library/BiosIdLib/BiosIdLib.c | 98 ---- > - > .../Library/BiosIdLib/BiosIdLib.inf | 33 -- > .../Library/CpuIA32Lib/CpuIA32Lib.inf | 41 --- > .../Library/CpuIA32Lib/EfiCpuVersion.c | 70 ---- > .../Library/CpuIA32Lib/IA32/CpuIA32.S | 223 ---- > ------- > .../Library/CpuIA32Lib/IA32/CpuIA32.asm | 206 ---- > ------- > .../Library/CpuIA32Lib/IA32/CpuIA32.c | 177 ---- > ----- > .../Library/CpuIA32Lib/X64/Cpu.S | 207 ---- > ------- > .../Library/CpuIA32Lib/X64/Cpu.asm | 222 ---- > ------- > .../Library/FlashDeviceLib/FlashDeviceLib.inf | 2 +- > .../Library/PchSmmLib/PchSmmLib.inf | 8 +- > .../MonoStatusCode/MonoStatusCode.inf | 2 +- > .../PlatformDxe/PlatformDxe.inf | 5 +- > .../PlatformInitPei/MemoryCallback.c | 11 +- > .../PlatformInitPei/PlatformEarlyInit.h | 4 +- > .../PlatformInitPei/PlatformInitPei.inf | 1 - > .../PlatformPei/PlatformPei.inf | 1 - > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 1 - > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 14 + > .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc | 2 - > .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 14 + > ...formPkgIA32.dsc =3D> PlatformPkgGccIA32.dsc} | 122 ++-- > --- > .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 112 ++-- > -- > .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 109 ++-- > -- > .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 113 ++-- > -- > .../PlatformSetupDxe/PlatformSetupDxe.h | 1 - > .../PlatformSetupDxe/PlatformSetupDxe.inf | 5 +- > .../PlatformSetupDxe/SetupInfoRecords.c | 42 ++- > .../Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c | 12 +- > .../Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf | 1 + > Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 145 > ++++---- > .../MiscBaseBoardManufacturerFunction.c | 14 +- > .../SmBiosMiscDxe/MiscBiosVendorFunction.c | 49 +-- > .../SmBiosMiscDxe/MiscOemType0x90Function.c | 37 +- > .../SmBiosMiscDxe/MiscOemType0x94Function.c | 10 +- > .../MiscProcessorInformationFunction.c | 3 +- > .../MiscSystemManufacturerFunction.c | 65 ++-- > .../SmBiosMiscDxe/SmBiosMiscDxe.inf | 9 +- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 151 > ++++---- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 251 > +++++++------ > Platform/Intel/Vlv2TbltDevicePkg/cln.sh | 62 ---- > .../AcpiTablesPCAT/IgdOGBDA.ASL | 14 +- > .../AcpiTablesPCAT/IgdOpRn.ASL | 18 +- > .../Vlv2DeviceRefCodePkg.dec | 1 - > 55 files changed, 670 insertions(+), 2749 deletions(-) > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/.gitignore > mode change 100644 =3D> 100755 > Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh > mode change 100644 =3D> 100755 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generate > Capsule/GenCapsuleAll.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Include/Library/BiosIdLi > b.h > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Include/Library/CpuIA32. > h > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Include/PlatformDefiniti > ons.h > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/BiosIdLib/BiosId > Lib.c > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/BiosIdLib/BiosId > Lib.inf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/CpuIA > 32Lib.inf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/EfiCp > uVersion.c > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/IA32/ > CpuIA32.S > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/IA32/ > CpuIA32.asm > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/IA32/ > CpuIA32.c > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/X64/C > pu.S > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Library/CpuIA32Lib/X64/C > pu.asm > copy > Platform/Intel/Vlv2TbltDevicePkg/{PlatformPkgIA32.dsc =3D> > PlatformPkgGccIA32.dsc} (91%) mode change 100644 =3D> > 100755 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/cln.sh >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20