From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Gary Lin <glin@suse.com>, "Qian, Yi" <yi.qian@intel.com>,
"Sun, Zailiang" <zailiang.sun@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences
Date: Thu, 18 Jul 2019 23:03:47 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D78B8C@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20190718230017.14852-1-michael.d.kinney@intel.com>
I have also posted a branch with these changes for review at:
https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Remove_FCE_BAT_sh
Mike
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Michael D Kinney
> Sent: Thursday, July 18, 2019 4:00 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms Patch 0/5]
> Vlv2Tbl2DevicePkg: Remove Linux/Windows differences
>
> Remove all BAT/sh scripts and use OS independent python
> scripts for PREBULD and POSTBUILD operations and use
> standard EDK II build command to build MinnowMax FW
> images and capsules.
>
> The use of FCE has also been removed and replaced with a
> Structured PCD. The default values for Setup forms are
> now in the file PlatformSetupDefaults.dsc.
>
> A regression bug introduced by a recent commit that
> broke the detection of the BOOT_ON_FLASH_UPDATE boot
> mode has also been fixed. Capsules are detected and
> processed correctly again.
>
> Michael D Kinney (5):
> Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection
> Vlv2TbltDevicePkg: Convert use of FCE tool to
> Structured PCD
> Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF
> files
> Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to
> Python
> Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to
> Python
>
> Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe | Bin
> 499712 -> 0 bytes
> .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 118 --
> .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 100 --
> Platform/Intel/Vlv2TbltDevicePkg/FCE.exe | Bin
> 632832 -> 0 bytes
> .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 -
> .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397
> +++++
> .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 33 -
> .../GenerateCapsule/GenCapsuleMinnowMax.bat | 131 --
> .../GenerateCapsule/GenCapsuleMinnowMax.sh | 59 -
> .../GenCapsuleMinnowMaxRelease.bat | 131 --
> .../GenCapsuleMinnowMaxRelease.sh | 64 -
> .../GenerateCapsule/GenCapsuleSampleColor.bat | 137 --
> .../GenerateCapsule/GenCapsuleSampleColor.sh | 70 -
> .../Feature/Capsule/GenerateCapsule/Lvfs.ddf | 14 -
> .../LvfsGenCapsuleMinnowMax.bat | 139 --
> .../LvfsGenCapsuleMinnowMaxRelease.bat | 139 --
> .../LvfsGenCapsuleSampleColor.bat | 145 --
> .../GenerateCapsule/template.metainfo.xml | 27 -
> .../SystemFirmwareDescriptor.aslc | 83 --
> .../SystemFirmwareDescriptor.inf | 40 -
> .../SystemFirmwareDescriptorPei.c | 60 -
> .../SystemFirmwareUpdateConfig.ini | 66 -
> .../SystemFirmwareUpdateConfigGcc.ini | 66 -
> .../Vlv2TbltDevicePkg/PlatformCapsule.dsc | 39 -
> .../Vlv2TbltDevicePkg/PlatformCapsule.fdf | 52 -
> .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc | 38 -
> .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf | 52 -
> .../PlatformInitPei/PlatformEarlyInit.c | 40 +-
> .../PlatformInitPei/PlatformInitPei.inf | 2 +
> .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 92 +-
> .../Vlv2TbltDevicePkg/PlatformPei/Platform.c | 6 +
> .../Vlv2TbltDevicePkg/PlatformPei/Platform.h | 17 +
> .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 12 +
> .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 52 +-
> .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 914 --
> ----------
> .../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 1272 --
> --------------
> .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1289 --
> ---------------
> .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 91 +-
> .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 89 +-
> .../PlatformSetupDefaults.dsc | 130 ++
> .../PlatformSetupDxe/PlatformSetupDxe.c | 12 +-
> .../PlatformSetupDxe/Vfr.vfr | 17 +-
> Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 348
> +++++
> Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 62 +-
> .../Stitch/Gcc/NvStorageFtwSpare.bin | Bin
> 262144 -> 0 bytes
> .../Stitch/Gcc/NvStorageFtwWorking.bin | Bin
> 8192 -> 0 bytes
> .../Stitch/Gcc/NvStorageVariable.bin | Bin
> 253952 -> 0 bytes
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 322 --
> --
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 235 --
> -
> 49 files changed, 1231 insertions(+), 6006 deletions(-)
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.bat
> delete mode 100755
> Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/FCE.exe
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleAll.bat
> create mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleAll.py
> delete mode 100755
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleAll.sh
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleMinnowMax.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleMinnowMax.sh
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleMinnowMaxRelease.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleMinnowMaxRelease.sh
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleSampleColor.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/GenCapsuleSampleColor.sh
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/Lvfs.ddf
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/LvfsGenCapsuleMinnowMax.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/LvfsGenCapsuleMinnowMaxRelease.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/LvfsGenCapsuleSampleColor.bat
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat
> eCapsule/template.metainfo.xml
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF
> irmwareDescriptor/SystemFirmwareDescriptor.aslc
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF
> irmwareDescriptor/SystemFirmwareDescriptor.inf
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF
> irmwareDescriptor/SystemFirmwareDescriptorPei.c
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF
> irmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF
> irmwareUpdateConfig/SystemFirmwareUpdateConfigGcc.ini
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.dsc
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.fdf
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> create mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDefaults.d
> sc
> create mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtw
> Spare.bin
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtw
> Working.bin
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageVar
> iable.bin
> delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat
> delete mode 100755
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
>
> --
> 2.21.0.windows.1
>
>
>
prev parent reply other threads:[~2019-07-18 23:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 23:00 [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Michael D Kinney
2019-07-18 23:00 ` [edk2-platforms Patch 1/5] Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection Michael D Kinney
2019-07-19 3:18 ` [edk2-devel] " Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Michael D Kinney
2019-07-19 3:18 ` [edk2-devel] " Sun, Zailiang
2019-07-19 3:40 ` Liming Gao
2019-07-19 6:04 ` Michael D Kinney
2019-07-19 6:40 ` Liming Gao
2019-07-19 15:50 ` Michael D Kinney
2019-07-20 15:11 ` Liming Gao
2019-07-18 23:00 ` [edk2-platforms Patch 3/5] Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files Michael D Kinney
2019-07-19 3:19 ` Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 4/5] Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python Michael D Kinney
2019-07-19 3:19 ` [edk2-devel] " Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 5/5] Vlv2Tbl2DevicePkg: Convert BAT/sh Build " Michael D Kinney
2019-07-18 23:03 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9D78B8C@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox