From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: michael.d.kinney@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 18 Jul 2019 16:03:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 16:03:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,279,1559545200"; d="scan'208";a="169997445" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga007.fm.intel.com with ESMTP; 18 Jul 2019 16:03:48 -0700 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 16:03:48 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.128]) by ORSMSX126.amr.corp.intel.com ([169.254.4.77]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 16:03:48 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Kinney, Michael D" , Gary Lin , "Qian, Yi" , "Sun, Zailiang" Subject: Re: [edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Topic: [edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Index: AQHVPbyU4vNX0L7VK0yIE6KL+o5VpKbQ/k7g Date: Thu, 18 Jul 2019 23:03:47 +0000 Message-ID: References: <20190718230017.14852-1-michael.d.kinney@intel.com> In-Reply-To: <20190718230017.14852-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have also posted a branch with these changes for review at: https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Remove_FCE_BA= T_sh Mike > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Michael D Kinney > Sent: Thursday, July 18, 2019 4:00 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms Patch 0/5] > Vlv2Tbl2DevicePkg: Remove Linux/Windows differences >=20 > Remove all BAT/sh scripts and use OS independent python > scripts for PREBULD and POSTBUILD operations and use > standard EDK II build command to build MinnowMax FW > images and capsules. >=20 > The use of FCE has also been removed and replaced with a > Structured PCD. The default values for Setup forms are > now in the file PlatformSetupDefaults.dsc. >=20 > A regression bug introduced by a recent commit that > broke the detection of the BOOT_ON_FLASH_UPDATE boot > mode has also been fixed. Capsules are detected and > processed correctly again. >=20 > Michael D Kinney (5): > Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection > Vlv2TbltDevicePkg: Convert use of FCE tool to > Structured PCD > Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF > files > Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to > Python > Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to > Python >=20 > Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe | Bin > 499712 -> 0 bytes > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 118 -- > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 100 -- > Platform/Intel/Vlv2TbltDevicePkg/FCE.exe | Bin > 632832 -> 0 bytes > .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 - > .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397 > +++++ > .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 33 - > .../GenerateCapsule/GenCapsuleMinnowMax.bat | 131 -- > .../GenerateCapsule/GenCapsuleMinnowMax.sh | 59 - > .../GenCapsuleMinnowMaxRelease.bat | 131 -- > .../GenCapsuleMinnowMaxRelease.sh | 64 - > .../GenerateCapsule/GenCapsuleSampleColor.bat | 137 -- > .../GenerateCapsule/GenCapsuleSampleColor.sh | 70 - > .../Feature/Capsule/GenerateCapsule/Lvfs.ddf | 14 - > .../LvfsGenCapsuleMinnowMax.bat | 139 -- > .../LvfsGenCapsuleMinnowMaxRelease.bat | 139 -- > .../LvfsGenCapsuleSampleColor.bat | 145 -- > .../GenerateCapsule/template.metainfo.xml | 27 - > .../SystemFirmwareDescriptor.aslc | 83 -- > .../SystemFirmwareDescriptor.inf | 40 - > .../SystemFirmwareDescriptorPei.c | 60 - > .../SystemFirmwareUpdateConfig.ini | 66 - > .../SystemFirmwareUpdateConfigGcc.ini | 66 - > .../Vlv2TbltDevicePkg/PlatformCapsule.dsc | 39 - > .../Vlv2TbltDevicePkg/PlatformCapsule.fdf | 52 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc | 38 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf | 52 - > .../PlatformInitPei/PlatformEarlyInit.c | 40 +- > .../PlatformInitPei/PlatformInitPei.inf | 2 + > .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 92 +- > .../Vlv2TbltDevicePkg/PlatformPei/Platform.c | 6 + > .../Vlv2TbltDevicePkg/PlatformPei/Platform.h | 17 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 12 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 52 +- > .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 914 -- > ---------- > .../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 1272 -- > -------------- > .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1289 -- > --------------- > .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 91 +- > .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 89 +- > .../PlatformSetupDefaults.dsc | 130 ++ > .../PlatformSetupDxe/PlatformSetupDxe.c | 12 +- > .../PlatformSetupDxe/Vfr.vfr | 17 +- > Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 348 > +++++ > Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 62 +- > .../Stitch/Gcc/NvStorageFtwSpare.bin | Bin > 262144 -> 0 bytes > .../Stitch/Gcc/NvStorageFtwWorking.bin | Bin > 8192 -> 0 bytes > .../Stitch/Gcc/NvStorageVariable.bin | Bin > 253952 -> 0 bytes > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 322 -- > -- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 235 -- > - > 49 files changed, 1231 insertions(+), 6006 deletions(-) > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.bat > delete mode 100755 > Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/FCE.exe > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleAll.bat > create mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleAll.py > delete mode 100755 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleAll.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleMinnowMax.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleMinnowMax.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleMinnowMaxRelease.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleMinnowMaxRelease.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleSampleColor.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/GenCapsuleSampleColor.sh > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/Lvfs.ddf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/LvfsGenCapsuleMinnowMax.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/LvfsGenCapsuleMinnowMaxRelease.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/LvfsGenCapsuleSampleColor.bat > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Generat > eCapsule/template.metainfo.xml > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF > irmwareDescriptor/SystemFirmwareDescriptor.aslc > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF > irmwareDescriptor/SystemFirmwareDescriptor.inf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF > irmwareDescriptor/SystemFirmwareDescriptorPei.c > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF > irmwareUpdateConfig/SystemFirmwareUpdateConfig.ini > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemF > irmwareUpdateConfig/SystemFirmwareUpdateConfigGcc.ini > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.dsc > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.fdf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > create mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDefaults.d > sc > create mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtw > Spare.bin > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtw > Working.bin > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageVar > iable.bin > delete mode 100644 > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat > delete mode 100755 > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20