From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.d.kinney@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Fri, 19 Jul 2019 08:50:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 08:50:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,283,1559545200"; d="scan'208";a="195986330" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2019 08:50:35 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jul 2019 08:50:34 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.128]) by ORSMSX162.amr.corp.intel.com ([169.254.3.137]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 08:50:34 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Sun, Zailiang" , "Qian, Yi" , Gary Lin Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Topic: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Index: AQHVPbybigjOgQkBiUmv83kbgdTWFqbRwVGA//+yjmCAAH+8AIAAI6pQ Date: Fri, 19 Jul 2019 15:50:33 +0000 Message-ID: References: <20190718230017.14852-1-michael.d.kinney@intel.com> <20190718230017.14852-3-michael.d.kinney@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC38E@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, That wiki page does not explain that values are inherited from STANDARD settings. It only shows=20 an example use of multiple default stores. Mike > -----Original Message----- > From: Gao, Liming > Sent: Thursday, July 18, 2019 11:41 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Sun, Zailiang ; Qian, Yi > ; Gary Lin > Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > Vlv2TbltDevicePkg: Convert use of FCE tool to Structured > PCD >=20 > Mike: > Yes. Wiki > https://github.com/lgao4/edk2/wiki/StructurePcd-Enable- > Steps shows the usage of the different default store. >=20 > >-----Original Message----- > >From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > >Michael D Kinney > >Sent: Friday, July 19, 2019 2:05 PM > >To: Gao, Liming ; > devel@edk2.groups.io; Kinney, > >Michael D > >Cc: Sun, Zailiang ; Qian, Yi > >; Gary Lin > >Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] > Vlv2TbltDevicePkg: > >Convert use of FCE tool to Structured PCD > > > >Liming, > > > >Thanks for the feedback. I have made both changes in > the V2 version of > >the series. > > > >We should show some examples of inheriting defaults > from STANDARD > >defaults. > > > >Mike > > > >> -----Original Message----- > >> From: Gao, Liming > >> Sent: Thursday, July 18, 2019 8:41 PM > >> To: devel@edk2.groups.io; Kinney, Michael D > >> > >> Cc: Sun, Zailiang ; Qian, Yi > >> ; Gary Lin > >> Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > >> Vlv2TbltDevicePkg: Convert use of FCE tool to > Structured PCD > >> > >> Mike: > >> I have two comments here. > >> 1. VarStore is updated to EfiVarStore. So, > HiiConfigAccess > >> ExtractConfig() and RouteConfig() can be updated to > directly return > >> UNSUPPORTED, they are not used any more. > >> 2. DSC doesn't need to include > PlatformSetupDefaults.dsc twice. By > >> default, MANUFACTURING setting will be inherited from > STANDARD. Only > >> different default setting is required to be > specified. For your case, > >> MANUFACTURING default is same to STANDARD. So, you > only need to > >> include the default setting for STANDARD only. > >> > >> [PcdsDynamicExHii.common.DEFAULT.STANDARD] > >> !include > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > >> > >> [PcdsDynamicExHii.common.DEFAULT.MANUFACTURING] # > can be removed. > >> !include > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > >> # can be removed. > >> > >> Thanks > >> Liming