From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.d.kinney@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Wed, 24 Jul 2019 09:53:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 09:53:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,303,1559545200"; d="scan'208";a="197562542" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga002.fm.intel.com with ESMTP; 24 Jul 2019 09:53:53 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX103.amr.corp.intel.com ([169.254.5.44]) with mapi id 14.03.0439.000; Wed, 24 Jul 2019 09:53:52 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "rebecca@bsdio.com" , "Justen, Jordan L" , "Laszlo Ersek" , Ard Biesheuvel , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu Thread-Topic: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu Thread-Index: AQHVQcJL0x2XsVZZR0CgCLkuFedZ7KbZ/Fyg Date: Wed, 24 Jul 2019 16:53:51 +0000 Message-ID: References: <20190724015101.13044-1-rebecca@bsdio.com> In-Reply-To: <20190724015101.13044-1-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Rebecca, If you are interested, I prototyped using a python script and POSTBUILD statement in the DSC file to=20 support 'run' targets for OVMF in the following branch. This potentially allows the same code to be used for all host OS environments to launch QEMU. https://github.com/tianocore/edk2-staging/tree/Bug_1525_FmpDevicePkg_Multip= leControllers_V2/OvmfPkg https://github.com/tianocore/edk2-staging/blob/Bug_1525_FmpDevicePkg_Multip= leControllers_V2/OvmfPkg/PostBuild.py https://github.com/tianocore/edk2-staging/blob/Bug_1525_FmpDevicePkg_Multip= leControllers_V2/OvmfPkg/Run.py Could also be extended to support doing either QEMU or KVM launch with a -D flag. Mike > -----Original Message----- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > rebecca@bsdio.com > Sent: Tuesday, July 23, 2019 6:51 PM > To: devel@edk2.groups.io; Justen, Jordan L > ; Laszlo Ersek > ; Ard Biesheuvel > > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use > newer '-drive if=3Dpflash' syntax when running qemu >=20 > Specify the firmware to use via the newer '-drive > if=3Dpflash' syntax which allows specifying the raw > format and readonly parameters. This avoids warnings > with newer version of QEMU. >=20 > Signed-off-by: Rebecca Cran > --- > OvmfPkg/build.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index > a2c4eff2a5..e2890ff762 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then > fi > ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin > if [[ "$ENABLE_FLASH" =3D=3D "yes" ]]; then > - QEMU_COMMAND=3D"$QEMU_COMMAND -pflash > $QEMU_FIRMWARE_DIR/bios.bin" > + QEMU_COMMAND=3D"$QEMU_COMMAND -drive > if=3Dpflash,format=3Draw,readonly,file=3D$QEMU_FIRMWARE_DIR/b > ios.bin" > else > QEMU_COMMAND=3D"$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR" > fi > -- > 2.22.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this > group. >=20 > View/Reply Online (#44277): > https://edk2.groups.io/g/devel/message/44277 > Mute This Topic: https://groups.io/mt/32580104/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D