From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 30 Jul 2019 09:30:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 09:30:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,327,1559545200"; d="scan'208";a="171972163" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga008.fm.intel.com with ESMTP; 30 Jul 2019 09:30:43 -0700 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 09:30:43 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX126.amr.corp.intel.com ([169.254.4.77]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 09:30:43 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "Ni, Ray" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Topic: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Index: AQHVQga/QoFab8ZmLkeETqPu+YMylabi/0OA//+NixCAAHf4AIAAXmRA Date: Tue, 30 Jul 2019 16:30:42 +0000 Message-ID: References: <20190724100029.252404-1-ray.ni@intel.com> <20190724100029.252404-6-ray.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F55@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4FAC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4FAC@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Yes. That would be the correct include statement for a module/lib that depends on MdePkg. I know we have modules/libs that use the UefiCpuPkg and use #include . If we want to=20 provide compatibility with all consumers of the UefiCpuPkg, the Cpuid.h file in the UefiCpuPkg can updated to simply include from MdePkg. We could also choose to update those consumers to use the new path in the MdePkg. Mike > -----Original Message----- > From: Gao, Liming > Sent: Monday, July 29, 2019 8:49 PM > To: Kinney, Michael D ; Ni, > Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from UefiCpuPkg to MdePkg >=20 > Mike: > OK. If so, the consumer code also need to obviously > include vendor header file, such as #include > . Right? >=20 > Thanks > Liming > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Tuesday, July 30, 2019 11:42 AM > > To: Gao, Liming ; Ni, Ray > ; > > devel@edk2.groups.io; Kinney, Michael D > > > Cc: Dong, Eric ; Laszlo Ersek > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from > > UefiCpuPkg to MdePkg > > > > Liming, > > > > There is an unresolved discussion on the location of > this file in the > > MdePkg. I prefer a vendor name in the path. > > > > MdePkg/Include/Register/Intel/Cpuid.h > > > > Also, after this file is moved to MdePkg, we can > enter new BZs to > > update all the modules that call AsmCpuid and > AsmCpuidEx to use the > > defines and structures from Cpuid.h. > > > > Mike > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Monday, July 29, 2019 8:29 PM > > > To: Ni, Ray ; > devel@edk2.groups.io > > > Cc: Kinney, Michael D ; > Dong, Eric > > > ; Laszlo Ersek > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from > > > UefiCpuPkg to MdePkg > > > > > > The change is good to me. Reviewed-by: Liming Gao > > > > > > > > > > -----Original Message----- > > > > From: Ni, Ray > > > > Sent: Wednesday, July 24, 2019 6:00 PM > > > > To: devel@edk2.groups.io > > > > Cc: Kinney, Michael D > ; > > > Gao, Liming > > > > ; Dong, Eric > > > ; Laszlo Ersek > > > > > > > > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h > > > from UefiCpuPkg > > > > to MdePkg > > > > > > > > REF: > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 > > > > > > > > MdeModulePkg/DxeIpl needs to get CPUID output for > CPU > > > 5-level paging > > > > capability detection. > > > > > > > > In order to use the macros/structures defined in > > > > UefiCpuPkg/Include/Register/Cpuid.h, the patch > moves > > > Cpuid.h to > > > > MdePkg/Include/Register/ directory. > > > > > > > > Because almost every module depends on MdePkg.dec > in > > > its INF file, the > > > > move almost has no impact. > > > > > > > > Signed-off-by: Ray Ni > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Eric Dong > > > > Cc: Laszlo Ersek > > > > --- > > > > {UefiCpuPkg =3D> MdePkg}/Include/Register/Cpuid.h > | 0 > > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > > rename {UefiCpuPkg > > > > =3D> MdePkg}/Include/Register/Cpuid.h (100%) > > > > > > > > diff --git a/UefiCpuPkg/Include/Register/Cpuid.h > > > > b/MdePkg/Include/Register/Cpuid.h similarity > index > > > 100% rename from > > > > UefiCpuPkg/Include/Register/Cpuid.h > > > > rename to MdePkg/Include/Register/Cpuid.h > > > > -- > > > > 2.21.0.windows.1