From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 01 Aug 2019 01:15:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 01:15:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,333,1559545200"; d="scan'208";a="196756654" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga004.fm.intel.com with ESMTP; 01 Aug 2019 01:15:51 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX107.amr.corp.intel.com ([169.254.1.186]) with mapi id 14.03.0439.000; Thu, 1 Aug 2019 01:15:50 -0700 From: "Michael D Kinney" To: "Ni, Ray" , "Gao, Liming" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Topic: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Index: AQHVQga/QoFab8ZmLkeETqPu+YMylabi/0OA//+NixCAAHf4AIAAXmRAgAKvNYD//+uogA== Date: Thu, 1 Aug 2019 08:15:49 +0000 Message-ID: References: <20190724100029.252404-1-ray.ni@intel.com> <20190724100029.252404-6-ray.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F55@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4FAC@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C266D3D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C266D3D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, Yes. I think it makes sense to move both. Please include the contributor of Amd/Cpuid.h to the reviews of that move. It would be good to see as much feedback as possible on this change. Thanks, Mike > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, July 31, 2019 7:27 PM > To: Kinney, Michael D ; > Gao, Liming ; > devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from UefiCpuPkg to MdePkg >=20 > Mike, > Thanks for the time for offline discussion. > I agree with the idea to have an Intel/Cpuid.h in > MdePkg/Include/Register/ directory. >=20 > Do you prefer to move Amd/Cpuid.h to > MdePkg/Include/Register/ in my V3 patch? >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Wednesday, July 31, 2019 12:31 AM > > To: Gao, Liming ; Ni, Ray > ; > > devel@edk2.groups.io; Kinney, Michael D > > > Cc: Dong, Eric ; Laszlo Ersek > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from > > UefiCpuPkg to MdePkg > > > > Liming, > > > > Yes. That would be the correct include statement for > a module/lib > > that depends on MdePkg. > > > > I know we have modules/libs that use the UefiCpuPkg > and use #include > > . If we want to provide > compatibility with all > > consumers of the UefiCpuPkg, the Cpuid.h file in the > UefiCpuPkg can > > updated to simply include > from MdePkg. We > > could also choose to update those consumers to use > the new path in the > > MdePkg. > > > > Mike > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Monday, July 29, 2019 8:49 PM > > > To: Kinney, Michael D ; > Ni, Ray > > > ; devel@edk2.groups.io > > > Cc: Dong, Eric ; Laszlo Ersek > > > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > Cpuid.h from > > > UefiCpuPkg to MdePkg > > > > > > Mike: > > > OK. If so, the consumer code also need to > obviously include vendor > > > header file, such as #include > . Right? > > > > > > Thanks > > > Liming > > > > -----Original Message----- > > > > From: Kinney, Michael D > > > > Sent: Tuesday, July 30, 2019 11:42 AM > > > > To: Gao, Liming ; Ni, Ray > > > ; > > > > devel@edk2.groups.io; Kinney, Michael D > > > > > > > Cc: Dong, Eric ; Laszlo > Ersek > > > > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > > Cpuid.h from > > > > UefiCpuPkg to MdePkg > > > > > > > > Liming, > > > > > > > > There is an unresolved discussion on the location > of > > > this file in the > > > > MdePkg. I prefer a vendor name in the path. > > > > > > > > MdePkg/Include/Register/Intel/Cpuid.h > > > > > > > > Also, after this file is moved to MdePkg, we can > > > enter new BZs to > > > > update all the modules that call AsmCpuid and > > > AsmCpuidEx to use the > > > > defines and structures from Cpuid.h. > > > > > > > > Mike > > > > > > > > > -----Original Message----- > > > > > From: Gao, Liming > > > > > Sent: Monday, July 29, 2019 8:29 PM > > > > > To: Ni, Ray ; > > > devel@edk2.groups.io > > > > > Cc: Kinney, Michael D > ; > > > Dong, Eric > > > > > ; Laszlo Ersek > > > > > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: > Move > > > Cpuid.h from > > > > > UefiCpuPkg to MdePkg > > > > > > > > > > The change is good to me. Reviewed-by: Liming > Gao > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Ni, Ray > > > > > > Sent: Wednesday, July 24, 2019 6:00 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Kinney, Michael D > > > ; > > > > > Gao, Liming > > > > > > ; Dong, Eric > > > > > ; Laszlo Ersek > > > > > > > > > > > > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > > Cpuid.h > > > > > from UefiCpuPkg > > > > > > to MdePkg > > > > > > > > > > > > REF: > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 > > > > > > > > > > > > MdeModulePkg/DxeIpl needs to get CPUID output > for > > > CPU > > > > > 5-level paging > > > > > > capability detection. > > > > > > > > > > > > In order to use the macros/structures defined > in > > > > > > UefiCpuPkg/Include/Register/Cpuid.h, the > patch > > > moves > > > > > Cpuid.h to > > > > > > MdePkg/Include/Register/ directory. > > > > > > > > > > > > Because almost every module depends on > MdePkg.dec > > > in > > > > > its INF file, the > > > > > > move almost has no impact. > > > > > > > > > > > > Signed-off-by: Ray Ni > > > > > > Cc: Michael D Kinney > > > > > > > Cc: Liming Gao > > > > > > Cc: Eric Dong > > > > > > Cc: Laszlo Ersek > > > > > > --- > > > > > > {UefiCpuPkg =3D> > MdePkg}/Include/Register/Cpuid.h > > > | 0 > > > > > > 1 file changed, 0 insertions(+), 0 > deletions(-) > > > > > rename {UefiCpuPkg > > > > > > =3D> MdePkg}/Include/Register/Cpuid.h (100%) > > > > > > > > > > > > diff --git > a/UefiCpuPkg/Include/Register/Cpuid.h > > > > > > b/MdePkg/Include/Register/Cpuid.h similarity > > > index > > > > > 100% rename from > > > > > > UefiCpuPkg/Include/Register/Cpuid.h > > > > > > rename to MdePkg/Include/Register/Cpuid.h > > > > > > -- > > > > > > 2.21.0.windows.1