From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.d.kinney@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Fri, 02 Aug 2019 14:00:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 14:00:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,339,1559545200"; d="scan'208";a="197335832" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga004.fm.intel.com with ESMTP; 02 Aug 2019 14:00:34 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX107.amr.corp.intel.com ([169.254.1.186]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 14:00:34 -0700 From: "Michael D Kinney" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Carsey, Jaben" , "Ni, Ray" , Sami Mujawar Subject: Re: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated Thread-Topic: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated Thread-Index: AQHVSKuI7ULzxt7HMkaOfa2YjmsHZ6bnzD4AgAAlCJA= Date: Fri, 2 Aug 2019 21:00:33 +0000 Message-ID: References: <20190801205541.24792-1-michael.d.kinney@intel.com> <20190801205541.24792-3-michael.d.kinney@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B81E444@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B81E444@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, I did not modify the build of the standard Shell. It does not include the acpiview. The patch builds a 2nd version of the shell with a different FILE_GUID for build testing purposes. I think it is very important for the ShellPkg to have build tests for all the content in the ShellPkg to prevent the build failure I=20 saw when I simply wanted to use the acpiview command on an IA32 system. Thanks, Mike > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, August 1, 2019 10:36 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Carsey, Jaben ; Ni, Ray > ; Sami Mujawar > Subject: RE: [edk2-devel] [Patch v2 2/2] ShellPkg: Add > shell with all commands integrated >=20 > I used to use the shellpkg.dsc to build a shell.efi > binary release. > Full configuration of shell is fine. But the acpiview > is under developing and the shell spec doesn't contain > 'acpiview' yet. > Is it OK to add an additional cmd that the spec isn't > mentioned? >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > > Michael D Kinney > > Sent: Friday, August 2, 2019 4:56 AM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray > > ; Gao, Zhichao > ; Sami Mujawar > > > > Subject: [edk2-devel] [Patch v2 2/2] ShellPkg: Add > shell with all > > commands integrated > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1970 > > > > Update ShellPkg DSC file to build an extra version of > the Shell with > > all commands integrated. This verifies that the > shell can build in > > this max configuration. > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Zhichao Gao > > Cc: Sami Mujawar > > Signed-off-by: Michael D Kinney > > > --- > > ShellPkg/ShellPkg.dsc | 22 +++++++++++++++++++++- > > 1 file changed, 21 insertions(+), 1 deletion(-) > > > > diff --git a/ShellPkg/ShellPkg.dsc > b/ShellPkg/ShellPkg.dsc index > > 6a139b3b91..b2065dc028 100644 > > --- a/ShellPkg/ShellPkg.dsc > > +++ b/ShellPkg/ShellPkg.dsc > > @@ -1,7 +1,7 @@ > > ## @file > > # Shell Package > > # > > -# Copyright (c) 2007 - 2018, Intel Corporation. All > rights > > reserved.
> > +# Copyright (c) 2007 - 2019, Intel Corporation. All > rights > > +reserved.
> > # Copyright (c) 2018, Arm Limited. All rights > reserved.
# > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -115,6 +115,26 @@ [Components] > > !endif #$(NO_SHELL_PROFILES) > > } > > > > + # > > + # Build a second version of the shell with all > commands integrated > > + # ShellPkg/Application/Shell/Shell.inf { > > + > > + FILE_GUID =3D EA4BB293-2D7F-4456-A681- > 1F22F42CD0BC > > + > > + > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FA > LSE > > + > > + > > > NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiSh > ellLevel2Comma > > ndsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiSh > ellLevel1Comma > > ndsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiSh > ellLevel3Comma > > ndsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiS > hellDriver1Com > > mandsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/Uefi > ShellInstall1Co > > NULL|m > > mandsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiSh > ellDebug1Com > > mandsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/Uefi > ShellNetwork1 > > CommandsLib.inf > > + > > > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/Uefi > ShellNetwork2 > > CommandsLib.inf > > + > > + > > > NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiS > hellAcpiViewCo > > m > > + mandLib.inf > > + } > > + > > > > > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicC > ommand. > > inf { > > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FA > LSE > > -- > > 2.21.0.windows.1 > > > > > >=20