From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 08 Aug 2019 00:26:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 00:26:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="165612878" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga007.jf.intel.com with ESMTP; 08 Aug 2019 00:26:05 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX102.amr.corp.intel.com ([169.254.3.11]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 00:26:05 -0700 From: "Michael D Kinney" To: Gary Lin , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Sun, Zailiang" , "Qian, Yi" Subject: Re: [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Topic: [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Index: AQHVRq8IkgwNEj0QbUCqOgBW+vbq+Kbw5R0Q Date: Thu, 8 Aug 2019 07:26:04 +0000 Message-ID: References: <20190730081518.16349-1-glin@suse.com> In-Reply-To: <20190730081518.16349-1-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary, Thank you for these patches. I am seeing one behavior change in the setup forms. The following 2 forms are missing information that used to be filled in. I will help look into this tomorrow. 1) Device Manager -> System Setup -> Main 2) Device Manager -> System Setup -> Main -> Platform Information Best regards, Mike > -----Original Message----- > From: Gary Lin [mailto:GLin@suse.com] > Sent: Tuesday, July 30, 2019 1:16 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > ; Kinney, Michael D > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the boot > order, SMBIOS, and capsule GUIDs of Minnowboard >=20 > After switching to MdeModulePkg BdsDxe, the boot option > created by OS was always put at the end of BootOrder > after reboot. Besides, the PXE boot options were always > the first boot options. >=20 > The 1st to 3rd patches fix the priority of boot options > and stop sorting the boot options after the first boot. > The missing BootManagerMenuApp is also added back. >=20 > The 4th patch cleans up PlatformBootOption.c to remove > the unused variables and function. >=20 > The 5th patch adds some missing bits of BIOS > Characteristics Extension in SMBIOS, so that fwupd can > detect the system correctly. >=20 > The 6th patch converts the device GUIDs in metainfo.xml > to lowercase to be compatible with LVFS/fwupd. >=20 > The patches are also available in my github branch: > https://github.com/lcp/edk2-platforms/tree/fix- > minnowboard-bds-v2 >=20 > v2: > * Add the missing MSG_URI_DP to BootOptionPriority() > * Update the descriptioins of 2nd and 4th patches > * Add the 5th and 6th patches >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney >=20 > Gary Lin (6): > Vlv2TbltDevicePkg: Adjust the device priority > Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp > Vlv2TbltDevicePkg: Only sort boot options when > necessary > Vlv2TbltDevicePkg: Clean up the unused variables and > function > Vlv2TbltDevicePkg: Add the missing SMBIOS bits > Vlv2TbltDevicePkg: Convert the device GUIDs of > capsules to lowercase >=20 >=20 > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera > teCapsule/GenCapsuleAll.py | 24 +++--- >=20 > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > tManagerLib/BdsPlatform.c | 9 +- >=20 > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > tManagerLib/PlatformBootOption.c | 86 ++++++----------- > --- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > | 3 +- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > | 1 + >=20 > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR > ecords.h | 5 +- >=20 > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios > VendorData.c | 5 +- > 8 files changed, 54 insertions(+), 80 deletions(-) >=20 > -- > 2.22.0