From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.d.kinney@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 08 Aug 2019 08:03:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 08:03:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="374879215" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2019 08:03:48 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 08:03:48 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX163.amr.corp.intel.com ([169.254.9.86]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 08:03:48 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "glin@suse.com" , "Kinney, Michael D" CC: "Qian, Yi" , "Sun, Zailiang" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Index: AQHVRq8IkgwNEj0QbUCqOgBW+vbq+Kbw5R0QgAAOXQCAAHN/EA== Date: Thu, 8 Aug 2019 15:03:47 +0000 Message-ID: References: <20190730081518.16349-1-glin@suse.com> <20190808080812.GB26233@GaryWorkstation> In-Reply-To: <20190808080812.GB26233@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary, Thanks for the additional information. I will investigate when it was introduced. The patch series looks good. Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin > Sent: Thursday, August 8, 2019 1:08 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Qian, Yi ; Sun, Zailiang > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 > 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of > Minnowboard >=20 > On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D > Kinney wrote: > > Hi Gary, > > > Hi Michael, >=20 > > Thank you for these patches. > > > > I am seeing one behavior change in the setup forms. > > The following 2 forms are missing information that > used to be filled > > in. I will help look into this tomorrow. > > > > 1) Device Manager -> System Setup -> Main > > > > 2) Device Manager -> System Setup -> Main -> Platform > Information > > > I built another firmware without my patches and those > information were still missing, so the bug is probably > introduced by other patch. >=20 > Thanks, >=20 > Gary Lin >=20 > > Best regards, > > > > Mike > > > > > -----Original Message----- > > > From: Gary Lin [mailto:GLin@suse.com] > > > Sent: Tuesday, July 30, 2019 1:16 AM > > > To: devel@edk2.groups.io > > > Cc: Sun, Zailiang ; Qian, > Yi > > > ; Kinney, Michael D > > > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the > boot order, SMBIOS, > > > and capsule GUIDs of Minnowboard > > > > > > After switching to MdeModulePkg BdsDxe, the boot > option created by > > > OS was always put at the end of BootOrder after > reboot. Besides, the > > > PXE boot options were always the first boot > options. > > > > > > The 1st to 3rd patches fix the priority of boot > options and stop > > > sorting the boot options after the first boot. > > > The missing BootManagerMenuApp is also added back. > > > > > > The 4th patch cleans up PlatformBootOption.c to > remove the unused > > > variables and function. > > > > > > The 5th patch adds some missing bits of BIOS > Characteristics > > > Extension in SMBIOS, so that fwupd can detect the > system correctly. > > > > > > The 6th patch converts the device GUIDs in > metainfo.xml to lowercase > > > to be compatible with LVFS/fwupd. > > > > > > The patches are also available in my github branch: > > > https://github.com/lcp/edk2-platforms/tree/fix- > > > minnowboard-bds-v2 > > > > > > v2: > > > * Add the missing MSG_URI_DP to > BootOptionPriority() > > > * Update the descriptioins of 2nd and 4th patches > > > * Add the 5th and 6th patches > > > > > > Cc: Zailiang Sun > > > Cc: Yi Qian > > > Cc: Michael D Kinney > > > > > > Gary Lin (6): > > > Vlv2TbltDevicePkg: Adjust the device priority > > > Vlv2TbltDevicePkg: Add the missing > BootManagerMenuApp > > > Vlv2TbltDevicePkg: Only sort boot options when > necessary > > > Vlv2TbltDevicePkg: Clean up the unused variables > and function > > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits > > > Vlv2TbltDevicePkg: Convert the device GUIDs of > capsules to > > > lowercase > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera > > > teCapsule/GenCapsuleAll.py | 24 +++--- > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > tManagerLib/BdsPlatform.c | 9 +- > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > tManagerLib/PlatformBootOption.c | 86 ++++++------- > ---- > > > --- > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > > > | 3 +- > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > | 1 + > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > | 1 + > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR > > > ecords.h | 5 +- > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios > > > VendorData.c | 5 +- > > > 8 files changed, 54 insertions(+), 80 deletions(-) > > > > > > -- > > > 2.22.0 > > > > > > > > > > >=20 >=20