From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Fri, 09 Aug 2019 12:15:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 12:15:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,366,1559545200"; d="scan'208";a="177720788" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga003.jf.intel.com with ESMTP; 09 Aug 2019 12:15:23 -0700 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 9 Aug 2019 12:15:23 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by ORSMSX124.amr.corp.intel.com ([169.254.2.63]) with mapi id 14.03.0439.000; Fri, 9 Aug 2019 12:15:23 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "glin@suse.com" , "Kinney, Michael D" CC: "Qian, Yi" , "Sun, Zailiang" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Index: AQHVRq8IkgwNEj0QbUCqOgBW+vbq+Kbw5R0QgAAOXQCAAHN/EIAB108w Date: Fri, 9 Aug 2019 19:15:22 +0000 Message-ID: References: <20190730081518.16349-1-glin@suse.com> <20190808080812.GB26233@GaryWorkstation> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary, I found that the regression was introduced at commit https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a= 4541bc2cb74c10ea5 The issue is in Vlv2Tbl2DevicePkg/PlatformSetupDxe/PlatformSetupDxe.c The call to SetupInfo() was inadvertently removed from=20 SystemConfigExtractConfig() when that function was simplified due to the varstore type change to efivarstore. I have verified that adding back the call to SetupInfo() restores the missing values in those setup forms. I have pushed your series as: 812b291c55..603ec40dbb I will send patch review for the regression later today. Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, August 8, 2019 8:04 AM > To: devel@edk2.groups.io; glin@suse.com; Kinney, > Michael D > Cc: Qian, Yi ; Sun, Zailiang > > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH v2 > 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of > Minnowboard >=20 > Hi Gary, >=20 > Thanks for the additional information. > I will investigate when it was introduced. >=20 > The patch series looks good. >=20 > Reviewed-by: Michael D Kinney > >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io > > [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin > > Sent: Thursday, August 8, 2019 1:08 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 > 0/6] Fix the boot > > order, SMBIOS, and capsule GUIDs of Minnowboard > > > > On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D > Kinney wrote: > > > Hi Gary, > > > > > Hi Michael, > > > > > Thank you for these patches. > > > > > > I am seeing one behavior change in the setup forms. > > > The following 2 forms are missing information that > > used to be filled > > > in. I will help look into this tomorrow. > > > > > > 1) Device Manager -> System Setup -> Main > > > > > > 2) Device Manager -> System Setup -> Main -> > Platform > > Information > > > > > I built another firmware without my patches and those > information were > > still missing, so the bug is probably introduced by > other patch. > > > > Thanks, > > > > Gary Lin > > > > > Best regards, > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Gary Lin [mailto:GLin@suse.com] > > > > Sent: Tuesday, July 30, 2019 1:16 AM > > > > To: devel@edk2.groups.io > > > > Cc: Sun, Zailiang ; Qian, > > Yi > > > > ; Kinney, Michael D > > > > > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the > > boot order, SMBIOS, > > > > and capsule GUIDs of Minnowboard > > > > > > > > After switching to MdeModulePkg BdsDxe, the boot > > option created by > > > > OS was always put at the end of BootOrder after > > reboot. Besides, the > > > > PXE boot options were always the first boot > > options. > > > > > > > > The 1st to 3rd patches fix the priority of boot > > options and stop > > > > sorting the boot options after the first boot. > > > > The missing BootManagerMenuApp is also added > back. > > > > > > > > The 4th patch cleans up PlatformBootOption.c to > > remove the unused > > > > variables and function. > > > > > > > > The 5th patch adds some missing bits of BIOS > > Characteristics > > > > Extension in SMBIOS, so that fwupd can detect the > > system correctly. > > > > > > > > The 6th patch converts the device GUIDs in > > metainfo.xml to lowercase > > > > to be compatible with LVFS/fwupd. > > > > > > > > The patches are also available in my github > branch: > > > > https://github.com/lcp/edk2-platforms/tree/fix- > > > > minnowboard-bds-v2 > > > > > > > > v2: > > > > * Add the missing MSG_URI_DP to > > BootOptionPriority() > > > > * Update the descriptioins of 2nd and 4th > patches > > > > * Add the 5th and 6th patches > > > > > > > > Cc: Zailiang Sun > > > > Cc: Yi Qian > > > > Cc: Michael D Kinney > > > > > > > > Gary Lin (6): > > > > Vlv2TbltDevicePkg: Adjust the device priority > > > > Vlv2TbltDevicePkg: Add the missing > > BootManagerMenuApp > > > > Vlv2TbltDevicePkg: Only sort boot options when > > necessary > > > > Vlv2TbltDevicePkg: Clean up the unused > variables > > and function > > > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits > > > > Vlv2TbltDevicePkg: Convert the device GUIDs of > > capsules to > > > > lowercase > > > > > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera > > > > teCapsule/GenCapsuleAll.py | 24 +++--- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > > tManagerLib/BdsPlatform.c | 9 +- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > > > tManagerLib/PlatformBootOption.c | 86 ++++++----- > -- > > ---- > > > > --- > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > > > > | 3 +- > > > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > > | 1 + > > > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > > | 1 + > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR > > > > ecords.h | 5 +- > > > > > > > > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios > > > > VendorData.c | 5 +- > > > > 8 files changed, 54 insertions(+), 80 > deletions(-) > > > > > > > > -- > > > > 2.22.0 > > > > > > > > > > > > > > > > > > >=20