public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wei, David Y" <david.y.wei@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI ROM for SIMICS QSP Platform
Date: Fri, 9 Aug 2019 22:53:35 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D86679@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <cover.1565390095.git.david.y.wei@intel.com>

David,

The file License.txt make a reference to the file 
IntelProprietaryLicense.txt, but I do not see that
file in this patchset.

For example, the content in Silicon/Intel/QuarkSocBinPkg
has a License.txt file and the content in the path
Silicon\Intel\QuarkSocBinPkg\QuarkNorthCluster\Binary\QuarkMicrocode
has a IntelProprietaryLicense.txt in the same directory as
the binary. 

Did you intent to include an IntelProprietaryLicense.txt file too?

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of David Wei
> Sent: Friday, August 9, 2019 3:43 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI
> ROM for SIMICS QSP Platform
> 
> Add UNDI option ROM to provide the support for SIMICS
> quick start platform.
> it uses X58/ICH10 and emulated by SIMICS model.
> 
> David Wei (1):
>   SimicsICH10SiliconBinPkg:  Add UNDI ROM for SIMICS QSP
> Platform
> 
>  .../UndiBinary/GigUndiDxe.efi                      |
> Bin 0 -> 195360 bytes
>  .../UndiBinary/License.txt                         |
> 30 +++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644
> Silicon/Intel/SimicsICH10SiliconBinPkg/UndiBinary/GigUnd
> iDxe.efi
>  create mode 100644
> Silicon/Intel/SimicsICH10SiliconBinPkg/UndiBinary/Licens
> e.txt
> 
> --
> 2.16.2.windows.1
> 
> 
> 


  parent reply	other threads:[~2019-08-09 22:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 22:43 [edk2-non-osi patch 0/1] Add UNDI ROM for SIMICS QSP Platform David Wei
2019-08-09 22:43 ` [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: " David Wei
2019-08-15  8:29   ` Nate DeSimone
2019-08-09 22:53 ` Michael D Kinney [this message]
2019-08-09 23:51   ` [edk2-devel] [edk2-non-osi patch 0/1] " David Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9D86679@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox