From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by groups.io with SMTP; Fri, 09 Aug 2019 15:53:37 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 15:53:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,367,1559545200"; 
   d="scan'208";a="375342856"
Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6])
  by fmsmga006.fm.intel.com with ESMTP; 09 Aug 2019 15:53:36 -0700
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.177]) by
 ORSMSX108.amr.corp.intel.com ([169.254.2.65]) with mapi id 14.03.0439.000;
 Fri, 9 Aug 2019 15:53:36 -0700
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Wei, David Y"
	<david.y.wei@intel.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI ROM for SIMICS QSP Platform
Thread-Topic: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI ROM for SIMICS
 QSP Platform
Thread-Index: AQHVTwPeh/JMgL28bE+8194gMtjXkKbzapXA
Date: Fri, 9 Aug 2019 22:53:35 +0000
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D86679@ORSMSX113.amr.corp.intel.com>
References: <cover.1565390095.git.david.y.wei@intel.com>
In-Reply-To: <cover.1565390095.git.david.y.wei@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

David,

The file License.txt make a reference to the file=20
IntelProprietaryLicense.txt, but I do not see that
file in this patchset.

For example, the content in Silicon/Intel/QuarkSocBinPkg
has a License.txt file and the content in the path
Silicon\Intel\QuarkSocBinPkg\QuarkNorthCluster\Binary\QuarkMicrocode
has a IntelProprietaryLicense.txt in the same directory as
the binary.=20

Did you intent to include an IntelProprietaryLicense.txt file too?

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of David Wei
> Sent: Friday, August 9, 2019 3:43 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI
> ROM for SIMICS QSP Platform
>=20
> Add UNDI option ROM to provide the support for SIMICS
> quick start platform.
> it uses X58/ICH10 and emulated by SIMICS model.
>=20
> David Wei (1):
>   SimicsICH10SiliconBinPkg:  Add UNDI ROM for SIMICS QSP
> Platform
>=20
>  .../UndiBinary/GigUndiDxe.efi                      |
> Bin 0 -> 195360 bytes
>  .../UndiBinary/License.txt                         |
> 30 +++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644
> Silicon/Intel/SimicsICH10SiliconBinPkg/UndiBinary/GigUnd
> iDxe.efi
>  create mode 100644
> Silicon/Intel/SimicsICH10SiliconBinPkg/UndiBinary/Licens
> e.txt
>=20
> --
> 2.16.2.windows.1
>=20
>=20
>=20