public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config
Date: Sat, 10 Aug 2019 04:46:50 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D866F4@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <156539208757.28138.10778164143207338279@jljusten-skl>

Yes.  I was able to test Linux boots.  I32 and X64.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Jordan Justen
> Sent: Friday, August 9, 2019 4:08 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg:
> Fix VS20xx IA32 boot and simplify build config
> 
> On 2019-08-09 15:44:01, Michael D Kinney wrote:
> > New in V3
> > ==========
> > * Fix size value used in call to AsciiStrCpyS() in
> PosixFileSystem.c
> > * Fix XCODE5 safe string function build failure in
> BerkleyPacketFilter.c
> > * Add NOOPT build target to DSC file.
> >
> > New in V2
> > =========
> > * Fix size values in safe string function calls.
> > * Update POSIX sources to use AsciiStrCpyS() and
> AsciiStrCatS().
> > * Verify that no exceptions occur if EMU_MAGIC_PAGE()
> can not be mapped.  An
> >   error message is generated and the host app exits
> normally.
> > * Update EmulatorPkg DEC file with a new
> PcdPeiServicesTablePage default value
> >   that works for Windows/POSIX hosts for both IA32 and
> X64.
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=162
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2055
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2056
> >
> > * Fix VS20xx IA32 boot failure
> > * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> > * Add -D DISABLE_NEW_DEPRECATED_INTERFACES
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (4):
> >   EmulatorPkg: Fix VS20xx IA32 boot failure
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Add -D
> DISABLE_NEW_DEPRECATED_INTERFACES
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Add support for NOOPT target
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> Were you able to test this still boots on Linux?
> 
> -Jordan
> 
> >
> >  EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9
> +-
> >  EmulatorPkg/EmulatorPkg.dec                   |   4
> +-
> >  EmulatorPkg/EmulatorPkg.dsc                   |  34
> ++---
> >  EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8
> +-
> >  EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4
> +-
> >  .../ThunkProtocolList/ThunkProtocolList.c     |  11
> +-
> >  EmulatorPkg/Readme.md                         |   8
> +-
> >  EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  10
> +-
> >  EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80
> ++++++++----
> >  EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4
> +-
> >  EmulatorPkg/Win/Host/WinFileSystem.c          | 116
> ++++++++++++------
> >  EmulatorPkg/Win/VS2017/BuildVS.bat            |   2
> +-
> >  EmulatorPkg/build.sh                          |   8
> +-
> >  13 files changed, 197 insertions(+), 101 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> 
> 


      reply	other threads:[~2019-08-10  4:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 22:44 [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Michael D Kinney
2019-08-09 22:44 ` [Patch V3 1/4] EmulatorPkg: Fix VS20xx IA32 boot failure Michael D Kinney
2019-08-09 22:44 ` [Patch V3 2/4] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD Michael D Kinney
2019-08-09 22:44 ` [Patch V3 3/4] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES Michael D Kinney
2019-08-09 22:44 ` [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target Michael D Kinney
2019-08-12  2:30   ` [edk2-devel] " Wu, Hao A
2019-08-09 23:08 ` [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Jordan Justen
2019-08-10  4:46   ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9D866F4@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox