From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Justen, Jordan L" <jordan.l.justen@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config
Date: Mon, 19 Aug 2019 16:59:17 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9D8C143@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <156618255669.21530.4103606888685623120@jljusten-skl>
Hi Jordan,
Thank you for the reviews. I have addressed the two issues
you raised in my local branch and I verified that the lldbefi.py
script behaves the same after breaking up the long line.
Best regards,
Mike
> -----Original Message-----
> From: Justen, Jordan L
> Sent: Sunday, August 18, 2019 7:43 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [Patch V5 00/11] EmulatorPkg: Fix VS20xx
> IA32 boot and simplify build config
>
> On 2019-08-16 17:57:04, Michael D Kinney wrote:
> >
> > Andrew Fish (7):
> > EmulatorPkg/Unix/Host: Disable inline/optimizations
>
> Maybe add XCODE5 in commit message subject?
>
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > EmulatorPkg: Fix XCODE5 lldb issues
>
> There was another long line in the
> EmulatorPkg/Unix/lldbefi.py change.
>
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > EmulatorPkg/Unix/Host: Initialize field in
> BerkeleyPacketFilter.c
>
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > EmulatorPkg/Unix/Host: Remove debug code from
> BerkeleyPacketFilter.c
>
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > EmulatorPkg: Disable TftpDynamicCommand and LogoDxe
> for XCODE5
>
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > EmulatorPkg/Sec: Change scope of PpiArray[10]
>
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> > BaseTools/tools_def.template: Add -gdwarf to XCODE5
> X64
>
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
prev parent reply other threads:[~2019-08-19 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 0:57 [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Michael D Kinney
2019-08-17 0:57 ` [Patch V5 01/11] EmulatorPkg: Fix VS20xx IA32 boot failure Michael D Kinney
2019-08-17 0:57 ` [Patch V5 02/11] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD Michael D Kinney
2019-08-17 0:57 ` [Patch V5 03/11] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES Michael D Kinney
2019-08-17 0:57 ` [Patch V5 04/11] EmulatorPkg: Add support for NOOPT target Michael D Kinney
2019-08-17 0:57 ` [Patch V5 05/11] EmulatorPkg/Unix/Host: Disable inline/optimizations Michael D Kinney
2019-08-17 0:57 ` [Patch V5 06/11] EmulatorPkg: Fix XCODE5 lldb issues Michael D Kinney
2019-08-17 0:57 ` [Patch V5 07/11] EmulatorPkg/Unix/Host: Initialize field in BerkeleyPacketFilter.c Michael D Kinney
2019-08-17 0:57 ` [Patch V5 08/11] EmulatorPkg/Unix/Host: Remove debug code from BerkeleyPacketFilter.c Michael D Kinney
2019-08-17 0:57 ` [Patch V5 09/11] EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5 Michael D Kinney
2019-08-17 0:57 ` [Patch V5 10/11] EmulatorPkg/Sec: Change scope of PpiArray[10] Michael D Kinney
2019-08-17 0:57 ` [Patch V5 11/11] BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64 Michael D Kinney
2019-08-19 2:42 ` [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Jordan Justen
2019-08-19 16:59 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9D8C143@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox