Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression

["Michael D Kinney" <michael.d.kinney@intel.com>]

Ray,

Laszlo and I are OK with this change going into the stable tag.

I would like to a response from Andrew or Leif.

Mike

> -----Original Message-----
> From: Ni, Ray
> Sent: Monday, August 26, 2019 1:35 PM
> To: devel@edk2.groups.io; tim.lewis@insyde.com; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>;
> 'Andrew Fish' <afish@apple.com>
> Subject: RE: [edk2-devel] [Patch][edk2-stable201908 0/2]
> EmulatorPkg/Win/Host: Fix image unload regression
> 
> All,
> As the package maintainer of EmulatorPkg, I should push
> the patches.
> But I am not sure if there should be some ack from
> stewards regarding including this patch in the coming
> stable tag.
> 
> What's the process?
> 
> Thanks,
> Ray
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Tim
> > Lewis
> > Sent: Monday, August 26, 2019 12:32 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io
> > Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ni,
> Ray
> > <ray.ni@intel.com>; 'Andrew Fish' <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch][edk2-stable201908
> 0/2]
> > EmulatorPkg/Win/Host: Fix image unload regression
> >
> > Tested-by: Tim Lewis <tim.lewis@insyde.com>
> >
> > -----Original Message-----
> > From: Michael D Kinney <michael.d.kinney@intel.com>
> > Sent: Wednesday, August 21, 2019 7:36 PM
> > To: devel@edk2.groups.io
> > Cc: Jordan Justen <jordan.l.justen@intel.com>; Ray Ni
> > <ray.ni@intel.com>; Andrew Fish <afish@apple.com>; Tim
> Lewis
> > <tim.lewis@insyde.com>
> > Subject: [Patch][edk2-stable201908 0/2]
> EmulatorPkg/Win/Host: Fix
> > image unload regression
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2104
> >
> > When UEFI Applications or UEFI Drivers are unloaded,
> the
> > PeCoffLoaderUnloadImageExtraAction() needs to unload
> the image using
> > FreeLibrary() if the image was successfully loaded
> using LoadLibrrayEx().
> >
> > This is a regression from the Nt32Pkg that supported
> unloading
> > applications and drivers as well as loading the same
> application or
> > driver multiple times.
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Tim Lewis <tim.lewis@insyde.com>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (2):
> >   EmulatorPkg/Win/Host: Fix image unload regression
> >   EmulatorPkg/Win/Host: Fix SecPrint() log line
> endings
> >
> >  EmulatorPkg/Win/Host/WinHost.c | 193
> > +++++++++++++++++++++++++++++----
> >  1 file changed, 174 insertions(+), 19 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
> >