From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.d.kinney@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 26 Aug 2019 14:01:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 14:01:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,433,1559545200"; d="scan'208";a="197143903" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga001.fm.intel.com with ESMTP; 26 Aug 2019 14:01:07 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 14:01:06 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.198]) by ORSMSX161.amr.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0439.000; Mon, 26 Aug 2019 14:01:06 -0700 From: "Michael D Kinney" To: "Ni, Ray" , "devel@edk2.groups.io" , "tim.lewis@insyde.com" , "Kinney, Michael D" , "leif.lindholm@linaro.org" , "Andrew Fish (afish@apple.com)" CC: "Justen, Jordan L" Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Thread-Topic: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Thread-Index: AQHVWJJnRjuLn7X4nkuNxfLa7151XacOTfeAgAARzQD//5ErcA== Date: Mon, 26 Aug 2019 21:01:05 +0000 Message-ID: References: <20190822023610.2068-1-michael.d.kinney@intel.com> <016201d55c44$e42cf220$ac86d660$@insyde.com> <734D49CCEBEEF84792F5B80ED585239D5C29AF21@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C29AF21@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, Laszlo and I are OK with this change going into the stable tag. I would like to a response from Andrew or Leif. Mike > -----Original Message----- > From: Ni, Ray > Sent: Monday, August 26, 2019 1:35 PM > To: devel@edk2.groups.io; tim.lewis@insyde.com; Kinney, > Michael D > Cc: Justen, Jordan L ; > 'Andrew Fish' > Subject: RE: [edk2-devel] [Patch][edk2-stable201908 0/2] > EmulatorPkg/Win/Host: Fix image unload regression >=20 > All, > As the package maintainer of EmulatorPkg, I should push > the patches. > But I am not sure if there should be some ack from > stewards regarding including this patch in the coming > stable tag. >=20 > What's the process? >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of Tim > > Lewis > > Sent: Monday, August 26, 2019 12:32 PM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Justen, Jordan L ; Ni, > Ray > > ; 'Andrew Fish' > > Subject: Re: [edk2-devel] [Patch][edk2-stable201908 > 0/2] > > EmulatorPkg/Win/Host: Fix image unload regression > > > > Tested-by: Tim Lewis > > > > -----Original Message----- > > From: Michael D Kinney > > Sent: Wednesday, August 21, 2019 7:36 PM > > To: devel@edk2.groups.io > > Cc: Jordan Justen ; Ray Ni > > ; Andrew Fish ; Tim > Lewis > > > > Subject: [Patch][edk2-stable201908 0/2] > EmulatorPkg/Win/Host: Fix > > image unload regression > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2104 > > > > When UEFI Applications or UEFI Drivers are unloaded, > the > > PeCoffLoaderUnloadImageExtraAction() needs to unload > the image using > > FreeLibrary() if the image was successfully loaded > using LoadLibrrayEx(). > > > > This is a regression from the Nt32Pkg that supported > unloading > > applications and drivers as well as loading the same > application or > > driver multiple times. > > > > Cc: Jordan Justen > > Cc: Ray Ni > > Cc: Andrew Fish > > Cc: Tim Lewis > > Signed-off-by: Michael D Kinney > > > > > Michael D Kinney (2): > > EmulatorPkg/Win/Host: Fix image unload regression > > EmulatorPkg/Win/Host: Fix SecPrint() log line > endings > > > > EmulatorPkg/Win/Host/WinHost.c | 193 > > +++++++++++++++++++++++++++++---- > > 1 file changed, 174 insertions(+), 19 deletions(-) > > > > -- > > 2.21.0.windows.1 > > > > > > > >=20