public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "afish@apple.com" <afish@apple.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Laszlo Ersek (lersek@redhat.com)" <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList
Date: Tue, 27 Aug 2019 00:20:16 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9DA3811@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com>

Ray,

Are there any components that need these new enum values?

The patch looks very straightforward and is from the 
UEFI Spec, so I think the risk is low.  But if consumers
will not show up until after the stable tag, perhaps this
should be one of the first patches after the stable tag.

Thanks,

Mike

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, August 26, 2019 4:57 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek
> (lersek@redhat.com) <lersek@redhat.com>
> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908]
> MdePkg/BluetoothLeConfig.h: Add type
> EfiBluetoothSmpPeerAddressList
> 
> Cc to all Stewards.
> 
> >-----Original Message-----
> >From: Ni, Ray
> >Sent: Tuesday, August 27, 2019 2:20 AM
> >To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> >Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming
> ><liming.gao@intel.com>
> >Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908]
> >MdePkg/BluetoothLeConfig.h: Add type
> EfiBluetoothSmpPeerAddressList
> >
> >I understand it's now in code freeze phase.
> >Just make a try to see whether this very clean/simple
> header file
> >change can be included in the stable tag.
> >Any platform that uses BLE stack can get benefit from
> this definition update.
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Ni,
> >> Ray
> >> Sent: Monday, August 26, 2019 11:16 AM
> >> To: devel@edk2.groups.io
> >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming
> ><liming.gao@intel.com>
> >> Subject: [edk2-devel] [PATCH] [edk2-stable201908]
> >MdePkg/BluetoothLeConfig.h: Add type
> EfiBluetoothSmpPeerAddressList
> >>
> >> To support auto-connection,
> EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs
> >to
> >> add a new data type EfiBluetoothSmpPeerAddressList
> which associates
> >> with a list of Bluetooth per address connected
> before.
> >>
> >> This new data type was added in UEFI spec 2.7b.
> >>
> >> Signed-off-by: Ray Ni <ray.ni@intel.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Liming Gao <liming.gao@intel.com>
> >> ---
> >>  MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git
> a/MdePkg/Include/Protocol/BluetoothLeConfig.h
> >b/MdePkg/Include/Protocol/BluetoothLeConfig.h
> >> index 8c0f881f85..8726a58b15 100644
> >> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h
> >> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h
> >> @@ -2,7 +2,7 @@
> >>    EFI Bluetooth LE Config Protocol as defined in
> UEFI 2.7.
> >>    This protocol abstracts user interface
> configuration for BluetoothLe device.
> >>
> >> -  Copyright (c) 2017, Intel Corporation. All rights
> reserved.<BR>
> >> +  Copyright (c) 2017 - 2019, Intel Corporation. All
> rights
> >> + reserved.<BR>
> >>    SPDX-License-Identifier: BSD-2-Clause-Patent
> >>
> >>    @par Revision Reference:
> >> @@ -451,6 +451,8 @@ typedef enum {
> >>    EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not
> supported */
> >>    EfiBluetoothSmpLocalSignCounter,
> >>    EfiBluetoothSmpLocalDIV,
> >> +  EfiBluetoothSmpPeerAddressList,
> >> +  EfiBluetoothSmpMax,
> >>  } EFI_BLUETOOTH_LE_SMP_DATA_TYPE;
> >>
> >>  /**
> >> --
> >> 2.21.0.windows.1
> >>
> >>
> >> 


  reply	other threads:[~2019-08-27  0:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15BE8BCCADEA547C.18314@groups.io>
2019-08-26 18:19 ` [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Ni, Ray
2019-08-26 23:56   ` Liming Gao
2019-08-27  0:20     ` Michael D Kinney [this message]
2019-08-27  0:45       ` Ni, Ray
2019-08-27 10:18         ` Leif Lindholm
2019-08-27 12:47         ` Laszlo Ersek
2019-08-27 16:16           ` Ni, Ray
2019-08-26 18:16 Ni, Ray
2019-09-04  0:05 ` [edk2-devel] " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9DA3811@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox