From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 26 Aug 2019 17:20:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 17:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208";a="209554947" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga002.fm.intel.com with ESMTP; 26 Aug 2019 17:20:17 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 17:20:17 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.198]) by ORSMSX114.amr.corp.intel.com ([169.254.8.225]) with mapi id 14.03.0439.000; Mon, 26 Aug 2019 17:20:16 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "Ni, Ray" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "afish@apple.com" , "leif.lindholm@linaro.org" , "Laszlo Ersek (lersek@redhat.com)" Subject: Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Thread-Topic: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Thread-Index: AQHVXDp+NF2kY0e/RUKW8I4anvfXM6cNvMcQgADT3wD//5AXIA== Date: Tue, 27 Aug 2019 00:20:16 +0000 Message-ID: References: <15BE8BCCADEA547C.18314@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C29AD17@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, Are there any components that need these new enum values? The patch looks very straightforward and is from the=20 UEFI Spec, so I think the risk is low. But if consumers will not show up until after the stable tag, perhaps this should be one of the first patches after the stable tag. Thanks, Mike > -----Original Message----- > From: Gao, Liming > Sent: Monday, August 26, 2019 4:57 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Kinney, Michael D ; > afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek > (lersek@redhat.com) > Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > MdePkg/BluetoothLeConfig.h: Add type > EfiBluetoothSmpPeerAddressList >=20 > Cc to all Stewards. >=20 > >-----Original Message----- > >From: Ni, Ray > >Sent: Tuesday, August 27, 2019 2:20 AM > >To: devel@edk2.groups.io; Ni, Ray > >Cc: Kinney, Michael D ; > Gao, Liming > > > >Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > >MdePkg/BluetoothLeConfig.h: Add type > EfiBluetoothSmpPeerAddressList > > > >I understand it's now in code freeze phase. > >Just make a try to see whether this very clean/simple > header file > >change can be included in the stable tag. > >Any platform that uses BLE stack can get benefit from > this definition update. > > > >> -----Original Message----- > >> From: devel@edk2.groups.io On > Behalf Of Ni, > >> Ray > >> Sent: Monday, August 26, 2019 11:16 AM > >> To: devel@edk2.groups.io > >> Cc: Kinney, Michael D ; > Gao, Liming > > > >> Subject: [edk2-devel] [PATCH] [edk2-stable201908] > >MdePkg/BluetoothLeConfig.h: Add type > EfiBluetoothSmpPeerAddressList > >> > >> To support auto-connection, > EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs > >to > >> add a new data type EfiBluetoothSmpPeerAddressList > which associates > >> with a list of Bluetooth per address connected > before. > >> > >> This new data type was added in UEFI spec 2.7b. > >> > >> Signed-off-by: Ray Ni > >> Cc: Michael D Kinney > >> Cc: Liming Gao > >> --- > >> MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git > a/MdePkg/Include/Protocol/BluetoothLeConfig.h > >b/MdePkg/Include/Protocol/BluetoothLeConfig.h > >> index 8c0f881f85..8726a58b15 100644 > >> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h > >> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h > >> @@ -2,7 +2,7 @@ > >> EFI Bluetooth LE Config Protocol as defined in > UEFI 2.7. > >> This protocol abstracts user interface > configuration for BluetoothLe device. > >> > >> - Copyright (c) 2017, Intel Corporation. All rights > reserved.
> >> + Copyright (c) 2017 - 2019, Intel Corporation. All > rights > >> + reserved.
> >> SPDX-License-Identifier: BSD-2-Clause-Patent > >> > >> @par Revision Reference: > >> @@ -451,6 +451,8 @@ typedef enum { > >> EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not > supported */ > >> EfiBluetoothSmpLocalSignCounter, > >> EfiBluetoothSmpLocalDIV, > >> + EfiBluetoothSmpPeerAddressList, > >> + EfiBluetoothSmpMax, > >> } EFI_BLUETOOTH_LE_SMP_DATA_TYPE; > >> > >> /** > >> -- > >> 2.21.0.windows.1 > >> > >> > >>=20