Re: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.

["Michael D Kinney" <michael.d.kinney@intel.com>]

Bob and Liming,

What is an example test case that fails?  Please add to BZ.

We need this information to test that this fix resolves the
issue.

Mike

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, August 28, 2019 8:26 AM
> To: Feng, Bob C <bob.c.feng@intel.com>;
> devel@edk2.groups.io
> Cc: Shi, Steven <steven.shi@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; afish@apple.com; Laszlo
> Ersek (lersek@redhat.com) <lersek@redhat.com>;
> leif.lindholm@linaro.org
> Subject: RE: [Patch][edk2-stable201908] BaseTools: fix an
> incremental build issue.
> 
> Bob:
>   This is the critical regression issue for the
> incremental build. I request to catch it in this stable
> tag 201908.
> 
>   This patch corrects the behavior. Reviewed-by: Liming
> Gao <liming.gao@intel.com>
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Feng, Bob C
> > Sent: Wednesday, August 28, 2019 4:52 PM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Shi, Steven
> <steven.shi@intel.com>
> > Subject: [Patch][edk2-stable201908] BaseTools: fix an
> incremental build issue.
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137
> >
> > This patch is going to fix a regression issue of
> incremental build
> > which was introduced by the commit 94459080c.
> > The changing on INF file will not trigger module
> rebuild.
> >
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Steven Shi <steven.shi@intel.com>
> > ---
> >  BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
> ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git
> a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
> > b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
> > index 2cd0d3859e..f610365f6d 100755
> > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
> > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
> > @@ -1764,16 +1764,12 @@ class ModuleAutoGen(AutoGen):
> >              for f in self.AutoGenDepSet:
> >                  FileSet.add (f.Path)
> >
> >              if os.path.exists (self.TimeStampPath):
> >                  os.remove (self.TimeStampPath)
> > -            with tempfile.NamedTemporaryFile('w+',
> dir=os.path.dirname(self.TimeStampPath), delete=False) as
> tf:
> > -                for f in FileSet:
> > -                    tf.write(f)
> > -                    tf.write("\n")
> > -                tempname = tf.name
> > -            SaveFileOnChange(self.TimeStampPath,
> tempname, False)
> > +
> > +            SaveFileOnChange(self.TimeStampPath,
> "\n".join(FileSet),
> > + False)
> >
> >          # Ignore generating makefile when it is a
> binary module
> >          if self.IsBinaryModule:
> >              return
> >
> > --
> > 2.20.1.windows.1