From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: michael.d.kinney@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 28 Aug 2019 08:56:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 08:56:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,441,1559545200"; d="scan'208";a="197583434" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga001.fm.intel.com with ESMTP; 28 Aug 2019 08:56:30 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 08:56:30 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.198]) by ORSMSX152.amr.corp.intel.com ([169.254.8.159]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 08:56:29 -0700 From: "Michael D Kinney" To: "Gao, Liming" , "Feng, Bob C" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Shi, Steven" , "afish@apple.com" , "Laszlo Ersek (lersek@redhat.com)" , "leif.lindholm@linaro.org" Subject: Re: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue. Thread-Topic: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue. Thread-Index: AQHVXbTpX8DWtnZZ5Uy2SsPr9qetiKcQtoDQ Date: Wed, 28 Aug 2019 15:56:29 +0000 Message-ID: References: <20190828085209.25316-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DDB59@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DDB59@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob and Liming, What is an example test case that fails? Please add to BZ. We need this information to test that this fix resolves the issue. Mike > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, August 28, 2019 8:26 AM > To: Feng, Bob C ; > devel@edk2.groups.io > Cc: Shi, Steven ; Kinney, Michael D > ; afish@apple.com; Laszlo > Ersek (lersek@redhat.com) ; > leif.lindholm@linaro.org > Subject: RE: [Patch][edk2-stable201908] BaseTools: fix an > incremental build issue. >=20 > Bob: > This is the critical regression issue for the > incremental build. I request to catch it in this stable > tag 201908. >=20 > This patch corrects the behavior. Reviewed-by: Liming > Gao >=20 > Thanks > Liming > > -----Original Message----- > > From: Feng, Bob C > > Sent: Wednesday, August 28, 2019 4:52 PM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C ; Gao, Liming > > ; Shi, Steven > > > Subject: [Patch][edk2-stable201908] BaseTools: fix an > incremental build issue. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2137 > > > > This patch is going to fix a regression issue of > incremental build > > which was introduced by the commit 94459080c. > > The changing on INF file will not trigger module > rebuild. > > > > Signed-off-by: Bob Feng > > Cc: Liming Gao > > Cc: Steven Shi > > --- > > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 > ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git > a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > index 2cd0d3859e..f610365f6d 100755 > > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > > @@ -1764,16 +1764,12 @@ class ModuleAutoGen(AutoGen): > > for f in self.AutoGenDepSet: > > FileSet.add (f.Path) > > > > if os.path.exists (self.TimeStampPath): > > os.remove (self.TimeStampPath) > > - with tempfile.NamedTemporaryFile('w+', > dir=3Dos.path.dirname(self.TimeStampPath), delete=3DFalse) as > tf: > > - for f in FileSet: > > - tf.write(f) > > - tf.write("\n") > > - tempname =3D tf.name > > - SaveFileOnChange(self.TimeStampPath, > tempname, False) > > + > > + SaveFileOnChange(self.TimeStampPath, > "\n".join(FileSet), > > + False) > > > > # Ignore generating makefile when it is a > binary module > > if self.IsBinaryModule: > > return > > > > -- > > 2.20.1.windows.1