From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Thu, 29 Aug 2019 13:22:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 13:22:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,444,1559545200"; d="scan'208";a="380893900" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga005.fm.intel.com with ESMTP; 29 Aug 2019 13:22:41 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 13:22:41 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.198]) by ORSMSX112.amr.corp.intel.com ([169.254.3.89]) with mapi id 14.03.0439.000; Thu, 29 Aug 2019 13:22:41 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "rfc@edk2.groups.io" Subject: [RFC] EDK II Continuous Integration Phase 1 Thread-Topic: [RFC] EDK II Continuous Integration Phase 1 Thread-Index: AdVeooLjZu0dT/k9SsO41W96IKrh5A== Date: Thu, 29 Aug 2019 20:22:41 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello, This is a proposal for a first step towards continuous integration for all TianoCore repositories to help=20 improve to quality of commits and automate testing and release processes for all EDK II packages and platforms. This is based on work from a number of EDK II community members that have provide valuable input and evaluations. * Rebecca Cran Jenkins evaluation * Laszlo Ersek GitLab evaluation * Philippe Mathieu-Daud=E9 GitLab evaluation * Sean Brogan Azure Pipelines and HBFA * Bret Barkelew Azure Pipelines and HBFA * Jiewen Yao HBFA The following link is a link to an EDK II WIKI page that contains a summary of the work to date. Please provide feedback in the EDK II mailing lists. The WIKI pages will be updated with input from the entire EDK II community. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Continuous= -Integration Proposal =3D=3D=3D=3D=3D=3D=3D=3D Phase 1 of adding continuous integration is limited to the edk2 repository. Additional repositories will be added later. The following changes are proposed: * Remove EDK II Maintainers write access to edk2 repository. Only EDK II Administrators will continue to have write=20 access, and that should only be used to handle extraordinary events. * EDK II Maintainers use a GitHub Pull Request instead of push to commit a patch series to the edk2 repository. There are no other changes to the development and review process. The patch series is prepared in an EDK II maintainer branch with all commit message requirements met on each patch in the series. * The edk2 repository only accepts Pull Requests from members of the EDK II Maintainers team. Pull Requests from anyone else are rejected. * Run pre-commit checks using Azure Pipelines * If all pre-commit checks pass, then the patch series is auto committed. The result of this commit must match the contents and commit history that would have occurred using the previous push operation. * If any pre-commit checks fail, then notify the submitter. A typical reason for a failure would be a merge conflict with another pull request that was just processed. * Limit pre-commit checks execution time to 10 minutes. * Provide on-demand builds to EDK II Maintainers that to allow EDK II Maintainers to submit a branch through for the same set of pre-commit checks without submitting a pull request. ## Pre-Commit Checks in Phase 1 * Run and pass PatchCheck.py with no errors =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D The following are some additional pre-commit check ideas that could be quickly added once the initial version using PatchCheck.py is fully functional. Please provide feedback on the ones you like and additional ones you think may=20 improve the quality of the commits to the edk2 repository. ## Proposed Pre-Commit Checks in Phase 2 * Verify Reviewed-by and Acked-by tags are present with correct maintainer email addresses * Verify no non-ASCII characters in modified files * Verify no binary files in set of modified files * Verify package dependency rules in modified files ## Proposed Pre-Commit Checks in Phase 3 * Run ECC on modified files * Verify modified modules/libs build * Run available host based tests (HBFA) against modified modules/libs Best regards, Mike