From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.d.kinney@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Tue, 17 Sep 2019 12:10:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 12:10:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,517,1559545200"; d="scan'208";a="189017977" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga003.jf.intel.com with ESMTP; 17 Sep 2019 12:10:13 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 12:10:13 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.232]) by ORSMSX160.amr.corp.intel.com ([169.254.13.218]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 12:10:13 -0700 From: "Michael D Kinney" To: Laszlo Ersek , "devel@edk2.groups.io" , "ryszard.knop@linux.intel.com" , "leif.lindholm@linaro.org" , "Kinney, Michael D" CC: Andrew Fish , Rebecca Cran , Philippe Mathieu-Daude Subject: Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments Thread-Topic: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments Thread-Index: AQHVZwsRu9cdh452ukWICep3jsE1G6clgVUAgAADMYCAAbW/gIAJDgkA Date: Tue, 17 Sep 2019 19:10:12 +0000 Message-ID: References: <20190905183820.10312-1-lersek@redhat.com> <20190906122623.GS29255@bivouac.eciton.net> <54fb3783-7589-feff-e446-1e592686d7d2@redhat.com> <20190910153304.GD15201@bivouac.eciton.net> <57976eb87976eba0e18f70726ad1813f440e7acf.camel@linux.intel.com> <4fcb4e8d-94e6-430d-dac4-450b166c7f1e@redhat.com> In-Reply-To: <4fcb4e8d-94e6-430d-dac4-450b166c7f1e@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 U2VyaWVzIFJldmlld2VkLWJ5OiBNaWNoYWVsIEQgS2lubmV5IDxtaWNoYWVsLmQua2lubmV5QGlu dGVsLmNvbT4NCg0KSSBhbHNvIGFncmVlIHRoYXQgdGhlIG1hY3JvcyB3b3VsZCBiZSBjbGVhbmVy LCBlYXN5IHRvIHJldmlldywgYW5kDQphbmQgZmV3ZXIgbGluZXMgb2YgY29kZSB3aXRob3V0IHRo ZSBjb21tZW50IGJsb2NrLiAgSWYgSSBvYmplY3RlZA0KcHJldmlvdXNseSwgdGhlbiBJIGhhdmUg YWxzbyBjaGFuZ2VkIG15IG1pbmQuICBJIGFncmVlIHdlIGNhbiBnbw0KYWhlYWQgYW5kIHB1c2gg dGhlIHNlcmllcyBpbiBpdHMgY3VycmVudCBmb3JtIGFuZCBjb250aW51ZSB0aGUNCmRpc2N1c3Np b24gb24gdGhlIG1hY3Jvcy4NCg0KTWlrZQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQo+IEZyb206IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+DQo+IFNlbnQ6IFdlZG5l c2RheSwgU2VwdGVtYmVyIDExLCAyMDE5IDEwOjUxIEFNDQo+IFRvOiBkZXZlbEBlZGsyLmdyb3Vw cy5pbzsgcnlzemFyZC5rbm9wQGxpbnV4LmludGVsLmNvbTsNCj4gbGVpZi5saW5kaG9sbUBsaW5h cm8ub3JnDQo+IENjOiBBbmRyZXcgRmlzaCA8YWZpc2hAYXBwbGUuY29tPjsgS2lubmV5LCBNaWNo YWVsIEQNCj4gPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPjsgUmViZWNjYSBDcmFuDQo+IDxy ZWJlY2NhQGJzZGlvLmNvbT47IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZGUNCj4gPHBoaWxtZEByZWRo YXQuY29tPg0KPiBTdWJqZWN0OiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSCBlZGsyLUNDU1MgMC8z XSBDb2RpbmcNCj4gU3RhbmRhcmRzOiBhZGQgcnVsZSBmb3IgZG9jdW1lbnRpbmcgc3B1cmlvdXMg dmFyaWFibGUNCj4gYXNzaWdubWVudHMNCj4gDQo+IE9uIDA5LzEwLzE5IDE3OjQ0LCBSeXN6YXJk IEtub3Agd3JvdGU6DQo+ID4gT24gVHVlLCAyMDE5LTA5LTEwIGF0IDE2OjMzICswMTAwLCBMZWlm IExpbmRob2xtDQo+IHdyb3RlOg0KPiA+PiBPbiBNb24sIFNlcCAwOSwgMjAxOSBhdCAwMjozNTox NVBNICswMjAwLCBMYXN6bG8NCj4gRXJzZWsgd3JvdGU6DQo+ID4+PiBPbiAwOS8wNi8xOSAxNDoy NiwgTGVpZiBMaW5kaG9sbSB3cm90ZToNCj4gPj4+PiBPbiBUaHUsIFNlcCAwNSwgMjAxOSBhdCAw ODozODoxN1BNICswMjAwLCBMYXN6bG8NCj4gRXJzZWsgd3JvdGU6DQo+ID4+Pj4+IFJlcG86DQo+ ID4+Pj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9sZXJzZWsvZWRrMi0NCj4gQ0NvZGluZ1N0YW5kYXJk c1NwZWNpZmljYXRpb24uZ2l0DQo+ID4+Pj4+IEJyYW5jaDogc3B1cmlvdXNfYXNzaWduX2J6XzYw Nw0KPiA+Pj4+Pg0KPiA+Pj4+PiBIVE1MLXJlbmRlcmVkIHZpZXdzIG9mIHRoZSBtb2RpZmllZCBw YWdlczoNCj4gPj4+Pj4gLQ0KPiA+Pj4+PiBodHRwczovL2xlcnNlay5naXRib29rcy5pby9sYXN6 bG8tcy1mb3JrLW9mLXRoZS0NCj4gZWRrLWlpLWMtY29kaW5nLXN0DQo+ID4+Pj4+IGFuZGFyZHMt c3AvY29udGVudC92L3NwdXJpb3VzX2Fzc2lnbl9iel82MDcNCj4gPj4+Pj4gLQ0KPiA+Pj4+PiBo dHRwczovL2xlcnNlay5naXRib29rcy5pby9sYXN6bG8tcy1mb3JrLW9mLXRoZS0NCj4gZWRrLWlp LWMtY29kaW5nLXN0DQo+ID4+Pj4+IGFuZGFyZHMtDQo+IHNwL2NvbnRlbnQvdi9zcHVyaW91c19h c3NpZ25fYnpfNjA3LzZfZG9jdW1lbnRpbmdfc29mdHcNCj4gYXJlDQo+ID4+Pj4+IC82Ml9jb21t ZW50cy5odG1sDQo+ID4+Pj4+IC0NCj4gPj4+Pj4gaHR0cHM6Ly9sZXJzZWsuZ2l0Ym9va3MuaW8v bGFzemxvLXMtZm9yay1vZi10aGUtDQo+IGVkay1paS1jLWNvZGluZy1zdA0KPiA+Pj4+PiBhbmRh cmRzLQ0KPiBzcC9jb250ZW50L3Yvc3B1cmlvdXNfYXNzaWduX2J6XzYwNy82X2RvY3VtZW50aW5n X3NvZnR3DQo+IGFyZQ0KPiA+Pj4+PiAvNjRfd2hhdF95b3VfbXVzdF9jb21tZW50Lmh0bWwNCj4g Pj4+Pj4NCj4gPj4+Pj4gVGhlIGZpcnN0IHR3byBwYXRjaGVzIGFyZSBjbGVhbnVwcyBmb3IgdGhp bmdzDQo+IHRoYXQgcG9wcGVkIHVwIGluDQo+ID4+Pj4+IHRoZSBkaXNjdXNzaW9uIGluIDwNCj4g Pj4+Pj4NCj4gaHR0cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDc+Oy4NCj4gPj4+Pj4NCj4gPj4+Pj4gVGhlIHRoaXJkIHBhdGNoIGlzIHRoZSBvbmUgZml4aW5n IHRoZSBCWi4NCj4gPj4+Pg0KPiA+Pj4+IEZvciAxIGFuZCAyLA0KPiA+Pj4+IFJldmlld2VkLWJ5 OiBMZWlmIExpbmRob2xtDQo+IDxsZWlmLmxpbmRob2xtQGxpbmFyby5vcmc+DQo+ID4+Pj4NCj4g Pj4+PiBGb3IgMywgSSBzZWUgbm8gaXNzdWUgd2l0aCBpdCwgYnV0IEkgZG8gZmVlbA0KPiB0ZW1w dGVkIGJ5IFBoaWwncw0KPiA+Pj4+IGlucHV0IG9mIHVzaW5nIGV4cGxpY2l0IG1hY3JvcyAob2J2 aWF0aW5nIHRoZSBuZWVkDQo+IGZvciBzcGVjaWZpYw0KPiA+Pj4+IGNvbW1lbnQpLg0KPiA+Pj4+ IEkgc2VlbSB0byByZWNhbGwgYmFjayBpbiB0aGUgbWlzdHMgb2YgdGltZSB3ZQ0KPiBjb25zaWRl cmVkIHNvbWV0aGluZw0KPiA+Pj4+IHNpbWlsYXIuDQo+ID4+Pg0KPiA+Pj4gWWVzLCBJIHJlbWVt YmVyIHNpbWlsYXJseS4NCj4gPj4+DQo+ID4+Pj4gVmFndWVseS4gQW0gSSBtaXNyZW1lbWJlcmlu Zywgb3IgZGlkIHdlIGRpc291bnQNCj4gdGhhdCBvcHRpb24/DQo+ID4+Pg0KPiA+Pj4gUGhpbCdz IGN1cnJlbnQgcmVjb21tZW5kYXRpb24gaXMgd2hhdCBJIHdvdWxkIGhhdmUNCj4gcHJlZmVycmVk IGJhY2sNCj4gPj4+IHRoZW4sIGJ1dCBpdCB3YXMgcmVqZWN0ZWQsIGFzIGZhciBhcyBJIHJlY2Fs bC4gSWYgSQ0KPiByZW1lbWJlcg0KPiA+Pj4gY29ycmVjdGx5LCBtb3N0IGRldmVsb3BlcnMgcHJl ZmVycmVkIG5ha2VkIE5VTExzIC8NCj4gemVyb2VzLiBJDQo+ID4+PiBpbnNpc3RlZCBvbiB0aGUg Y29tbWVudCBhcyBhIGZhbGxiYWNrIC8gY29tcHJvbWlzZSwNCj4gc28gdGhhdCB3ZSdkDQo+ID4+ PiBoYXZlIGF0IGxlYXN0IHNvbWUgdmlzdWFsIGN1ZS4NCj4gPj4NCj4gPj4gSSdtIG5vdCBldmVu IHN1cmUgSSB3YXNuJ3Qgb25lIG9mIHRoZSBwZW9wbGUgb3Bwb3NlZA0KPiB0byBpdCB0aGVuLg0K PiA+PiBCdXQgaWYgSSB3YXMsIEkgd291bGQgYXBwZWFyIHRvIGhhdmUgY2hhbmdlZCBteQ0KPiBt aW5kLg0KPiA+Pg0KPiA+Pj4gSSBjb3VsZCBiZSBtaXMtcmVtZW1iZXJpbmc7IHdlIGNhbiByZXN0 YXJ0IHRoYXQNCj4gZGlzY3Vzc2lvbiBpZiBub3cNCj4gPj4+IHRoZSBtYWNyb3MgYXJlIHByZWZl cnJlZC4NCj4gPj4NCj4gPj4gSSB3b3VsZCBiZSBhbGwgZm9yIHRoYXQuDQo+ID4NCj4gPiBJZiBt eSAyIGNlbnRzIGFyZSB3b3J0aCBhbnl0aGluZywgdGhhdCdkIGJlIHByZWZlcnJlZA0KPiBieSBz b21lIGZvbGtzIGluDQo+ID4gbXkgdGVhbSB0b28uIEFsdGhvdWdoIHNvbWV0aGluZyBzaG9ydGVy IGxpa2UNCj4gIlVOSU5JVElBTElaRURfSU5UL1BUUiINCj4gPiB3b3VsZCBiZSBuaWNlciwgSU1P LiBCb3RoIHdvcmsgb2YgY291cnNlLg0KPiANCj4gVGhhbmtzIGV2ZXJ5b25lIGZvciB0aGUgZmVl ZGJhY2sgdGh1cyBmYXIgb24gdGhpcw0KPiBzZXJpZXMuIEl0IGxvb2tzIGxpa2UgSSBjb3VsZCBn byBhaGVhZCBhbmQgcHVzaCB0aGUNCj4gcGF0Y2hlcywgbWluaW1hbGx5IGZvciBicmluZ2luZyB0 aGUgQ0NTUyBpbiBjbG9zZXIgc3luYw0KPiB3aXRoIHJlYWxpdHkgLS0gYW5kIHRoZW4gd2UgY291 bGQgaW1wcm92ZQ0KPiBpbmNyZW1lbnRhbGx5LCBmb3IgZXhhbXBsZSB3aXRoIG1hY3Jvcy4NCj4g DQo+IEJ1dCwgYmVmb3JlIEkgcHVzaCB0aGUgc2V0LCBJJ2QgcmVhbGx5IGxpa2UgaGVhciBNaWtl J3MNCj4gb3BpbmlvbiB0b28gLS0gSSB2YWd1ZWx5IHJlY2FsbCBoZSB3YXMgYWN0aXZlIGluIHRo ZQ0KPiBvcmlnaW5hbCBkaXNjdXNzaW9uLiBJIHdvdWxkbid0IGxpa2UgdG8gYmFjayBvdXQgdGhl DQo+IHBhdGNoZXMgaW4gY2FzZSBNaWtlIHJlamVjdGVkIHRoZW0gcmV0cm9hY3RpdmVseS4NCj4g DQo+IEkgYmVsaWV2ZSBNaWtlIHdpbGwgaGF2ZSBhIGJpdCBvZiBhbiBlbWFpbCBiYWNrbG9nIHRv DQo+IHByb2Nlc3MgOykgc28gSSdsbCB3YWl0IHNvbWUgbW9yZSBpbiB0aGlzIHRocmVhZC4NCj4g DQo+IFRoYW5rcyENCj4gTGFzemxvDQo+IA0KPiA+PiBIb3dldmVyLCBJIHNlZSBubyByZWFzb24g d2h5IHdlIHNob3VsZG4ndCBkb2N1bWVudA0KPiB0aGUgY3VycmVudA0KPiA+PiBwcm9jZXNzIGlu IHRoZSBtZWFudGltZSwgc28gZm9yIDMvMyBhbHNvOg0KPiA+PiBSZXZpZXdlZC1ieTogTGVpZiBM aW5kaG9sbQ0KPiA8bGVpZi5saW5kaG9sbUBsaW5hcm8ub3JnPg0KPiA+Pg0KPiA+PiBCZXN0IFJl Z2FyZHMsDQo+ID4+DQo+ID4+IExlaWYNCj4gPj4NCj4gPj4+IFRoYW5rcywNCj4gPj4+IExhc3ps bw0KPiA+Pj4NCj4gPj4+PiBSZWdhcmRzLA0KPiA+Pj4+DQo+ID4+Pj4gTGVpZg0KPiA+Pj4+DQo+ ID4+Pj4+IFRoYW5rcywNCj4gPj4+Pj4gTGFzemxvDQo+ID4+Pj4+DQo+ID4+Pj4+IENjOiBBbmRy ZXcgRmlzaCA8YWZpc2hAYXBwbGUuY29tPg0KPiA+Pj4+PiBDYzogTGVpZiBMaW5kaG9sbSA8bGVp Zi5saW5kaG9sbUBsaW5hcm8ub3JnPg0KPiA+Pj4+PiBDYzogTWljaGFlbCBEIEtpbm5leSA8bWlj aGFlbC5kLmtpbm5leUBpbnRlbC5jb20+DQo+ID4+Pj4+IENjOiBSZWJlY2NhIENyYW4gPHJlYmVj Y2FAYnNkaW8uY29tPg0KPiA+Pj4+Pg0KPiA+Pj4+PiBMYXN6bG8gRXJzZWsgKDMpOg0KPiA+Pj4+ PiAgIGNvbW1lbnRzOiByZW1vdmUgIkhvcnJvciBWYWN1aSIgcnVsZQ0KPiA+Pj4+PiAgIGNvbW1l bnRzOiByZXN0cmljdCBhbmQgY2xhcmlmeSBhcHBsaWNhYmlsaXR5IG9mDQo+ICIvKiIgY29tbWVu dHMNCj4gPj4+Pj4gICBtdXN0IGNvbW1lbnQ6IGFkZCBydWxlIGZvciBkb2N1bWVudGluZyBzcHVy aW91cw0KPiB2YXJpYWJsZQ0KPiA+Pj4+PiBhc3NpZ25tZW50cw0KPiA+Pj4+Pg0KPiA+Pj4+PiAg Nl9kb2N1bWVudGluZ19zb2Z0d2FyZS82Ml9jb21tZW50cy5tZA0KPiB8IDIwICstLS0tLQ0KPiA+ Pj4+PiAtLS0tDQo+ID4+Pj4+DQo+IDZfZG9jdW1lbnRpbmdfc29mdHdhcmUvNjRfd2hhdF95b3Vf bXVzdF9jb21tZW50Lm1kIHwgMzkNCj4gPj4+Pj4gKysrKysrKysrKysrKysrKysrKysNCj4gPj4+ Pj4gIFJFQURNRS5tZA0KPiB8ICAxICsNCj4gPj4+Pj4gIDMgZmlsZXMgY2hhbmdlZCwgNDIgaW5z ZXJ0aW9ucygrKSwgMTgNCj4gZGVsZXRpb25zKC0pDQo+ID4+Pj4+DQo+ID4+Pj4+IC0tDQo+ID4+ Pj4+IDIuMTkuMS4zLmczMDI0N2FhNWQyMDENCj4gPj4+Pj4NCj4gPj4NCj4gPj4NCj4gPj4NCj4g Pg0KPiA+DQo+ID4gDQo+ID4NCg0K