From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.d.kinney@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 24 Sep 2019 21:40:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 21:40:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,546,1559545200"; d="scan'208";a="201125225" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 24 Sep 2019 21:40:48 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 21:40:48 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.232]) by ORSMSX121.amr.corp.intel.com ([169.254.10.190]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 21:40:48 -0700 From: "Michael D Kinney" To: "Gao, Liming" , Leif Lindholm , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch Thread-Topic: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch Thread-Index: AQHVcumD8g+LUs7uP0SMy7Xa/7RE8Kc7/NoAgAAFhID//84QYA== Date: Wed, 25 Sep 2019 04:40:48 +0000 Message-ID: References: <20190924150519.10304-1-liming.gao@intel.com> <20190925001750.GP28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E500FB4@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E500FB4@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, September 24, 2019 5:38 PM > To: Leif Lindholm ; > devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [Patch] MdePkg Base.h: Define > STATIC_ASSERT macro as empty for EBC arch >=20 > Lefi: > Thanks for your comment. I will update the patch when > submit it. >=20 > Thanks > Liming > >-----Original Message----- > >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > >Sent: Wednesday, September 25, 2019 8:18 AM > >To: devel@edk2.groups.io; Gao, Liming > > >Cc: Kinney, Michael D > >Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define > STATIC_ASSERT > >macro as empty for EBC arch > > > >On Tue, Sep 24, 2019 at 11:05:19PM +0800, Liming Gao > wrote: > >> EBC compiler doesn't support C11 static_assert macro. > >> So, define STATIC_ASSERT as empty to pass EBC arch > build. > >> STATIC_ASSERT macro is introduced > >@204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0 > >> > >> Cc: Michael D Kinney > >> Signed-off-by: Liming Gao > >> --- > >> MdePkg/Include/Base.h | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/MdePkg/Include/Base.h > b/MdePkg/Include/Base.h index > >> ed85b98318..70e4d8daf1 100644 > >> --- a/MdePkg/Include/Base.h > >> +++ b/MdePkg/Include/Base.h > >> @@ -799,12 +799,15 @@ typedef UINTN *BASE_LIST; > >> @param Message Raised compiler diagnostic > message when expression > >is false. > >> > >> **/ > >> -#ifdef _MSC_EXTENSIONS > >> +#ifdef MDE_CPU_EBC > >> + #define STATIC_ASSERT(Expression, Message) #elif > _MSC_EXTENSIONS > >> #define STATIC_ASSERT static_assert #else > >> #define STATIC_ASSERT _Static_assert #endif > >> > >> + > > > >Please delete this spurious added blank line. > >With that: > >Reviewed-by: Leif Lindholm > > > >> // > >> // Verify that ProcessorBind.h produced UEFI Data > Types that are > >> compliant > >with > >> // Section 2.3.1 of the UEFI 2.3 Specification. > >> -- > >> 2.13.0.windows.1 > >> > >> > >>=20 > >>