From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.d.kinney@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Mon, 07 Oct 2019 11:16:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 11:15:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="206468634" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga001.fm.intel.com with ESMTP; 07 Oct 2019 11:15:59 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 11:15:58 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.232]) by ORSMSX121.amr.corp.intel.com ([169.254.10.190]) with mapi id 14.03.0439.000; Mon, 7 Oct 2019 11:15:58 -0700 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Kinney, Michael D" CC: "Wu, Jiaxin" , "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() Thread-Topic: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() Thread-Index: AQHVbZEoWPa1Z1ROekygC8UqPeJNyadPmzFQ Date: Mon, 7 Oct 2019 18:15:57 +0000 Message-ID: References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-19-lersek@redhat.com> In-Reply-To: <20190917194935.24322-19-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Laszlo Ersek > Sent: Tuesday, September 17, 2019 12:49 PM > To: edk2-devel-groups-io > Cc: Wu, Jiaxin ; Fu, Siyuan > > Subject: [edk2-devel] [PATCH 18/35] > NetworkPkg/DxeNetLib: fix type typo in > NetLibGetMacAddress() >=20 > NetLibGetSnpHandle() returns an EFI_HANDLE, not an > (EFI_HANDLE*). > NetLibGetMacAddress() only uses the return value > ("SnpHandle") for a NULL-check. Fix the type of > "SnpHandle". >=20 > This patch is a no-op. >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > lightly tested: MAC strings are displayed in UiApp >=20 > NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > index 8e2f720666ea..a39c20be3d34 100644 > --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c > @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( > EFI_SIMPLE_NETWORK_MODE SnpModeData; > EFI_MANAGED_NETWORK_PROTOCOL *Mnp; > EFI_SERVICE_BINDING_PROTOCOL *MnpSb; > - EFI_HANDLE *SnpHandle; > + EFI_HANDLE SnpHandle; > EFI_HANDLE MnpChildHandle; >=20 > ASSERT (MacAddress !=3D NULL); > -- > 2.19.1.3.g30247aa5d201 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this > group. >=20 > View/Reply Online (#47405): > https://edk2.groups.io/g/devel/message/47405 > Mute This Topic: https://groups.io/mt/34180219/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D