From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by mx.groups.io with SMTP id smtpd.web12.408.1571712326488145094
 for <devel@edk2.groups.io>;
 Mon, 21 Oct 2019 19:45:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.d.kinney@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 18:42:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.67,325,1566889200"; 
   d="scan'208";a="348910890"
Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6])
  by orsmga004.jf.intel.com with ESMTP; 21 Oct 2019 18:42:14 -0700
Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by
 ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 21 Oct 2019 18:42:13 -0700
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by
 ORSMSX160.amr.corp.intel.com ([169.254.13.29]) with mapi id 14.03.0439.000;
 Mon, 21 Oct 2019 18:42:13 -0700
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Gao, Liming"
	<liming.gao@intel.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions
Thread-Topic: [edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic:
 Remove __inline__ attribute for IO functions
Thread-Index: AQHVgu9X7skY1HyTXkmOO5LEU8lN56dl7dZw
Date: Tue, 22 Oct 2019 01:42:13 +0000
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9DEEF80@ORSMSX113.amr.corp.intel.com>
References: <1571099210-12432-1-git-send-email-liming.gao@intel.com>
 <1571099210-12432-6-git-send-email-liming.gao@intel.com>
In-Reply-To: <1571099210-12432-6-git-send-email-liming.gao@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.139]
MIME-Version: 1.0
Return-Path: michael.d.kinney@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Liming Gao
> Sent: Monday, October 14, 2019 5:27 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch v2 05/11] MdePkg
> BaseIoLibIntrinsic: Remove __inline__ attribute for IO
> functions
>=20
> __inline__ has no functional difference effect with the
> GCC48 / GCC49 / GCC5 toolchains, but it breaks the
> build with CLANG9. Remove __inline__.
>=20
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -----
> -
>  1 file changed, 6 deletions(-)
>=20
> diff --git
> a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> index 055f0a947e..b3a1a20256 100644
> --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> @@ -32,7 +32,6 @@
>    @return The value read.
>=20
>  **/
> -__inline__
>  UINT8
>  EFIAPI
>  IoRead8 (
> @@ -60,7 +59,6 @@ IoRead8 (
>    @return The value written the I/O port.
>=20
>  **/
> -__inline__
>  UINT8
>  EFIAPI
>  IoWrite8 (
> @@ -87,7 +85,6 @@ IoWrite8 (
>    @return The value read.
>=20
>  **/
> -__inline__
>  UINT16
>  EFIAPI
>  IoRead16 (
> @@ -117,7 +114,6 @@ IoRead16 (
>    @return The value written the I/O port.
>=20
>  **/
> -__inline__
>  UINT16
>  EFIAPI
>  IoWrite16 (
> @@ -145,7 +141,6 @@ IoWrite16 (
>    @return The value read.
>=20
>  **/
> -__inline__
>  UINT32
>  EFIAPI
>  IoRead32 (
> @@ -175,7 +170,6 @@ IoRead32 (
>    @return The value written the I/O port.
>=20
>  **/
> -__inline__
>  UINT32
>  EFIAPI
>  IoWrite32 (
> --
> 2.13.0.windows.1
>=20
>=20
>=20