From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch v3 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain
Date: Tue, 22 Oct 2019 01:44:53 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9DEEF95@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1571295356-11608-5-git-send-email-liming.gao@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Liming Gao
> Sent: Wednesday, October 16, 2019 11:56 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [Patch v3 04/11] MdePkg Base.h:
> Add definition for CLANG9 tool chain
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
> CLANG9 tool chain defines __clang__ macro only, doesn't
> define __GNUC__ macro. But, it uses some same
> definitions with GCC.
> So, update base definition for CLANG9 tool chain.
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> MdePkg/Include/Base.h | 6 +++---
> MdePkg/Include/Ia32/ProcessorBind.h | 4 ++--
> MdePkg/Include/X64/ProcessorBind.h | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/MdePkg/Include/Base.h
> b/MdePkg/Include/Base.h index d94b8a5f93..4680e64136
> 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -621,9 +621,9 @@ typedef char* VA_LIST;
> #define VA_END(Marker) (Marker =
> (VA_LIST) 0)
> #define VA_COPY(Dest, Start) ((void)((Dest)
> = (Start)))
>
> -#elif defined(__GNUC__)
> +#elif defined(__GNUC__) || defined(__clang__)
>
> -#if defined(MDE_CPU_X64) &&
> !defined(NO_MSABI_VA_FUNCS)
> +#if defined(MDE_CPU_X64) &&
> !defined(NO_MSABI_VA_FUNCS) &&
> +!defined(__clang__)
> //
> // X64 only. Use MS ABI version of GCC built-in macros
> for variable argument lists.
> //
> @@ -1274,7 +1274,7 @@ typedef UINTN RETURN_STATUS;
>
> **/
> #define RETURN_ADDRESS(L) ((L == 0) ?
> _ReturnAddress() : (VOID *) 0)
> -#elif defined(__GNUC__)
> +#elif defined (__GNUC__) || defined (__clang__)
> void * __builtin_return_address (unsigned int
> level);
> /**
> Get the return address of the calling function.
> diff --git a/MdePkg/Include/Ia32/ProcessorBind.h
> b/MdePkg/Include/Ia32/ProcessorBind.h
> index 497c58b33b..fa4b7e8e98 100644
> --- a/MdePkg/Include/Ia32/ProcessorBind.h
> +++ b/MdePkg/Include/Ia32/ProcessorBind.h
> @@ -281,7 +281,7 @@ typedef INT32 INTN;
> /// Microsoft* compiler specific method for EFIAPI
> calling convention.
> ///
> #define EFIAPI __cdecl
> -#elif defined(__GNUC__)
> +#elif defined(__GNUC__) || defined(__clang__)
> ///
> /// GCC specific method for EFIAPI calling
> convention.
> ///
> @@ -294,7 +294,7 @@ typedef INT32 INTN;
> #define EFIAPI
> #endif
>
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) || defined(__clang__)
> ///
> /// For GNU assembly code, .global or .globl can
> declare global symbols.
> /// Define this macro to unify the usage.
> diff --git a/MdePkg/Include/X64/ProcessorBind.h
> b/MdePkg/Include/X64/ProcessorBind.h
> index 6f65acd609..387e9c5c9c 100644
> --- a/MdePkg/Include/X64/ProcessorBind.h
> +++ b/MdePkg/Include/X64/ProcessorBind.h
> @@ -313,7 +313,7 @@ typedef INT64 INTN;
> #define EFIAPI
> #endif
>
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) || defined(__clang__)
> ///
> /// For GNU assembly code, .global or .globl can
> declare global symbols.
> /// Define this macro to unify the usage.
> --
> 2.13.0.windows.1
>
>
>
next prev parent reply other threads:[~2019-10-22 2:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 6:55 [Patch v3 00/11] New Cross OS tool chain CLANG9 Liming Gao
2019-10-17 6:55 ` [Patch v3 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path Liming Gao
2019-10-17 6:55 ` [Patch v3 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image Liming Gao
2019-10-17 8:18 ` Bob Feng
2019-10-17 6:55 ` [Patch v3 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize Liming Gao
2019-10-17 8:17 ` Bob Feng
2019-10-17 6:55 ` [Patch v3 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain Liming Gao
2019-10-22 1:44 ` Michael D Kinney [this message]
2019-10-17 6:55 ` [Patch v3 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions Liming Gao
2019-10-17 6:55 ` [Patch v3 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool Liming Gao
2019-10-17 6:55 ` [Patch v3 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain Liming Gao
2019-10-17 6:55 ` [Patch v3 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build Liming Gao
2019-10-17 6:55 ` [Patch v3 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used Liming Gao
2019-10-17 6:55 ` [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain Liming Gao
2019-10-17 7:27 ` Ni, Ray
2019-10-17 17:15 ` Andrew Fish
2019-10-18 14:27 ` Liming Gao
2019-10-25 18:45 ` [edk2-devel] " Andrew Fish
2019-10-30 15:43 ` Liming Gao
2019-11-07 17:19 ` Leif Lindholm
2019-11-07 17:54 ` Andrew Fish
2019-11-07 18:37 ` Leif Lindholm
2019-11-08 0:44 ` Andrew Fish
2019-11-08 1:49 ` Liming Gao
2019-11-08 3:34 ` Ni, Ray
2019-11-11 16:39 ` Leif Lindholm
2019-11-11 16:51 ` Andrew Fish
2019-11-11 16:51 ` Andrew Fish
2019-11-12 0:40 ` Liming Gao
2019-11-12 1:46 ` Ni, Ray
[not found] ` <15D646FBD4763D55.27853@groups.io>
2019-11-12 3:10 ` Ni, Ray
[not found] ` <15D64B9456F8C33A.2582@groups.io>
2019-11-12 3:22 ` Ni, Ray
2019-11-12 3:48 ` Michael D Kinney
2019-11-12 6:48 ` Ni, Ray
2019-11-12 15:26 ` Liming Gao
2019-11-11 16:36 ` Leif Lindholm
2019-11-07 17:06 ` Leif Lindholm
2019-10-17 6:55 ` [Patch v3 11/11] OvmfPkg: " Liming Gao
2019-10-17 16:30 ` [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 Leif Lindholm
2019-10-18 13:21 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9DEEF95@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox